Re: Review Request 58220: Used move semantics when returning gzip compressed responses.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58220/#review171318 --- Ship it! Ship It! - Michael Park On April 5, 2017, 1:53 p.m., Anand Mazumdar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58220/ > --- > > (Updated April 5, 2017, 1:53 p.m.) > > > Review request for mesos and Michael Park. > > > Repository: mesos > > > Description > --- > > We used to copy the compressed body into the eventual response. > For large responses especially from `/state` endpoint made by the > Web UI, these can be pretty expensive. This change replaces the > copy by a move operation. > > > Diffs > - > > 3rdparty/libprocess/src/encoder.hpp > ea629d72a68e093343562db1ef7e5d00c723f03b > > > Diff: https://reviews.apache.org/r/58220/diff/1/ > > > Testing > --- > > make check > > For a ~10mb compressed response, the original took 3ms vs 2ns (newer). > > > Thanks, > > Anand Mazumdar > >
Re: Review Request 58220: Used move semantics when returning gzip compressed responses.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58220/#review171177 --- Patch looks great! Reviews applied: [58220] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On April 5, 2017, 1:53 p.m., Anand Mazumdar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58220/ > --- > > (Updated April 5, 2017, 1:53 p.m.) > > > Review request for mesos and Michael Park. > > > Repository: mesos > > > Description > --- > > We used to copy the compressed body into the eventual response. > For large responses especially from `/state` endpoint made by the > Web UI, these can be pretty expensive. This change replaces the > copy by a move operation. > > > Diffs > - > > 3rdparty/libprocess/src/encoder.hpp > ea629d72a68e093343562db1ef7e5d00c723f03b > > > Diff: https://reviews.apache.org/r/58220/diff/1/ > > > Testing > --- > > make check > > For a ~10mb compressed response, the original took 3ms vs 2ns (newer). > > > Thanks, > > Anand Mazumdar > >
