Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

> On July 18, 2017, 4:08 a.m., Benjamin Mahler wrote: > > Since these were pretty minor adjustments, I took care of these and committed your patch. I didn't add the `dataSizeMb` filter to clean some of the code up, so if you want to follow up with a patch for that, that would be much

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60370/#review180790 --- Fix it, then Ship it! src/webui/master/static/agent.html

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60370/#review180544 --- Patch looks great! Reviews applied: [60867, 60636, 60369, 60539,

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60370/#review179587 --- Fix it, then Ship it! Ship It!

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

> On July 3, 2017, 6:27 p.m., haosdent huang wrote: > > src/webui/master/static/js/controllers.js > > Lines 610 (patched) > > > > > > How about > > > > ``` > > $scope.agent.resource_reservations = > >

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

> On July 3, 2017, 6:27 p.m., haosdent huang wrote: > > src/webui/master/static/js/controllers.js > > Lines 610 (patched) > > > > > > How about > > > > ``` > > $scope.agent.resource_reservations = > >

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

> On July 3, 2017, 6:27 p.m., haosdent huang wrote: > > src/webui/master/static/js/controllers.js > > Lines 610 (patched) > > > > > > How about > > > > ``` > > $scope.agent.resource_reservations = > >

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

> On July 3, 2017, 6:27 p.m., haosdent huang wrote: > > src/webui/master/static/js/controllers.js > > Lines 610 (patched) > > > > > > How about > > > > ``` > > $scope.agent.resource_reservations = > >

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

> On July 3, 2017, 6:27 p.m., haosdent huang wrote: > > src/webui/master/static/js/controllers.js > > Lines 610 (patched) > > > > > > How about > > > > ``` > > $scope.agent.resource_reservations = > >

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

> On June 27, 2017, 5:33 p.m., haosdent huang wrote: > > src/webui/master/static/js/controllers.js > > Lines 604 (patched) > > > > > > `ng-repeat` support map, have you try > > > > ``` > >

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60370/#review179531 --- src/webui/master/static/js/controllers.js Lines 610 (patched)

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60370/#review179189 --- Bad patch! Reviews applied: [60370, 60369] Failed command:

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

> On June 23, 2017, 4:06 p.m., haosdent huang wrote: > > src/webui/master/static/agent.html > > Lines 184 (patched) > > > > > > Is `|| 0` necessary here? > > Andrei Budnik wrote: > I think yes, because we might

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60370/ --- (Updated June 28, 2017, 8:52 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

> On June 27, 2017, 5:33 p.m., haosdent huang wrote: > > src/webui/master/static/js/controllers.js > > Lines 604 (patched) > > > > > > `ng-repeat` support map, have you try > > > > ``` > >

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

> On June 23, 2017, 4:06 p.m., haosdent huang wrote: > > src/webui/master/static/agent.html > > Lines 184 (patched) > > > > > > Is `|| 0` necessary here? > > Andrei Budnik wrote: > I think yes, because we might

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

> On June 27, 2017, 5:33 p.m., haosdent huang wrote: > > src/webui/master/static/js/controllers.js > > Lines 604 (patched) > > > > > > `ng-repeat` support map, have you try > > > > ``` > >

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

> On June 27, 2017, 5:33 p.m., haosdent huang wrote: > > src/webui/master/static/js/controllers.js > > Lines 604 (patched) > > > > > > `ng-repeat` support map, have you try > > > > ``` > >

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60370/ --- (Updated June 28, 2017, 12:37 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

> On June 23, 2017, 4:06 p.m., haosdent huang wrote: > > src/webui/master/static/agent.html > > Lines 184 (patched) > > > > > > Is `|| 0` necessary here? > > Andrei Budnik wrote: > I think yes, because we might

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60370/ --- (Updated June 28, 2017, 12:29 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60370/#review178996 --- src/webui/master/static/js/controllers.js Lines 604 (patched)

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

> On June 23, 2017, 4:06 p.m., haosdent huang wrote: > > src/webui/master/static/agent.html > > Lines 176 (patched) > > > > > > Should we use `*` here to keep consistent with other parts? > > Andrei Budnik wrote: >

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60370/ --- (Updated June 27, 2017, 5:10 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

> On June 23, 2017, 4:06 p.m., haosdent huang wrote: > > src/webui/master/static/agent.html > > Lines 176 (patched) > > > > > > Should we use `*` here to keep consistent with other parts? There is related

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60370/#review178801 --- src/webui/master/static/agent.html Lines 176 (patched)

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60370/#review178705 --- Patch looks great! Reviews applied: [60369, 60370] Passed