Re: Review Request 61118: Libprocess: Building gRPC support with CMake.

[Chun-Hung Hsiao]

> On April 12, 2018, 4:55 p.m., Andrew Schwartzmeyer wrote:
> > 3rdparty/libprocess/src/tests/CMakeLists.txt
> > Lines 91 (patched)
> > 
> >
> > I think this should instead be appended above. That is, after setting 
> > `GRPC_TESTS_PROTOS`, do a `list(APPEND PROCESS_TESTS_SRC 
> > ${GRPC_TESTS_PROTOS})`, to be consistent with the rest.

Since the files in `${GRPC_TESTS_PROTOS}` are generated files, should we put 
them into `${PROCESS_TESTS_SRC}`?


- Chun-Hung


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61118/#review201014
---


On March 19, 2018, 11:53 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61118/
> ---
> 
> (Updated March 19, 2018, 11:53 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and 
> Joseph Wu.
> 
> 
> Bugs: MESOS-7881
> https://issues.apache.org/jira/browse/MESOS-7881
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch enables CMake to build code for gRPC support in libprocess
> along with tests.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/CMakeLists.txt 
> 0ce7dac5deea94623530820d173ce3ffe5b42ea4 
>   3rdparty/libprocess/src/tests/CMakeLists.txt 
> d624402bc9efb43a130a2afdf27cfc1aa69010e4 
> 
> 
> Diff: https://reviews.apache.org/r/61118/diff/4/
> 
> 
> Testing
> ---
> 
> `sudo make check` with CMake
> `cd 3rdparty/libprocess/src/tests && make libprocess-tests && 
> ./libprocess-tests`
> 
> 
> NOTE: Testing on Windowns is not done yet.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 61118: Libprocess: Building gRPC support with CMake.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61118/#review201014
---




3rdparty/libprocess/src/tests/CMakeLists.txt
Lines 91 (patched)


I think this should instead be appended above. That is, after setting 
`GRPC_TESTS_PROTOS`, do a `list(APPEND PROCESS_TESTS_SRC 
${GRPC_TESTS_PROTOS})`, to be consistent with the rest.



3rdparty/libprocess/src/tests/CMakeLists.txt
Lines 93 (patched)


Maybe leave a note that this is for the generated gRPC headers.


- Andrew Schwartzmeyer


On March 19, 2018, 4:53 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61118/
> ---
> 
> (Updated March 19, 2018, 4:53 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and 
> Joseph Wu.
> 
> 
> Bugs: MESOS-7881
> https://issues.apache.org/jira/browse/MESOS-7881
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch enables CMake to build code for gRPC support in libprocess
> along with tests.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/CMakeLists.txt 
> 0ce7dac5deea94623530820d173ce3ffe5b42ea4 
>   3rdparty/libprocess/src/tests/CMakeLists.txt 
> d624402bc9efb43a130a2afdf27cfc1aa69010e4 
> 
> 
> Diff: https://reviews.apache.org/r/61118/diff/4/
> 
> 
> Testing
> ---
> 
> `sudo make check` with CMake
> `cd 3rdparty/libprocess/src/tests && make libprocess-tests && 
> ./libprocess-tests`
> 
> 
> NOTE: Testing on Windowns is not done yet.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 61118: libprocess: Building gRPC support with CMake.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61118/
---

(Updated March 19, 2018, 11:53 p.m.)


Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and 
Joseph Wu.


Summary (updated)
-

libprocess: Building gRPC support with CMake.


Bugs: MESOS-7810
https://issues.apache.org/jira/browse/MESOS-7810


Repository: mesos


Description (updated)
---

This patch enables CMake to build code for gRPC support in libprocess
along with tests.


Diffs (updated)
-

  3rdparty/libprocess/src/CMakeLists.txt 
0ce7dac5deea94623530820d173ce3ffe5b42ea4 
  3rdparty/libprocess/src/tests/CMakeLists.txt 
d624402bc9efb43a130a2afdf27cfc1aa69010e4 


Diff: https://reviews.apache.org/r/61118/diff/4/

Changes: https://reviews.apache.org/r/61118/diff/3-4/


Testing (updated)
---

`sudo make check` with CMake
`cd 3rdparty/libprocess/src/tests && make libprocess-tests && 
./libprocess-tests`


NOTE: Testing on Windowns is not done yet.


Thanks,

Chun-Hung Hsiao