Re: Review Request 61262: Added 'heartbeat' event for the operator API.

> On March 6, 2018, 2:44 a.m., Zhitao Li wrote: > > src/master/http.cpp > > Lines 845-857 (original), 845-861 (patched) > > > > > > I believe this is a behavior change. > > > > Previous, `master->subscribe(.

Re: Review Request 61262: Added 'heartbeat' event for the operator API.

> On March 6, 2018, 2:44 a.m., Zhitao Li wrote: > > src/master/http.cpp > > Lines 845-857 (original), 845-861 (patched) > > > > > > I believe this is a behavior change. > > > > Previous, `master->subscribe(.

Re: Review Request 61262: Added 'heartbeat' event for the operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61262/#review198678 --- src/master/http.cpp Lines 845-857 (original), 845-861 (patched) <

Re: Review Request 61262: Added 'heartbeat' event for the operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61262/#review183259 --- Patch looks great! Reviews applied: [61262] Logs available here:

Re: Review Request 61262: Added 'heartbeat' event for the operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61262/#review183251 --- Patch looks great! Reviews applied: [61262] Passed command: supp

Re: Review Request 61262: Added 'heartbeat' event for the operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61262/ --- (Updated Aug. 18, 2017, 6:54 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 61262: Added 'heartbeat' event for the operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61262/#review183244 --- src/master/master.hpp Lines 309-312 (patched)

Re: Review Request 61262: Added 'heartbeat' event for the operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61262/ --- (Updated Aug. 18, 2017, 6:12 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 61262: Added 'heartbeat' event for the operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61262/#review183163 --- src/master/master.hpp Lines 309 (patched)

Re: Review Request 61262: Added 'heartbeat' event for the operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61262/#review183166 --- Patch looks great! Reviews applied: [61262] Passed command: supp

Re: Review Request 61262: Added 'heartbeat' event for the operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61262/ --- (Updated Aug. 17, 2017, 9:20 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 61262: Added 'heartbeat' event for the operator API.

> On Aug. 15, 2017, 6:44 p.m., Greg Mann wrote: > > src/master/master.hpp > > Lines 309-311 (patched) > > > > > > Now that we're sending heartbeats for multiple purposes, I'm concerned > > that the logging will be a

Re: Review Request 61262: Added 'heartbeat' event for the operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61262/#review182958 --- src/master/master.hpp Lines 309-311 (patched)

Re: Review Request 61262: Added 'heartbeat' event for the operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61262/#review182953 --- I think this needs a rebase? - Greg Mann On Aug. 14, 2017, 9:51

Re: Review Request 61262: Added 'heartbeat' event for the operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61262/#review182915 --- Bad patch! Reviews applied: [61262] Failed command: python suppo

Re: Review Request 61262: Added 'heartbeat' event for the operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61262/ --- (Updated Aug. 14, 2017, 9:51 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 61262: Added 'heartbeat' event for the operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61262/#review182746 --- Patch looks great! Reviews applied: [61262] Logs available here:

Re: Review Request 61262: Added 'heartbeat' event for the operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61262/#review182735 --- Patch looks great! Reviews applied: [61262] Logs available here:

Re: Review Request 61262: Added 'heartbeat' event for the operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61262/#review182627 --- src/master/master.hpp Lines 1826 (patched)