Re: Review Request 61287: Removed `GroupSource` from `stout`.
> On Aug. 8, 2017, 3:36 p.m., Cloudbase wrote: > > Patch looks great! > > > > Reviews applied: [61287] > > > > Logs available here: http://test.local Sorry about this comment! It was just a test. - Cloudbase --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61287/#review182395 --- On Aug. 2, 2017, 12:53 a.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61287/ > --- > > (Updated Aug. 2, 2017, 12:53 a.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-6721 > https://issues.apache.org/jira/browse/MESOS-6721 > > > Repository: mesos > > > Description > --- > > Removed `GroupSource` from `stout`. > > > Diffs > - > > 3rdparty/stout/cmake/StoutConfigure.cmake > 69474a830e3cbd2e3e2718e4a7569137fc6df6b8 > 3rdparty/stout/tests/CMakeLists.txt > 953be64f1fb675fd1166fa77d0b3a56a5763d243 > > > Diff: https://reviews.apache.org/r/61287/diff/1/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 61287: Removed `GroupSource` from `stout`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61287/#review182395 --- Patch looks great! Reviews applied: [61287] Logs available here: http://test.local - Cloudbase On Aug. 2, 2017, 12:53 a.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61287/ > --- > > (Updated Aug. 2, 2017, 12:53 a.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-6721 > https://issues.apache.org/jira/browse/MESOS-6721 > > > Repository: mesos > > > Description > --- > > Removed `GroupSource` from `stout`. > > > Diffs > - > > 3rdparty/stout/cmake/StoutConfigure.cmake > 69474a830e3cbd2e3e2718e4a7569137fc6df6b8 > 3rdparty/stout/tests/CMakeLists.txt > 953be64f1fb675fd1166fa77d0b3a56a5763d243 > > > Diff: https://reviews.apache.org/r/61287/diff/1/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 61287: Removed `GroupSource` from `stout`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61287/#review182351 --- Ship it! [Tentative "Ship It!" as I review this entire chain.] I'm going to mention that the source grouping (as it is currently) is still somewhat brittle and isn't necessary for the CMake MVP. That's why we're removing it for now. - Joseph Wu On Aug. 1, 2017, 5:53 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61287/ > --- > > (Updated Aug. 1, 2017, 5:53 p.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-6721 > https://issues.apache.org/jira/browse/MESOS-6721 > > > Repository: mesos > > > Description > --- > > Removed `GroupSource` from `stout`. > > > Diffs > - > > 3rdparty/stout/cmake/StoutConfigure.cmake > 69474a830e3cbd2e3e2718e4a7569137fc6df6b8 > 3rdparty/stout/tests/CMakeLists.txt > 953be64f1fb675fd1166fa77d0b3a56a5763d243 > > > Diff: https://reviews.apache.org/r/61287/diff/1/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
