Re: Review Request 61291: Imported `glog` library.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61291/#review184436 --- Going to squash the following commits into this one: Review: https://reviews.apache.org/r/61303/ Review: https://reviews.apache.org/r/61294/ Review: https://reviews.apache.org/r/61312/ Review: https://reviews.apache.org/r/61300/ Review: https://reviews.apache.org/r/61327/ Review: https://reviews.apache.org/r/61334/ Review: https://reviews.apache.org/r/61340/ Review: https://reviews.apache.org/r/61337/ Review: https://reviews.apache.org/r/61344/ Review: https://reviews.apache.org/r/61346/ Review: https://reviews.apache.org/r/61357/ - Joseph Wu On Aug. 11, 2017, 4:21 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61291/ > --- > > (Updated Aug. 11, 2017, 4:21 p.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-3576 > https://issues.apache.org/jira/browse/MESOS-3576 > > > Repository: mesos > > > Description > --- > > Review: https://reviews.apache.org/r/61291 > > > Diffs > - > > 3rdparty/CMakeLists.txt f4feaf90b4750338cfa2127524a5e6556a86d063 > > > Diff: https://reviews.apache.org/r/61291/diff/3/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 61291: Imported `glog` library.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61291/#review183034 --- Ship it! LGTM. Going to add some whitespace around some comments though. - Joseph Wu On Aug. 11, 2017, 4:21 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61291/ > --- > > (Updated Aug. 11, 2017, 4:21 p.m.) > > > Review request for mesos and Joseph Wu. > > > Repository: mesos > > > Description > --- > > Review: https://reviews.apache.org/r/61291 > > > Diffs > - > > 3rdparty/CMakeLists.txt f4feaf90b4750338cfa2127524a5e6556a86d063 > > > Diff: https://reviews.apache.org/r/61291/diff/3/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 61291: Imported `glog` library.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61291/ --- (Updated Aug. 11, 2017, 4:20 p.m.) Review request for mesos. Changes --- Disallow linking to static library. Also brought over `GTEST_CONFIG=no` from Autotools. Note that when we update Glog, and build with CMake, we'll be able to link to shared or static as needed. Repository: mesos Description --- Review: https://reviews.apache.org/r/61291 Diffs (updated) - 3rdparty/CMakeLists.txt f4feaf90b4750338cfa2127524a5e6556a86d063 Diff: https://reviews.apache.org/r/61291/diff/3/ Changes: https://reviews.apache.org/r/61291/diff/2-3/ Testing --- Thanks, Andrew Schwartzmeyer
Re: Review Request 61291: Imported `glog` library.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61291/ --- (Updated Aug. 8, 2017, 5:54 p.m.) Review request for mesos. Changes --- Moved glog compile definitions to here. Repository: mesos Description (updated) --- Review: https://reviews.apache.org/r/61291 Diffs (updated) - 3rdparty/CMakeLists.txt f4feaf90b4750338cfa2127524a5e6556a86d063 Diff: https://reviews.apache.org/r/61291/diff/2/ Changes: https://reviews.apache.org/r/61291/diff/1-2/ Testing --- Thanks, Andrew Schwartzmeyer
