Re: Review Request 61303: Imported `curl` library.

2017-08-17 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61303/#review183149
---


Ship it!




Another potential squash for https://reviews.apache.org/r/61291/

- Joseph Wu


On Aug. 8, 2017, 5:53 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61303/
> ---
> 
> (Updated Aug. 8, 2017, 5:53 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Uses `ExternalProject_Add` on Windows and `FindCURL` elsewhere.
> 
> Review: https://reviews.apache.org/r/61303
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt f4feaf90b4750338cfa2127524a5e6556a86d063 
> 
> 
> Diff: https://reviews.apache.org/r/61303/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 61303: Imported `curl` library.

2017-08-08 Thread Andrew Schwartzmeyer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61303/
---

(Updated Aug. 8, 2017, 5:53 p.m.)


Review request for mesos.


Changes
---

Moved CURL_STATICLIB definition to here.


Repository: mesos


Description (updated)
---

Uses `ExternalProject_Add` on Windows and `FindCURL` elsewhere.

Review: https://reviews.apache.org/r/61303


Diffs (updated)
-

  3rdparty/CMakeLists.txt f4feaf90b4750338cfa2127524a5e6556a86d063 


Diff: https://reviews.apache.org/r/61303/diff/2/

Changes: https://reviews.apache.org/r/61303/diff/1-2/


Testing
---


Thanks,

Andrew Schwartzmeyer