Re: Review Request 61406: Introduced `--disallow_sharing_agent_pid_namespace` agent flag.

2017-08-08 Thread Gilbert Song

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61406/#review182455
---


Ship it!




Ship It!

- Gilbert Song


On Aug. 6, 2017, 7:52 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61406/
> ---
> 
> (Updated Aug. 6, 2017, 7:52 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Gilbert Song, Jie Yu, Kevin Klues, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-7853
> https://issues.apache.org/jira/browse/MESOS-7853
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduced `--disallow_sharing_agent_pid_namespace` agent flag.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 041c3dfb9c0c1718770f74dfb33a9f5d6fbe9b61 
>   src/slave/flags.hpp 032880dfa68cd29420e559d34e592e57827cfc07 
>   src/slave/flags.cpp 4171604090ffebe79fa35579458cabff7270c0de 
> 
> 
> Diff: https://reviews.apache.org/r/61406/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>



Re: Review Request 61406: Introduced `--disallow_sharing_agent_pid_namespace` agent flag.

2017-08-06 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61406/
---

(Updated Aug. 7, 2017, 10:52 a.m.)


Review request for mesos, Gastón Kleiman, Gilbert Song, Jie Yu, Kevin Klues, 
and Vinod Kone.


Changes
---

Addressed comments.


Summary (updated)
-

Introduced `--disallow_sharing_agent_pid_namespace` agent flag.


Bugs: MESOS-7853
https://issues.apache.org/jira/browse/MESOS-7853


Repository: mesos


Description (updated)
---

Introduced `--disallow_sharing_agent_pid_namespace` agent flag.


Diffs (updated)
-

  docs/configuration.md 041c3dfb9c0c1718770f74dfb33a9f5d6fbe9b61 
  src/slave/flags.hpp 032880dfa68cd29420e559d34e592e57827cfc07 
  src/slave/flags.cpp 4171604090ffebe79fa35579458cabff7270c0de 


Diff: https://reviews.apache.org/r/61406/diff/4/

Changes: https://reviews.apache.org/r/61406/diff/3-4/


Testing
---


Thanks,

Qian Zhang