Re: Review Request 61428: Added pid ns sharing based on agent flag and protobuf message field.

2017-08-11 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61428/#review182739 --- Ship it! Ship It! - Gilbert Song On Aug. 8, 2017, 2:40

Re: Review Request 61428: Added pid ns sharing based on agent flag and protobuf message field.

2017-08-08 Thread Qian Zhang
> On Aug. 5, 2017, 8:33 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/namespaces/pid.cpp > > Lines 130 (patched) > > > > > > Could we reverse two logics above? so that we can avoid the size

Re: Review Request 61428: Added pid ns sharing based on agent flag and protobuf message field.

2017-08-08 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61428/ --- (Updated Aug. 8, 2017, 5:40 p.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 61428: Added pid ns sharing based on agent flag and protobuf message field.

2017-08-07 Thread Gilbert Song
> On Aug. 4, 2017, 5:33 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/namespaces/pid.cpp > > Lines 130 (patched) > > > > > > Could we reverse two logics above? so that we can avoid the size

Re: Review Request 61428: Added pid ns sharing based on agent flag and protobuf message field.

2017-08-06 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61428/ --- (Updated Aug. 7, 2017, 10:55 a.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 61428: Added pid ns sharing based on agent flag and protobuf message field.

2017-08-05 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61428/ --- (Updated Aug. 5, 2017, 11:06 p.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 61428: Added pid ns sharing based on agent flag and protobuf message field.

2017-08-05 Thread Qian Zhang
> On Aug. 5, 2017, 8:33 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/namespaces/pid.cpp > > Lines 130 (patched) > > > > > > Could we reverse two logics above? so that we can avoid the size

Re: Review Request 61428: Added pid ns sharing based on agent flag and protobuf message field.

2017-08-05 Thread Qian Zhang
> On Aug. 5, 2017, 8:42 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/namespaces/pid.cpp > > Lines 85-86 (patched) > > > > > > I know in proto2 and proto3 `boolean` defaults to be `false`. But

Re: Review Request 61428: Added pid ns sharing based on agent flag and protobuf message field.

2017-08-04 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61428/#review182248 --- src/slave/containerizer/mesos/isolators/namespaces/pid.cpp Lines

Re: Review Request 61428: Added pid ns sharing based on agent flag and protobuf message field.

2017-08-04 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61428/#review182235 --- src/slave/containerizer/mesos/isolators/namespaces/pid.cpp Lines

Re: Review Request 61428: Added pid ns sharing based on agent flag and protobuf message field.

2017-08-04 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61428/ --- (Updated Aug. 5, 2017, 12:39 a.m.) Review request for mesos, Gastón Kleiman,