Re: Review Request 61515: Updated `CompilationConfigure.cmake` for imported libraries.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61515/#review184459 --- Ship it! Ship It! - Joseph Wu On Aug. 9, 2017, 7:53 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61515/ > --- > > (Updated Aug. 9, 2017, 7:53 p.m.) > > > Review request for mesos and Joseph Wu. > > > Repository: mesos > > > Description > --- > > Windows and Linux have converged on several libraries (ZooKeeper, > Protobuf, and libevent) such that the same bundled version is used, so > the warning message was updated. > > Third-party specific compilation flags were moved to the import of each > library, so this configuration no longer needs to include it. > > The minimum CMake version was updated and usupports `string(TIMESTAMP)`, > deprecating the `date` work-around. > > > Diffs > - > > cmake/CompilationConfigure.cmake 2109697e02e58c673948f2ae67ef8255d16aa736 > > > Diff: https://reviews.apache.org/r/61515/diff/2/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 61515: Updated `CompilationConfigure.cmake` for imported libraries.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61515/ --- (Updated Aug. 9, 2017, 7:53 p.m.) Review request for mesos and Joseph Wu. Changes --- Nothing else is referred to here with the "lib" prefix, so I removed it from libapr. Repository: mesos Description (updated) --- Windows and Linux have converged on several libraries (ZooKeeper, Protobuf, and libevent) such that the same bundled version is used, so the warning message was updated. Third-party specific compilation flags were moved to the import of each library, so this configuration no longer needs to include it. The minimum CMake version was updated and usupports `string(TIMESTAMP)`, deprecating the `date` work-around. Diffs (updated) - cmake/CompilationConfigure.cmake 2109697e02e58c673948f2ae67ef8255d16aa736 Diff: https://reviews.apache.org/r/61515/diff/2/ Changes: https://reviews.apache.org/r/61515/diff/1-2/ Testing --- Thanks, Andrew Schwartzmeyer
