> On Aug. 9, 2017, 6:07 p.m., James Peach wrote:
> > We still need to switch to using the `major` and `minor` macros from
> > `sys/sysmacros.h` so avoid the deprecation warning.
> > [Here's](https://paste.fedoraproject.org/paste/QvCDIi9ZUeLG2MhVIDwhOA) what
> > I would recommend.
> >
> > ```
> > In file included from
> > ../../src/slave/containerizer/mesos/linux_launcher.cpp:34:0:
> > ../../src/linux/cgroups.hpp:418:13: error: In the GNU C Library, "major" is
> > defined
> > by . For historical compatibility, it is
> > currently defined by as well, but we plan to
> > remove this soon. To use "major", include
> > directly. If you did not intend to use a system-defined macro
> > "major", you should undefine it after including . [-Werror]
> >inline unsigned int getMajor() const { return major(value); }
> > ^~~
> > ```
We also need `sys/sysmacros.h` in
`src/slave/containerizer/mesos/isolators/cgroups/subsystems/blkio.cpp`.
- James
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61531/#review182503
---
On Aug. 9, 2017, 5:38 p.m., Gilbert Song wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61531/
> ---
>
> (Updated Aug. 9, 2017, 5:38 p.m.)
>
>
> Review request for mesos, Ilya Pronin, Jie Yu, James Peach, Qian Zhang, and
> Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Fixed the device number proto 'major' and 'minor' to avoid MACROs.
>
>
> Diffs
> -
>
> include/mesos/mesos.proto f31f5bdc2ace2b261885b252e7c01ceb9b76c461
> include/mesos/v1/mesos.proto 66386a84bc21989d1c1237e629d5d04662a368fa
> src/slave/containerizer/mesos/isolators/cgroups/subsystems/blkio.cpp
> 96014b560377b5c716e30781de18d34c2ea8e17b
>
>
> Diff: https://reviews.apache.org/r/61531/diff/1/
>
>
> Testing
> ---
>
>
> Thanks,
>
> Gilbert Song
>
>