Re: Review Request 61811: Flattened continuation chains in containerizer for readability.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61811/#review195734 --- Ship it! Ship It! - Michael Park On Jan. 18, 2018, 5:11 a.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61811/ > --- > > (Updated Jan. 18, 2018, 5:11 a.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone. > > > Repository: mesos > > > Description > --- > > See summary. > > > Diffs > - > > src/slave/containerizer/mesos/containerizer.cpp > f69f65a5033ce0c1fa2fe9591d8c6bbada5e09fb > > > Diff: https://reviews.apache.org/r/61811/diff/4/ > > > Testing > --- > > make check on: > `Apple LLVM version 8.0.0 (clang-800.0.42.1)` on Mac OS 10.11.6 > `c++ (GCC) 6.2.1 20160916 (Red Hat 6.2.1-2)` on Fedora 24 > > > Thanks, > > Alexander Rukletsov > >
Re: Review Request 61811: Flattened continuation chains in containerizer for readability.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61811/#review195721 --- PASS: Mesos patch 61811 was successfully built and tested. Reviews applied: `['61811']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/61811 - Mesos Reviewbot Windows On Jan. 18, 2018, 1:11 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61811/ > --- > > (Updated Jan. 18, 2018, 1:11 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone. > > > Repository: mesos > > > Description > --- > > See summary. > > > Diffs > - > > src/slave/containerizer/mesos/containerizer.cpp > f69f65a5033ce0c1fa2fe9591d8c6bbada5e09fb > > > Diff: https://reviews.apache.org/r/61811/diff/4/ > > > Testing > --- > > make check on: > `Apple LLVM version 8.0.0 (clang-800.0.42.1)` on Mac OS 10.11.6 > `c++ (GCC) 6.2.1 20160916 (Red Hat 6.2.1-2)` on Fedora 24 > > > Thanks, > > Alexander Rukletsov > >
Re: Review Request 61811: Flattened continuation chains in containerizer for readability.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61811/ --- (Updated Jan. 18, 2018, 1:11 p.m.) Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone. Repository: mesos Description --- See summary. Diffs (updated) - src/slave/containerizer/mesos/containerizer.cpp f69f65a5033ce0c1fa2fe9591d8c6bbada5e09fb Diff: https://reviews.apache.org/r/61811/diff/4/ Changes: https://reviews.apache.org/r/61811/diff/3-4/ Testing --- make check on: `Apple LLVM version 8.0.0 (clang-800.0.42.1)` on Mac OS 10.11.6 `c++ (GCC) 6.2.1 20160916 (Red Hat 6.2.1-2)` on Fedora 24 Thanks, Alexander Rukletsov
Re: Review Request 61811: Flattened continuation chains in containerizer for readability.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61811/ --- (Updated Jan. 18, 2018, 1:10 p.m.) Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone. Changes --- Rebased. Repository: mesos Description --- See summary. Diffs (updated) - src/slave/containerizer/mesos/containerizer.cpp f69f65a5033ce0c1fa2fe9591d8c6bbada5e09fb Diff: https://reviews.apache.org/r/61811/diff/3/ Changes: https://reviews.apache.org/r/61811/diff/2-3/ Testing --- make check on: `Apple LLVM version 8.0.0 (clang-800.0.42.1)` on Mac OS 10.11.6 `c++ (GCC) 6.2.1 20160916 (Red Hat 6.2.1-2)` on Fedora 24 Thanks, Alexander Rukletsov
Re: Review Request 61811: Flattened continuation chains in containerizer for readability.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61811/ --- (Updated Aug. 22, 2017, 5:17 p.m.) Review request for mesos, Gilbert Song and Jie Yu. Repository: mesos Description --- See summary. Diffs (updated) - src/slave/containerizer/mesos/containerizer.cpp 5772421c3078d36225b946a5286b8c1bf2f007e8 Diff: https://reviews.apache.org/r/61811/diff/2/ Changes: https://reviews.apache.org/r/61811/diff/1-2/ Testing --- make check on: `Apple LLVM version 8.0.0 (clang-800.0.42.1)` on Mac OS 10.11.6 `c++ (GCC) 6.2.1 20160916 (Red Hat 6.2.1-2)` on Fedora 24 Thanks, Alexander Rukletsov
Re: Review Request 61811: Flattened continuation chains in containerizer for readability.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61811/#review183468 --- Patch looks great! Reviews applied: [61811] Passed command: support\windows-build.bat - Mesos Reviewbot Windows On Aug. 22, 2017, 2:42 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61811/ > --- > > (Updated Aug. 22, 2017, 2:42 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Repository: mesos > > > Description > --- > > See summary. > > > Diffs > - > > src/slave/containerizer/mesos/containerizer.cpp > 5772421c3078d36225b946a5286b8c1bf2f007e8 > > > Diff: https://reviews.apache.org/r/61811/diff/1/ > > > Testing > --- > > make check on: > `Apple LLVM version 8.0.0 (clang-800.0.42.1)` on Mac OS 10.11.6 > `c++ (GCC) 6.2.1 20160916 (Red Hat 6.2.1-2)` on Fedora 24 > > > Thanks, > > Alexander Rukletsov > >
