Re: Review Request 62507: Added documentation about 'MARK_AGENT_GONE' call.

2017-09-25 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62507/#review186186
---


Ship it!




Ship It!

- Vinod Kone


On Sept. 22, 2017, 6:15 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62507/
> ---
> 
> (Updated Sept. 22, 2017, 6:15 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-8007
> https://issues.apache.org/jira/browse/MESOS-8007
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Review: https://reviews.apache.org/r/62529
> 
> 
> Diffs
> -
> 
>   docs/operator-http-api.md f6cfcf1b8bbdc79fac2f361fb770546baf01d992 
> 
> 
> Diff: https://reviews.apache.org/r/62507/diff/2/
> 
> 
> Testing
> ---
> 
> Verified that the doc renders fine.
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>



Re: Review Request 62507: Added documentation about 'MARK_AGENT_GONE' call.

2017-09-24 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62507/#review186080
---



Patch looks great!

Reviews applied: [62475, 62476, 62477, 62478, 62479, 62480, 62481, 62507]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 22, 2017, 6:15 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62507/
> ---
> 
> (Updated Sept. 22, 2017, 6:15 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-8007
> https://issues.apache.org/jira/browse/MESOS-8007
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Review: https://reviews.apache.org/r/62529
> 
> 
> Diffs
> -
> 
>   docs/operator-http-api.md f6cfcf1b8bbdc79fac2f361fb770546baf01d992 
> 
> 
> Diff: https://reviews.apache.org/r/62507/diff/2/
> 
> 
> Testing
> ---
> 
> Verified that the doc renders fine.
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>



Re: Review Request 62507: Added documentation about 'MARK_AGENT_GONE' call.

2017-09-24 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62507/#review186078
---



FAIL: Some Mesos tests failed.

Reviews applied: `['62475', '62476', '62477', '62478', '62479', '62480', 
'62481', '62507']`

Failed command: `C:\mesos\src\mesos-tests.exe --verbose 
--gtest_filter="-ContentType/MasterAPITest.EventAuthorizationFiltering/1"`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62507

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62507/logs/mesos-tests-stdout.log):

```
[ RUN  ] ContentType/MasterAPITest.CreateAndDestroyVolumes/0
[   OK ] ContentType/MasterAPITest.CreateAndDestroyVolumes/0 (941 ms)
[ RUN  ] ContentType/MasterAPITest.CreateAndDestroyVolumes/1
[   OK ] ContentType/MasterAPITest.CreateAndDestroyVolumes/1 (970 ms)
[ RUN  ] ContentType/MasterAPITest.GetWeights/0
[   OK ] ContentType/MasterAPITest.GetWeights/0 (224 ms)
[ RUN  ] ContentType/MasterAPITest.GetWeights/1
[   OK ] ContentType/MasterAPITest.GetWeights/1 (225 ms)
[ RUN  ] ContentType/MasterAPITest.UpdateWeights/0
[   OK ] ContentType/MasterAPITest.UpdateWeights/0 (322 ms)
[ RUN  ] ContentType/MasterAPITest.UpdateWeights/1
[   OK ] ContentType/MasterAPITest.UpdateWeights/1 (306 ms)
[ RUN  ] ContentType/MasterAPITest.ReadFile/0
[   OK ] ContentType/MasterAPITest.ReadFile/0 (311 ms)
[ RUN  ] ContentType/MasterAPITest.ReadFile/1
[   OK ] ContentType/MasterAPITest.ReadFile/1 (352 ms)
[ RUN  ] ContentType/MasterAPITest.ReadFileInvalidPath/0
[   OK ] ContentType/MasterAPITest.ReadFileInvalidPath/0 (218 ms)
[ RUN  ] ContentType/MasterAPITest.ReadFileInvalidPath/1
[   OK ] ContentType/MasterAPITest.ReadFileInvalidPath/1 (190 ms)
[ RUN  ] ContentType/MasterAPITest.Teardown/0
[   OK ] ContentType/MasterAPITest.Teardown/0 (832 ms)
[ RUN  ] ContentType/MasterAPITest.Teardown/1
[   OK ] ContentType/MasterAPITest.Teardown/1 (995 ms)
[ RUN  ] ContentType/MasterAPITest.MarkRegisteredAgentGone/0

C:\mesos\mesos\src\tests\mock_registrar.cpp(54): ERROR: this mock object (used 
in test ContentType/MasterAPITest.MarkRegisteredAgentGone/0) should be deleted 
but never is. Its address is @0191B7C76000.
C:\mesos\mesos\3rdparty\libprocess\include\process/gmock.hpp(235): ERROR: this 
mock object (used in test ContentType/MasterAPITest.MarkRegisteredAgentGone/0) 
should be deleted but never is. Its address is @0191B935AD48.
ERROR: 2 leaked mock objects found at program exit.
```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62507/logs/mesos-tests-stderr.log):

```
  scalar {
value: 1024
  }
}
resources {
  name: "disk"
  type: SCALAR
  scalar {
value: 1024
  }
}
resources {
  name: "ports"
  type: RANGES
  ranges {
range {
  begin: 31000
  end: 32000
}
  }
}
checkpoint: true
port: 62122


To remedy this do as follows:
Step 1: rm -f C:\Users\mesos\AppData\Local\Temp\2\BLw5yB\meta\slaves\latest
This ensures agent doesn't recover old live executors.
Step 2: Restart the agent.
```

- Mesos Reviewbot Windows


On Sept. 22, 2017, 6:15 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62507/
> ---
> 
> (Updated Sept. 22, 2017, 6:15 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-8007
> https://issues.apache.org/jira/browse/MESOS-8007
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Review: https://reviews.apache.org/r/62529
> 
> 
> Diffs
> -
> 
>   docs/operator-http-api.md f6cfcf1b8bbdc79fac2f361fb770546baf01d992 
> 
> 
> Diff: https://reviews.apache.org/r/62507/diff/2/
> 
> 
> Testing
> ---
> 
> Verified that the doc renders fine.
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>



Re: Review Request 62507: Added documentation about 'MARK_AGENT_GONE' call.

2017-09-22 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62507/#review186039
---



Patch looks great!

Reviews applied: [62475, 62476, 62477, 62478, 62479, 62480, 62481, 62507]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 22, 2017, 6:15 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62507/
> ---
> 
> (Updated Sept. 22, 2017, 6:15 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-8007
> https://issues.apache.org/jira/browse/MESOS-8007
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/operator-http-api.md f6cfcf1b8bbdc79fac2f361fb770546baf01d992 
> 
> 
> Diff: https://reviews.apache.org/r/62507/diff/1/
> 
> 
> Testing
> ---
> 
> Verified that the doc renders fine.
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>



Re: Review Request 62507: Added documentation about 'MARK_AGENT_GONE' call.

2017-09-22 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62507/#review186013
---



FAIL: Some Mesos tests failed.

Reviews applied: `['62475', '62476', '62477', '62478', '62479', '62480', 
'62481', '62507']`

Failed command: `C:\mesos\src\mesos-tests.exe --verbose 
--gtest_filter="-ContentType/MasterAPITest.EventAuthorizationFiltering/1"`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62507

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62507/logs/mesos-tests-stdout.log):

```
[ RUN  ] ContentType/MasterAPITest.CreateAndDestroyVolumes/0
[   OK ] ContentType/MasterAPITest.CreateAndDestroyVolumes/0 (908 ms)
[ RUN  ] ContentType/MasterAPITest.CreateAndDestroyVolumes/1
[   OK ] ContentType/MasterAPITest.CreateAndDestroyVolumes/1 (957 ms)
[ RUN  ] ContentType/MasterAPITest.GetWeights/0
[   OK ] ContentType/MasterAPITest.GetWeights/0 (286 ms)
[ RUN  ] ContentType/MasterAPITest.GetWeights/1
[   OK ] ContentType/MasterAPITest.GetWeights/1 (217 ms)
[ RUN  ] ContentType/MasterAPITest.UpdateWeights/0
[   OK ] ContentType/MasterAPITest.UpdateWeights/0 (312 ms)
[ RUN  ] ContentType/MasterAPITest.UpdateWeights/1
[   OK ] ContentType/MasterAPITest.UpdateWeights/1 (323 ms)
[ RUN  ] ContentType/MasterAPITest.ReadFile/0
[   OK ] ContentType/MasterAPITest.ReadFile/0 (332 ms)
[ RUN  ] ContentType/MasterAPITest.ReadFile/1
[   OK ] ContentType/MasterAPITest.ReadFile/1 (347 ms)
[ RUN  ] ContentType/MasterAPITest.ReadFileInvalidPath/0
[   OK ] ContentType/MasterAPITest.ReadFileInvalidPath/0 (197 ms)
[ RUN  ] ContentType/MasterAPITest.ReadFileInvalidPath/1
[   OK ] ContentType/MasterAPITest.ReadFileInvalidPath/1 (202 ms)
[ RUN  ] ContentType/MasterAPITest.Teardown/0
[   OK ] ContentType/MasterAPITest.Teardown/0 (745 ms)
[ RUN  ] ContentType/MasterAPITest.Teardown/1
[   OK ] ContentType/MasterAPITest.Teardown/1 (1016 ms)
[ RUN  ] ContentType/MasterAPITest.MarkRegisteredAgentGone/0

C:\mesos\mesos\src\tests\mock_registrar.cpp(54): ERROR: this mock object (used 
in test ContentType/MasterAPITest.MarkRegisteredAgentGone/0) should be deleted 
but never is. Its address is @02675A6EF7F0.
C:\mesos\mesos\3rdparty\libprocess\include\process/gmock.hpp(235): ERROR: this 
mock object (used in test ContentType/MasterAPITest.MarkRegisteredAgentGone/0) 
should be deleted but never is. Its address is @02675B0C34B8.
ERROR: 2 leaked mock objects found at program exit.
```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62507/logs/mesos-tests-stderr.log):

```
  scalar {
value: 1024
  }
}
resources {
  name: "disk"
  type: SCALAR
  scalar {
value: 1024
  }
}
resources {
  name: "ports"
  type: RANGES
  ranges {
range {
  begin: 31000
  end: 32000
}
  }
}
checkpoint: true
port: 59189


To remedy this do as follows:
Step 1: rm -f C:\Users\mesos\AppData\Local\Temp\2\H8QPqW\meta\slaves\latest
This ensures agent doesn't recover old live executors.
Step 2: Restart the agent.
```

- Mesos Reviewbot Windows


On Sept. 22, 2017, 6:15 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62507/
> ---
> 
> (Updated Sept. 22, 2017, 6:15 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-8007
> https://issues.apache.org/jira/browse/MESOS-8007
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/operator-http-api.md f6cfcf1b8bbdc79fac2f361fb770546baf01d992 
> 
> 
> Diff: https://reviews.apache.org/r/62507/diff/1/
> 
> 
> Testing
> ---
> 
> Verified that the doc renders fine.
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>