Re: Review Request 62509: Added `intptr_t` constructor for `WindowsFD`.

2017-10-11 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62509/#review187704 --- Ship it! Ship It! - Joseph Wu On Oct. 2, 2017, 4:45 p.m.,

Re: Review Request 62509: Added `intptr_t` constructor for `WindowsFD`.

2017-10-02 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62509/ --- (Updated Oct. 2, 2017, 4:45 p.m.) Review request for mesos, John Kordich,

Re: Review Request 62509: Added `intptr_t` constructor for `WindowsFD`.

2017-10-02 Thread Andrew Schwartzmeyer
> On Oct. 2, 2017, 1:23 p.m., Joseph Wu wrote: > > 3rdparty/CMakeLists.txt > > Lines 516-518 (patched) > > > > > > There should be two separate conditionals here: > > > > 1) `if (ENABLE_SSL)` which appends

Re: Review Request 62509: Added `intptr_t` constructor for `WindowsFD`.

2017-10-02 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62509/#review186877 --- Socket modification LGTM. 3rdparty/CMakeLists.txt Lines 516-518

Re: Review Request 62509: Added `intptr_t` constructor for `WindowsFD`.

2017-09-22 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62509/#review186019 --- PASS: Mesos patch 62509 was successfully built and tested.