Re: Review Request 62698: Fixed the clang complation problem for the executor tests.

2017-09-29 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62698/#review186762
---



FAIL: Some Mesos tests failed.

Reviews applied: `['62698']`

Failed command: `C:\mesos\src\mesos-tests.exe --verbose 
--gtest_filter="-ContentType/MasterAPITest.EventAuthorizationFiltering/1"`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62698

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62698/logs/mesos-tests-stdout.log):

```
[ RUN  ] ContentType/SchedulerTest.SchedulerReconnect/0
[   OK ] ContentType/SchedulerTest.SchedulerReconnect/0 (282 ms)
[ RUN  ] ContentType/SchedulerTest.SchedulerReconnect/1
[   OK ] ContentType/SchedulerTest.SchedulerReconnect/1 (249 ms)
[--] 30 tests from ContentType/SchedulerTest (26066 ms total)

[--] 2 tests from ContentTypeAndSSLConfig/SchedulerSSLTest
[ RUN  ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0
[   OK ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0 (923 
ms)
[ RUN  ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/1
[   OK ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/1 
(1093 ms)
[--] 2 tests from ContentTypeAndSSLConfig/SchedulerSSLTest (2126 ms 
total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (138 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (143 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (341 ms 
total)

[--] Global test environment tear-down
[==] 634 tests from 67 test cases ran. (373504 ms total)
[  PASSED  ] 633 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] MesosContainerizer/DefaultExecutorTest.TaskWithFileURI/0, where 
GetParam() = "mesos"

 1 FAILED TEST
  YOU HAVE 182 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62698/logs/mesos-tests-stderr.log):

```
I0930 00:14:39.732174 36956 master.cpp:8438] Removing framework 
dd611862-78a5-4022-a45d-29889f26a903- (default)
I0930 00:14:39.732174 36956 master.cpp:3317] Deactivating framework 
dd611862-78a5-4022-a45d-29889f26a903- (default)
I0930 00:14:39.741178 37440 hierarchical.cpp:412] Deactivated framework 
dd611862-78a5-4022-a45d-29889f26a903-
I0930 00:14:39.742172 33496 slave.cpp:3239] Shutting down framework 
dd611862-78a5-4022-a45d-29889f26a903-
I0930 00:14:39.742172 36956 master.cpp:9136] Updating the state of task 
8dad71be-ce9c-42fe-9c61-a675180666d7 of framework 
dd611862-78a5-4022-a45d-29889f26a903- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0930 00:14:39.742172 33496 slave.cpp:5746] Shutting down executor 'default' of 
framework dd611862-78a5-4022-a45d-29889f26a903- (via HTTP)
I0930 00:14:39.746171 36956 master.cpp:9230] Removing task 
8dad71be-ce9c-42fe-9c61-a675180666d7 with resources 
[{"allocation_info":{"role":"*"},"name":"cpus","scalar":{"value":2.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"mem","scalar":{"value":1024.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"disk","scalar":{"value":1024.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"ports","ranges":{"range":[{"begin":31000,"end":32000}]},"type":"RANGES"}]
 of framework dd611862-78a5-4022-a45d-29889f26a903- on agent 
dd611862-78a5-4022-a45d-29889f26a903-S0 at slave(251)@10.3.1.5:53530 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0930 00:14:39.765171 36956 master.cpp:9259] Removing executor 'default' with 
resources [] of framework dd611862-78a5-4022-a45d-29889f26a903- on agent 
dd611862-78a5-4022-a45d-29889f26a903-S0 at slave(251)@10.3.1.5:53530 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0930 00:14:39.769170 36088 hierarchical.cpp:355] Removed framework 
dd611862-78a5-4022-a45d-29889f26a903-
E0930 00:14:39.769170 37092 scheduler.cpp:649] End-Of-File received from 
master. The master closed the event stream
I0930 00:14:39.770170 37440 scheduler.cpp:444] Re-detecting master
I0930 00:14:39.773172 37440 scheduler.cpp:470] New master detected at 
master@10.3.1.5:53530
I0930 00:14:39.794169 36820 slave.cpp:5411] Executor 'default' of framework 
dd611862-78a5-4022-a45d-29889f26a903- exited with status 0
I0930 00:14:39.795168 36820 slave.cpp:5515] Cleaning up executor 'default' of 
framework dd611862-78a5-4022-a45d-29889f26a903- (via HTTP)
W0930 00:14:39.795168 37092 master.cpp:7089] Ignoring unknown exited executor 
'default' of

Re: Review Request 62698: Fixed the clang complation problem for the executor tests.

2017-09-29 Thread Chun-Hung Hsiao 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62698/
---

(Updated Sept. 29, 2017, 10:18 p.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Summary (updated)
-

Fixed the clang complation problem for the executor tests.


Repository: mesos


Description (updated)
---

It appears that g++ throws away the cv-qualifiers when doing the
lvalue-to-rvalue conversion for lambdas returning strings but clang does
not, so we make `f3` in `THREADSAFE_Executor_Execute` return a
non-constant string.


Diffs (updated)
-

  3rdparty/libprocess/src/tests/process_tests.cpp 
e49431873393e835bf0e0a9c240e5d54f06e0ab7 


Diff: https://reviews.apache.org/r/62698/diff/2/

Changes: https://reviews.apache.org/r/62698/diff/1-2/


Testing
---

make check with gcc 5.4.0 and clang 3.4.2.


Thanks,

Chun-Hung Hsiao