Re: Review Request 62886: Increased level of some verbose logs from allocator.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62886/#review188534
---


Ship it!




Ship It!

- Alexander Rukletsov


On Oct. 11, 2017, 1:29 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62886/
> ---
> 
> (Updated Oct. 11, 2017, 1:29 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-8072
> https://issues.apache.org/jira/browse/MESOS-8072
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Increases vlog level of some recurring events to improve readability.
> Specifically, we now log the following events on vlog level two
> instead of level one:
>   "Skipped allocation because the allocator is paused",
>   "No allocations performed",
>   "No inverse offers to send out!".
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 445307411bc1df4b1468df0d8fb02181bc4287ed 
> 
> 
> Diff: https://reviews.apache.org/r/62886/diff/3/
> 
> 
> Testing
> ---
> 
> Run `GLOG_v=1 ./mesos-local.sh --log_dir=/tmp/test-mesos/log/ --num_slaves=3 
> --port=5037 --work_dir=/tmp/test-mesos/work/` and `GLOG_v=2 ./mesos-local.sh 
> --log_dir=/tmp/test-mesos/log/ --num_slaves=3 --port=5037 
> --work_dir=/tmp/test-mesos/work/` and checked that the new output was as 
> expected.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 62886: Increased level of some verbose logs from allocator.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62886/#review188301
---



PASS: Mesos patch 62886 was successfully built and tested.

Reviews applied: `['62886']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62886

- Mesos Reviewbot Windows


On Oct. 11, 2017, 1:29 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62886/
> ---
> 
> (Updated Oct. 11, 2017, 1:29 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-8072
> https://issues.apache.org/jira/browse/MESOS-8072
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Increases vlog level of some recurring events to improve readability.
> Specifically, we now log the following events on vlog level two
> instead of level one:
>   "Skipped allocation because the allocator is paused",
>   "No allocations performed",
>   "No inverse offers to send out!".
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 445307411bc1df4b1468df0d8fb02181bc4287ed 
> 
> 
> Diff: https://reviews.apache.org/r/62886/diff/3/
> 
> 
> Testing
> ---
> 
> Run `GLOG_v=1 ./mesos-local.sh --log_dir=/tmp/test-mesos/log/ --num_slaves=3 
> --port=5037 --work_dir=/tmp/test-mesos/work/` and `GLOG_v=2 ./mesos-local.sh 
> --log_dir=/tmp/test-mesos/log/ --num_slaves=3 --port=5037 
> --work_dir=/tmp/test-mesos/work/` and checked that the new output was as 
> expected.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 62886: Increased level of some verbose logs from allocator.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62886/#review188296
---


Ship it!




Ship It!

- Till Toenshoff


On Oct. 11, 2017, 1:29 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62886/
> ---
> 
> (Updated Oct. 11, 2017, 1:29 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-8072
> https://issues.apache.org/jira/browse/MESOS-8072
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Increases vlog level of some recurring events to improve readability.
> Specifically, we now log the following events on vlog level two
> instead of level one:
>   "Skipped allocation because the allocator is paused",
>   "No allocations performed",
>   "No inverse offers to send out!".
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 445307411bc1df4b1468df0d8fb02181bc4287ed 
> 
> 
> Diff: https://reviews.apache.org/r/62886/diff/3/
> 
> 
> Testing
> ---
> 
> Run `GLOG_v=1 ./mesos-local.sh --log_dir=/tmp/test-mesos/log/ --num_slaves=3 
> --port=5037 --work_dir=/tmp/test-mesos/work/` and `GLOG_v=2 ./mesos-local.sh 
> --log_dir=/tmp/test-mesos/log/ --num_slaves=3 --port=5037 
> --work_dir=/tmp/test-mesos/work/` and checked that the new output was as 
> expected.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 62886: Increased level of some verbose logs from allocator.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62886/#review188294
---



Patch looks great!

Reviews applied: [62886]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Oct. 11, 2017, 1:29 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62886/
> ---
> 
> (Updated Oct. 11, 2017, 1:29 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-8072
> https://issues.apache.org/jira/browse/MESOS-8072
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Increases vlog level of some recurring events to improve readability.
> Specifically, we now log the following events on vlog level two
> instead of level one:
>   "Skipped allocation because the allocator is paused",
>   "No allocations performed",
>   "No inverse offers to send out!".
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 445307411bc1df4b1468df0d8fb02181bc4287ed 
> 
> 
> Diff: https://reviews.apache.org/r/62886/diff/3/
> 
> 
> Testing
> ---
> 
> Run `GLOG_v=1 ./mesos-local.sh --log_dir=/tmp/test-mesos/log/ --num_slaves=3 
> --port=5037 --work_dir=/tmp/test-mesos/work/` and `GLOG_v=2 ./mesos-local.sh 
> --log_dir=/tmp/test-mesos/log/ --num_slaves=3 --port=5037 
> --work_dir=/tmp/test-mesos/work/` and checked that the new output was as 
> expected.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 62886: Increased level of some verbose logs from allocator.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62886/#review188139
---




src/master/allocator/mesos/hierarchical.cpp
Lines 1486-1487 (original), 1486-1487 (patched)


Let's keep this one at level 1 for now. I think if we remove this line, we 
will have no insight on level 1 when an allocation—even an event-based!—happens.


- Alexander Rukletsov


On Oct. 11, 2017, 1:29 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62886/
> ---
> 
> (Updated Oct. 11, 2017, 1:29 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-8072
> https://issues.apache.org/jira/browse/MESOS-8072
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Increases vlog level of some recurring events to improve readability.
> Specifically, we now log the following events on vlog level two
> instead of level one:
>   "Skipped allocation because the allocator is paused",
>   "Performed allocation for agents",
>   "No allocations performed",
>   "No inverse offers to send out!".
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 22131309a38fc6cbb0a68455f94ef6075076d4e7 
> 
> 
> Diff: https://reviews.apache.org/r/62886/diff/2/
> 
> 
> Testing
> ---
> 
> Run `GLOG_v=1 ./mesos-local.sh --log_dir=/tmp/test-mesos/log/ --num_slaves=3 
> --port=5037 --work_dir=/tmp/test-mesos/work/` and `GLOG_v=2 ./mesos-local.sh 
> --log_dir=/tmp/test-mesos/log/ --num_slaves=3 --port=5037 
> --work_dir=/tmp/test-mesos/work/` and checked that the new output was as 
> expected.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 62886: Increased level of some verbose logs from allocator.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62886/#review187767
---




src/master/allocator/mesos/hierarchical.cpp
Line 1445 (original), 1445 (patched)


Can this be at level 2 as well? See l.176ff above.


- Benjamin Bannier


On Oct. 11, 2017, 3:29 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62886/
> ---
> 
> (Updated Oct. 11, 2017, 3:29 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-8072
> https://issues.apache.org/jira/browse/MESOS-8072
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Increases vlog level of some recurring events to improve readability.
> Specifically, we now log the following events on vlog level two
> instead of level one:
>   "Skipped allocation because the allocator is paused",
>   "Performed allocation for agents",
>   "No allocations performed",
>   "No inverse offers to send out!".
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 22131309a38fc6cbb0a68455f94ef6075076d4e7 
> 
> 
> Diff: https://reviews.apache.org/r/62886/diff/2/
> 
> 
> Testing
> ---
> 
> Run `GLOG_v=1 ./mesos-local.sh --log_dir=/tmp/test-mesos/log/ --num_slaves=3 
> --port=5037 --work_dir=/tmp/test-mesos/work/` and `GLOG_v=2 ./mesos-local.sh 
> --log_dir=/tmp/test-mesos/log/ --num_slaves=3 --port=5037 
> --work_dir=/tmp/test-mesos/work/` and checked that the new output was as 
> expected.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 62886: Increased level of some verbose logs from allocator.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62886/#review187717
---



PASS: Mesos patch 62886 was successfully built and tested.

Reviews applied: `['62886']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62886

- Mesos Reviewbot Windows


On Oct. 11, 2017, 1:29 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62886/
> ---
> 
> (Updated Oct. 11, 2017, 1:29 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-8072
> https://issues.apache.org/jira/browse/MESOS-8072
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Increases vlog level of some recurring events to improve readability.
> Specifically, we now log the following events on vlog level two
> instead of level one:
>   "Skipped allocation because the allocator is paused",
>   "Performed allocation for agents",
>   "No allocations performed",
>   "No inverse offers to send out!".
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 22131309a38fc6cbb0a68455f94ef6075076d4e7 
> 
> 
> Diff: https://reviews.apache.org/r/62886/diff/2/
> 
> 
> Testing
> ---
> 
> Run `GLOG_v=1 ./mesos-local.sh --log_dir=/tmp/test-mesos/log/ --num_slaves=3 
> --port=5037 --work_dir=/tmp/test-mesos/work/` and `GLOG_v=2 ./mesos-local.sh 
> --log_dir=/tmp/test-mesos/log/ --num_slaves=3 --port=5037 
> --work_dir=/tmp/test-mesos/work/` and checked that the new output was as 
> expected.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>