Re: Review Request 62980: Added link anchors to all website headings.

2017-10-18 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62980/#review188573
---


Ship it!




I just verified this using the web development Docker container; looks great! 
Thanks James!!!

I think black is OK for the links; I'll merge as-is and we can always update 
later.

- Greg Mann


On Oct. 13, 2017, 4:58 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62980/
> ---
> 
> (Updated Oct. 13, 2017, 4:58 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This follows the example of the Middleman documentation and
> uses AnchorJS to inject link anchors to all headings at page
> load time. The styling is basic black to match the styling of
> the header titles.
> 
> 
> Diffs
> -
> 
>   site/source/assets/css/main.css 83596ddbd833e36b60bdbbd487ebd464b3874119 
>   site/source/layouts/basic.erb 3bf1f55d7d8feafd3caaa7902755404f7e45bae6 
> 
> 
> Diff: https://reviews.apache.org/r/62980/diff/3/
> 
> 
> Testing
> ---
> 
> Verified manually using the Docker image to run Middleman in dev mode.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 62980: Added link anchors to all website headings.

2017-10-18 Thread James Peach 


> On Oct. 18, 2017, 6:06 p.m., Andrew Schwartzmeyer wrote:
> > I tested this out locally on my Mac, rebased and with my getting started 
> > doc changes just to test it out. It's all working as expected. Though 
> > perhaps instead of black, might a medium gray look better?

I said `black` so that it would be the same as the title text color. I'm happy 
for it to be any specific color that works.


- James


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62980/#review188538
---


On Oct. 13, 2017, 4:58 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62980/
> ---
> 
> (Updated Oct. 13, 2017, 4:58 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This follows the example of the Middleman documentation and
> uses AnchorJS to inject link anchors to all headings at page
> load time. The styling is basic black to match the styling of
> the header titles.
> 
> 
> Diffs
> -
> 
>   site/source/assets/css/main.css 83596ddbd833e36b60bdbbd487ebd464b3874119 
>   site/source/layouts/basic.erb 3bf1f55d7d8feafd3caaa7902755404f7e45bae6 
> 
> 
> Diff: https://reviews.apache.org/r/62980/diff/2/
> 
> 
> Testing
> ---
> 
> Verified manually using the Docker image to run Middleman in dev mode.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 62980: Added link anchors to all website headings.

2017-10-18 Thread Andrew Schwartzmeyer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62980/#review188538
---


Fix it, then Ship it!




I tested this out locally on my Mac, rebased and with my getting started doc 
changes just to test it out. It's all working as expected. Though perhaps 
instead of black, might a medium gray look better?


site/source/layouts/basic.erb
Lines 125 (patched)


s/do we/we do/ right?


- Andrew Schwartzmeyer


On Oct. 13, 2017, 9:58 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62980/
> ---
> 
> (Updated Oct. 13, 2017, 9:58 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This follows the example of the Middleman documentation and
> uses AnchorJS to inject link anchors to all headings at page
> load time. The styling is basic black to match the styling of
> the header titles.
> 
> 
> Diffs
> -
> 
>   site/source/assets/css/main.css 83596ddbd833e36b60bdbbd487ebd464b3874119 
>   site/source/layouts/basic.erb 3bf1f55d7d8feafd3caaa7902755404f7e45bae6 
> 
> 
> Diff: https://reviews.apache.org/r/62980/diff/2/
> 
> 
> Testing
> ---
> 
> Verified manually using the Docker image to run Middleman in dev mode.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 62980: Added link anchors to all website headings.

2017-10-13 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62980/#review188004
---



PASS: Mesos patch 62980 was successfully built and tested.

Reviews applied: `['62980']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62980

- Mesos Reviewbot Windows


On Oct. 13, 2017, 4:58 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62980/
> ---
> 
> (Updated Oct. 13, 2017, 4:58 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This follows the example of the Middleman documentation and
> uses AnchorJS to inject link anchors to all headings at page
> load time. The styling is basic black to match the styling of
> the header titles.
> 
> 
> Diffs
> -
> 
>   site/source/assets/css/main.css 83596ddbd833e36b60bdbbd487ebd464b3874119 
>   site/source/layouts/basic.erb 3bf1f55d7d8feafd3caaa7902755404f7e45bae6 
> 
> 
> Diff: https://reviews.apache.org/r/62980/diff/2/
> 
> 
> Testing
> ---
> 
> Verified manually using the Docker image to run Middleman in dev mode.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 62980: Added link anchors to all website headings.

2017-10-13 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62980/#review188000
---



Patch looks great!

Reviews applied: [62980]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Oct. 13, 2017, 4:58 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62980/
> ---
> 
> (Updated Oct. 13, 2017, 4:58 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This follows the example of the Middleman documentation and
> uses AnchorJS to inject link anchors to all headings at page
> load time. The styling is basic black to match the styling of
> the header titles.
> 
> 
> Diffs
> -
> 
>   site/source/assets/css/main.css 83596ddbd833e36b60bdbbd487ebd464b3874119 
>   site/source/layouts/basic.erb 3bf1f55d7d8feafd3caaa7902755404f7e45bae6 
> 
> 
> Diff: https://reviews.apache.org/r/62980/diff/2/
> 
> 
> Testing
> ---
> 
> Verified manually using the Docker image to run Middleman in dev mode.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 62980: Added link anchors to all website headings.

2017-10-13 Thread James Peach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62980/
---

(Updated Oct. 13, 2017, 4:58 p.m.)


Review request for mesos, Greg Mann and Vinod Kone.


Changes
---

Honestly, I think "Muddleman" was better ...


Repository: mesos


Description (updated)
---

This follows the example of the Middleman documentation and
uses AnchorJS to inject link anchors to all headings at page
load time. The styling is basic black to match the styling of
the header titles.


Diffs (updated)
-

  site/source/assets/css/main.css 83596ddbd833e36b60bdbbd487ebd464b3874119 
  site/source/layouts/basic.erb 3bf1f55d7d8feafd3caaa7902755404f7e45bae6 


Diff: https://reviews.apache.org/r/62980/diff/2/

Changes: https://reviews.apache.org/r/62980/diff/1-2/


Testing
---

Verified manually using the Docker image to run Middleman in dev mode.


Thanks,

James Peach