Re: Review Request 63101: Upgrades jQuery used by Mesos WebUI to version 3.2.1.

2017-10-18 Thread Armand Grillet

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63101/#review188488
---


Ship it!




Ship It!

- Armand Grillet


On Oct. 18, 2017, 12:12 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63101/
> ---
> 
> (Updated Oct. 18, 2017, 12:12 p.m.)
> 
> 
> Review request for mesos, Armand Grillet, Gaston Kleiman, and Tomasz 
> Janiszewski.
> 
> 
> Bugs: MESOS-8057
> https://issues.apache.org/jira/browse/MESOS-8057
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The version of jQuery distributed with Mesos (1.7.1) was found to have
> security issues which have been addressed in latter versions.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/index.html 0b977f58fa1f348b582a0e0bcafcb7d170862cf4 
>   src/webui/master/static/js/jquery-1.7.1.js 
> 00c4e23a27b15f6158ea46a016beb0ae95c6596d 
>   src/webui/master/static/js/jquery-1.7.1.min.js 
> 198b3ff07d801dffa2c42fcf3b67eb3295eef85f 
>   src/webui/master/static/js/jquery-3.2.1.js PRE-CREATION 
>   src/webui/master/static/js/jquery-3.2.1.min.js PRE-CREATION 
>   src/webui/master/static/pailer.html 
> c8ada4b19b88c701b23926121dd6061573c615a4 
> 
> 
> Diff: https://reviews.apache.org/r/63101/diff/1/
> 
> 
> Testing
> ---
> 
> manual testing, verified with jQuery Update. Launched a cluster with two 
> agents and two frameworks. Verified that the UI behaved as before.
> 
> Not that this is the result of two updates:
> From 1.7.1 to 1.12.4 using the first jquery-upgrade. Once it was verified a 
> second upgrade from 1.12.4 to 3.2.1 was done with the help of the second 
> jquery-upgrade.
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>



Re: Review Request 63101: Upgrades jQuery used by Mesos WebUI to version 3.2.1.

2017-10-18 Thread Alexander Rojas

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63101/
---

(Updated Oct. 18, 2017, 2:12 p.m.)


Review request for mesos, Armand Grillet, Gaston Kleiman, and Tomasz 
Janiszewski.


Bugs: MESOS-8057
https://issues.apache.org/jira/browse/MESOS-8057


Repository: mesos


Description
---

The version of jQuery distributed with Mesos (1.7.1) was found to have
security issues which have been addressed in latter versions.


Diffs
-

  src/webui/master/static/index.html 0b977f58fa1f348b582a0e0bcafcb7d170862cf4 
  src/webui/master/static/js/jquery-1.7.1.js 
00c4e23a27b15f6158ea46a016beb0ae95c6596d 
  src/webui/master/static/js/jquery-1.7.1.min.js 
198b3ff07d801dffa2c42fcf3b67eb3295eef85f 
  src/webui/master/static/js/jquery-3.2.1.js PRE-CREATION 
  src/webui/master/static/js/jquery-3.2.1.min.js PRE-CREATION 
  src/webui/master/static/pailer.html c8ada4b19b88c701b23926121dd6061573c615a4 


Diff: https://reviews.apache.org/r/63101/diff/1/


Testing (updated)
---

manual testing, verified with jQuery Update. Launched a cluster with two agents 
and two frameworks. Verified that the UI behaved as before.

Not that this is the result of two updates:
>From 1.7.1 to 1.12.4 using the first jquery-upgrade. Once it was verified a 
>second upgrade from 1.12.4 to 3.2.1 was done with the help of the second 
>jquery-upgrade.


Thanks,

Alexander Rojas



Re: Review Request 63101: Upgrades jQuery used by Mesos WebUI to version 3.2.1.

2017-10-18 Thread Tomasz Janiszewski

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63101/#review188472
---


Ship it!




Ship It!

- Tomasz Janiszewski


On Oct. 18, 2017, 10:16 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63101/
> ---
> 
> (Updated Oct. 18, 2017, 10:16 a.m.)
> 
> 
> Review request for mesos, Armand Grillet, Gaston Kleiman, and Tomasz 
> Janiszewski.
> 
> 
> Bugs: MESOS-8057
> https://issues.apache.org/jira/browse/MESOS-8057
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The version of jQuery distributed with Mesos (1.7.1) was found to have
> security issues which have been addressed in latter versions.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/index.html 0b977f58fa1f348b582a0e0bcafcb7d170862cf4 
>   src/webui/master/static/js/jquery-1.7.1.js 
> 00c4e23a27b15f6158ea46a016beb0ae95c6596d 
>   src/webui/master/static/js/jquery-1.7.1.min.js 
> 198b3ff07d801dffa2c42fcf3b67eb3295eef85f 
>   src/webui/master/static/js/jquery-3.2.1.js PRE-CREATION 
>   src/webui/master/static/js/jquery-3.2.1.min.js PRE-CREATION 
>   src/webui/master/static/pailer.html 
> c8ada4b19b88c701b23926121dd6061573c615a4 
> 
> 
> Diff: https://reviews.apache.org/r/63101/diff/1/
> 
> 
> Testing
> ---
> 
> manual testing, verified with jQuery Update. Launched a cluster with two 
> agents and two frameworks. Verified that the UI behaved as before.
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>