Re: Review Request 63174: Added a benchmark for agent reregistration during master failover.

2017-11-03 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63174/ --- (Updated Nov. 3, 2017, 11:10 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 63174: Added a benchmark for agent reregistration during master failover.

2017-11-02 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63174/#review189978 --- Ship it! Are you able to also upload some flame graphs to

Re: Review Request 63174: Added a benchmark for agent reregistration during master failover.

2017-11-02 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63174/#review189892 --- Patch looks great! Reviews applied: [63174] Passed command:

Re: Review Request 63174: Added a benchmark for agent reregistration during master failover.

2017-11-01 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63174/#review189867 --- FAIL: Mesos tests failed to build. Reviews applied: `['63174']`

Re: Review Request 63174: Added a benchmark for agent reregistration during master failover.

2017-11-01 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63174/ --- (Updated Nov. 1, 2017, 3:06 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 63174: Added a benchmark for agent reregistration during master failover.

2017-11-01 Thread Jiang Yan Xu
> On Oct. 24, 2017, 2:55 p.m., Benjamin Mahler wrote: > > A couple of suggestions for speeding up the benchmark overhead: > > > > (1) Upgrade protobuf to 3.4.x, this comes with move support and rvalue > > setters for fields. Which will avoid some copies in the benchmark code and > > improve

Re: Review Request 63174: Added a benchmark for agent reregistration during master failover.

2017-10-24 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63174/#review189093 --- A couple of suggestions for speeding up the benchmark overhead:

Re: Review Request 63174: Added a benchmark for agent reregistration during master failover.

2017-10-24 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63174/#review189082 --- PASS: Mesos patch 63174 was successfully built and tested.

Re: Review Request 63174: Added a benchmark for agent reregistration during master failover.

2017-10-24 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63174/#review189079 --- Patch looks great! Reviews applied: [63174] Passed command:

Re: Review Request 63174: Added a benchmark for agent reregistration during master failover.

2017-10-24 Thread Jiang Yan Xu
> On Oct. 19, 2017, 6:38 p.m., Benjamin Mahler wrote: > > Thanks Yan! I will dig in soon. > > > > Just some quick questions: > > > > (1) I thought during the meeting you said it was taking a minute, but > > looking at all the benchmark timings they're all under a second? Is it only > > the

Re: Review Request 63174: Added a benchmark for agent reregistration during master failover.

2017-10-24 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63174/ --- (Updated Oct. 24, 2017, 11:05 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 63174: Added a benchmark for agent reregistration during master failover.

2017-10-20 Thread Jiang Yan Xu
> On Oct. 19, 2017, 6:38 p.m., Benjamin Mahler wrote: > > Thanks Yan! I will dig in soon. > > > > Just some quick questions: > > > > (1) I thought during the meeting you said it was taking a minute, but > > looking at all the benchmark timings they're all under a second? Is it only > > the

Re: Review Request 63174: Added a benchmark for agent reregistration during master failover.

2017-10-20 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63174/#review188819 --- PASS: Mesos patch 63174 was successfully built and tested.

Re: Review Request 63174: Added a benchmark for agent reregistration during master failover.

2017-10-19 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63174/#review188802 --- Patch looks great! Reviews applied: [63174] Passed command:

Re: Review Request 63174: Added a benchmark for agent reregistration during master failover.

2017-10-19 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63174/#review188799 --- Thanks Yan! I will dig in soon. Just some quick questions: (1)