Re: Review Request 63332: Logged the resources in DRF sorter CHECK.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63332/#review189328
---


Ship it!




Ship It!

- Jiang Yan Xu


On Oct. 26, 2017, 12:01 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63332/
> ---
> 
> (Updated Oct. 26, 2017, 12:01 p.m.)
> 
> 
> Review request for mesos, James Peach and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If calls to these checks fails, log related resources objects which
> causes the failure.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/sorter/drf/sorter.hpp 
> 77e52dec735d276389643f7f356cd763b2f785e9 
> 
> 
> Diff: https://reviews.apache.org/r/63332/diff/5/
> 
> 
> Testing
> ---
> 
> Compile it on Linux.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 63332: Logged the resources in DRF sorter CHECK.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63332/
---

(Updated Oct. 26, 2017, 7:01 p.m.)


Review request for mesos, James Peach and Jiang Yan Xu.


Changes
---

Fix compilation.


Repository: mesos


Description
---

If calls to these checks fails, log related resources objects which
causes the failure.


Diffs (updated)
-

  src/master/allocator/sorter/drf/sorter.hpp 
77e52dec735d276389643f7f356cd763b2f785e9 


Diff: https://reviews.apache.org/r/63332/diff/5/

Changes: https://reviews.apache.org/r/63332/diff/4-5/


Testing (updated)
---

Compile it on Linux.


Thanks,

Zhitao Li

Re: Review Request 63332: Logged the resources in DRF sorter CHECK.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63332/#review189327
---




src/master/allocator/sorter/drf/sorter.hpp
Lines 392 (patched)


Typo: s/toRemove/oldAllocation/

Could you make sure it compiles and fill out the "Testing Done" section?


- Jiang Yan Xu


On Oct. 26, 2017, 11:26 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63332/
> ---
> 
> (Updated Oct. 26, 2017, 11:26 a.m.)
> 
> 
> Review request for mesos, James Peach and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If calls to these checks fails, log related resources objects which
> causes the failure.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/sorter/drf/sorter.hpp 
> 77e52dec735d276389643f7f356cd763b2f785e9 
> 
> 
> Diff: https://reviews.apache.org/r/63332/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 63332: Logged the resources in DRF sorter CHECK.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63332/
---

(Updated Oct. 26, 2017, 6:26 p.m.)


Review request for mesos, James Peach and Jiang Yan Xu.


Changes
---

Remove quotes around agent id.


Repository: mesos


Description
---

If calls to these checks fails, log related resources objects which
causes the failure.


Diffs (updated)
-

  src/master/allocator/sorter/drf/sorter.hpp 
77e52dec735d276389643f7f356cd763b2f785e9 


Diff: https://reviews.apache.org/r/63332/diff/4/

Changes: https://reviews.apache.org/r/63332/diff/3-4/


Testing
---


Thanks,

Zhitao Li

Re: Review Request 63332: Logged the resources in DRF sorter CHECK.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63332/#review189324
---


Fix it, then Ship it!





src/master/allocator/sorter/drf/sorter.hpp
Lines 350 (patched)


Nit: For consistency, I don't think we quote agent IDs (there are no spaces 
in agent IDs).

Here and below?


- Jiang Yan Xu


On Oct. 26, 2017, 11:12 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63332/
> ---
> 
> (Updated Oct. 26, 2017, 11:12 a.m.)
> 
> 
> Review request for mesos, James Peach and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If calls to these checks fails, log related resources objects which
> causes the failure.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/sorter/drf/sorter.hpp 
> 77e52dec735d276389643f7f356cd763b2f785e9 
> 
> 
> Diff: https://reviews.apache.org/r/63332/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 63332: Logged the resources in DRF sorter CHECK.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63332/
---

(Updated Oct. 26, 2017, 6:12 p.m.)


Review request for mesos, James Peach and Jiang Yan Xu.


Repository: mesos


Description
---

If calls to these checks fails, log related resources objects which
causes the failure.


Diffs (updated)
-

  src/master/allocator/sorter/drf/sorter.hpp 
77e52dec735d276389643f7f356cd763b2f785e9 


Diff: https://reviews.apache.org/r/63332/diff/3/

Changes: https://reviews.apache.org/r/63332/diff/2-3/


Testing
---


Thanks,

Zhitao Li

Re: Review Request 63332: Logged the resources in DRF sorter CHECK.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63332/
---

(Updated Oct. 26, 2017, 6:10 p.m.)


Review request for mesos, James Peach and Jiang Yan Xu.


Changes
---

Also log agent id if it's indexed.


Repository: mesos


Description
---

If calls to these checks fails, log related resources objects which
causes the failure.


Diffs (updated)
-

  src/master/allocator/sorter/drf/sorter.hpp 
77e52dec735d276389643f7f356cd763b2f785e9 


Diff: https://reviews.apache.org/r/63332/diff/2/

Changes: https://reviews.apache.org/r/63332/diff/1-2/


Testing
---


Thanks,

Zhitao Li

Re: Review Request 63332: Logged the resources in DRF sorter CHECK.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63332/#review189323
---


Fix it, then Ship it!





src/master/allocator/sorter/drf/sorter.hpp
Lines 385-386 (original), 388-392 (patched)


Not yours, but can we use 

```
CHECK(resources.contains(slaveId));
CHECK(resources.at(slaveId).contains(oldAllocation)) << ...
```

like above?

It doesn't strictly belong to this review but since you are editing these 
lines we might as well.


- Jiang Yan Xu


On Oct. 26, 2017, 9:42 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63332/
> ---
> 
> (Updated Oct. 26, 2017, 9:42 a.m.)
> 
> 
> Review request for mesos, James Peach and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If calls to these checks fails, log related resources objects which
> causes the failure.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/sorter/drf/sorter.hpp 
> 77e52dec735d276389643f7f356cd763b2f785e9 
> 
> 
> Diff: https://reviews.apache.org/r/63332/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>