Re: Review Request 63862: Windows: Ported docker_tests.cpp.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/#review198756
---


Ship it!




Ship It!

- Andrew Schwartzmeyer


On Jan. 5, 2018, 10:33 a.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63862/
> ---
> 
> (Updated Jan. 5, 2018, 10:33 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
> Kleiman, Jie Yu, John Kordich, Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ported the disabled tests to run on Windows. The following tests
> could not be ported due to Windows platform limitations and remain
> diabled:
>   - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
> sandbox).
>   - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
>   - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_common.hpp 
> 3d69e54647d34ba0f33930d84db6c052e46ebc89 
>   src/tests/containerizer/docker_tests.cpp 
> 0ac4a79e03d5e11ead5a57a9749e26c20a1ddd57 
> 
> 
> Diff: https://reviews.apache.org/r/63862/diff/8/
> 
> 
> Testing
> ---
> 
> Windows mesos-test:
> [==] 754 tests from 77 test cases ran. (270586 ms total)
> [  PASSED  ] 754 tests.
> 
> 
> Windows DockerTest only:
> [==] 11 tests from 1 test case ran. (85617 ms total)
> [  PASSED  ] 11 tests.
> 
> Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia 
> GPU):
> [==] 12 tests from 1 test case ran. (12413 ms total)
> [  PASSED  ] 12 tests.
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/#review198583
---



Patch looks great!

Reviews applied: [65839, 65861, 65862, 65840, 63862]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Jan. 5, 2018, 6:33 p.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63862/
> ---
> 
> (Updated Jan. 5, 2018, 6:33 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
> Kleiman, Jie Yu, John Kordich, Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ported the disabled tests to run on Windows. The following tests
> could not be ported due to Windows platform limitations and remain
> diabled:
>   - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
> sandbox).
>   - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
>   - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_common.hpp 
> 3d69e54647d34ba0f33930d84db6c052e46ebc89 
>   src/tests/containerizer/docker_tests.cpp 
> 0ac4a79e03d5e11ead5a57a9749e26c20a1ddd57 
> 
> 
> Diff: https://reviews.apache.org/r/63862/diff/8/
> 
> 
> Testing
> ---
> 
> Windows mesos-test:
> [==] 754 tests from 77 test cases ran. (270586 ms total)
> [  PASSED  ] 754 tests.
> 
> 
> Windows DockerTest only:
> [==] 11 tests from 1 test case ran. (85617 ms total)
> [  PASSED  ] 11 tests.
> 
> Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia 
> GPU):
> [==] 12 tests from 1 test case ran. (12413 ms total)
> [  PASSED  ] 12 tests.
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/#review198577
---



PASS: Mesos patch 63862 was successfully built and tested.

Reviews applied: `['65839', '65861', '65862', '65840', '63862']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63862

- Mesos Reviewbot Windows


On Jan. 5, 2018, 10:33 a.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63862/
> ---
> 
> (Updated Jan. 5, 2018, 10:33 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
> Kleiman, Jie Yu, John Kordich, Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ported the disabled tests to run on Windows. The following tests
> could not be ported due to Windows platform limitations and remain
> diabled:
>   - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
> sandbox).
>   - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
>   - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_common.hpp 
> 3d69e54647d34ba0f33930d84db6c052e46ebc89 
>   src/tests/containerizer/docker_tests.cpp 
> 0ac4a79e03d5e11ead5a57a9749e26c20a1ddd57 
> 
> 
> Diff: https://reviews.apache.org/r/63862/diff/8/
> 
> 
> Testing
> ---
> 
> Windows mesos-test:
> [==] 754 tests from 77 test cases ran. (270586 ms total)
> [  PASSED  ] 754 tests.
> 
> 
> Windows DockerTest only:
> [==] 11 tests from 1 test case ran. (85617 ms total)
> [  PASSED  ] 11 tests.
> 
> Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia 
> GPU):
> [==] 12 tests from 1 test case ran. (12413 ms total)
> [  PASSED  ] 12 tests.
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/#review198565
---



What's the status of this patch?

- Andrew Schwartzmeyer


On Jan. 5, 2018, 10:33 a.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63862/
> ---
> 
> (Updated Jan. 5, 2018, 10:33 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
> Kleiman, Jie Yu, John Kordich, Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ported the disabled tests to run on Windows. The following tests
> could not be ported due to Windows platform limitations and remain
> diabled:
>   - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
> sandbox).
>   - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
>   - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_common.hpp 
> 3d69e54647d34ba0f33930d84db6c052e46ebc89 
>   src/tests/containerizer/docker_tests.cpp 
> 0ac4a79e03d5e11ead5a57a9749e26c20a1ddd57 
> 
> 
> Diff: https://reviews.apache.org/r/63862/diff/7/
> 
> 
> Testing
> ---
> 
> Windows mesos-test:
> [==] 754 tests from 77 test cases ran. (270586 ms total)
> [  PASSED  ] 754 tests.
> 
> 
> Windows DockerTest only:
> [==] 11 tests from 1 test case ran. (85617 ms total)
> [  PASSED  ] 11 tests.
> 
> Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia 
> GPU):
> [==] 12 tests from 1 test case ran. (12413 ms total)
> [  PASSED  ] 12 tests.
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/#review198494
---



Patch looks great!

Reviews applied: [65839, 65861, 65862, 65840, 63862]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Jan. 5, 2018, 6:33 p.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63862/
> ---
> 
> (Updated Jan. 5, 2018, 6:33 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
> Kleiman, Jie Yu, John Kordich, Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ported the disabled tests to run on Windows. The following tests
> could not be ported due to Windows platform limitations and remain
> diabled:
>   - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
> sandbox).
>   - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
>   - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_common.hpp 
> 3d69e54647d34ba0f33930d84db6c052e46ebc89 
>   src/tests/containerizer/docker_tests.cpp 
> 0ac4a79e03d5e11ead5a57a9749e26c20a1ddd57 
> 
> 
> Diff: https://reviews.apache.org/r/63862/diff/7/
> 
> 
> Testing
> ---
> 
> Windows mesos-test:
> [==] 754 tests from 77 test cases ran. (270586 ms total)
> [  PASSED  ] 754 tests.
> 
> 
> Windows DockerTest only:
> [==] 11 tests from 1 test case ran. (85617 ms total)
> [  PASSED  ] 11 tests.
> 
> Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia 
> GPU):
> [==] 12 tests from 1 test case ran. (12413 ms total)
> [  PASSED  ] 12 tests.
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/#review198468
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['65839', '65861', '65862', '65840', '63862']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63862

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63862/logs/mesos-tests-stdout.log):

```
[   OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (144 ms)
[--] 9 tests from Endpoint/SlaveEndpointTest (1246 ms total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (40 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (44 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (87 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2586 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (2611 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2476 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (2501 ms total)

[--] Global test environment tear-down
[==] 916 tests from 91 test cases ran. (471473 ms total)
[  PASSED  ] 915 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] CommandExecutorCheckTest.CommandCheckTimeout

 1 FAILED TEST
  YOU HAVE 210 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63862/logs/mesos-tests-stderr.log):

```
I0301 20:24:08.754911  1120 master.cpp:10258] Updating the state of task 
3fe9fb67-1013-4cb8-963c-e2cba420dec4 of framework 
5141e1be-97ce-44d2-84a8-8183a8110499- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0301 20:24:08.754911  7984 slave.cpp:3879] Shutting down framework 
5141e1be-97ce-44d2-84a8-8183a8110499-
I0301 20:24:08.754911  7984 slave.cpp:6586] Shutting down executor 
'3fe9fb67-1013-4cb8-963c-e2cba420dec4' of framework 
5141e1be-97ce-44d2-84a8-8183a8110499- at executor(1)@10.3.1.11:53096
I0301 20:24:08.756911  7984 slave.cpp:922] Agent teI0301 20:24:08.048912  7596 
exec.cpp:162] Version: 1.6.0
I0301 20:24:08.078908  3588 exec.cpp:236] Executor registered on agent 
5141e1be-97ce-44d2-84a8-8183a8110499-S0
I0301 20:24:08.082911  9236 executor.cpp:176] Received SUBSCRIBED event
I0301 20:24:08.087911  9236 executor.cpp:180] Subscribed executor on 
build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0301 20:24:08.088912  9236 executor.cpp:176] Received LAUNCH event
I0301 20:24:08.093912  9236 executor.cpp:648] Starting task 
3fe9fb67-1013-4cb8-963c-e2cba420dec4
I0301 20:24:08.176914  9236 executor.cpp:483] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I0301 20:24:08.718909  9236 executor.cpp:661] Forked command at 8280
I0301 20:24:08.757910  6008 exec.cpp:445] Executor asked to shutdown
I0301 20:24:08.758909  9236 executor.cpp:176] Received SHUTDOWN event
I0301 20:24:08.758909  9236 executor.cpp:758] Shutting down
I0301 20:24:08.758909  9236 executor.cpp:868] Sending SIGTERM to process tree 
at pid 8rminating
W0301 20:24:08.757910  7984 slave.cpp:3875] Ignoring shutdown framework 
5141e1be-97ce-44d2-84a8-8183a8110499- because it is terminating
I0301 20:24:08.757910  1120 master.cpp:10357] Removing task 
3fe9fb67-1013-4cb8-963c-e2cba420dec4 with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework 5141e1be-97ce-44d2-84a8-8183a8110499- on 
agent 5141e1be-97ce-44d2-84a8-8183a8110499-S0 at slave(398)@10.3.1.11:53075 
(build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0301 20:24:08.760911  1120 master.cpp:1306] Agent 
5141e1be-97ce-44d2-84a8-8183a8110499-S0 at slave(398)@10.3.1.11:53075 
(build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0301 20:24:08.760911  1120 master.cpp:3276] Disconnecting agent 
5141e1be-97ce-44d2-84a8-8183a8110499-S0 at slave(398)@10.3.1.11:53075 
(build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0301 20:24:08.760911  1120 master.cpp:3295] Deactivating agent 
5141e1be-97ce-44d2-84a8-8183a8110499-S0 at slave(398)@10.3.1.11:53075 
(build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0301 

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/#review198357
---



Patch looks great!

Reviews applied: [63859, 63860, 63861, 63862]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Jan. 5, 2018, 6:33 p.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63862/
> ---
> 
> (Updated Jan. 5, 2018, 6:33 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
> Kleiman, Jie Yu, John Kordich, Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ported the disabled tests to run on Windows. The following tests
> could not be ported due to Windows platform limitations and remain
> diabled:
>   - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
> sandbox).
>   - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
>   - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_common.hpp 
> 3d69e54647d34ba0f33930d84db6c052e46ebc89 
>   src/tests/containerizer/docker_tests.cpp 
> 0ac4a79e03d5e11ead5a57a9749e26c20a1ddd57 
> 
> 
> Diff: https://reviews.apache.org/r/63862/diff/6/
> 
> 
> Testing
> ---
> 
> Windows mesos-test:
> [==] 754 tests from 77 test cases ran. (270586 ms total)
> [  PASSED  ] 754 tests.
> 
> 
> Windows DockerTest only:
> [==] 11 tests from 1 test case ran. (85617 ms total)
> [  PASSED  ] 11 tests.
> 
> Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia 
> GPU):
> [==] 12 tests from 1 test case ran. (12413 ms total)
> [  PASSED  ] 12 tests.
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/#review198351
---



PASS: Mesos patch 63862 was successfully built and tested.

Reviews applied: `['63862']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63862

- Mesos Reviewbot Windows


On Jan. 5, 2018, 10:33 a.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63862/
> ---
> 
> (Updated Jan. 5, 2018, 10:33 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
> Kleiman, Jie Yu, John Kordich, Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ported the disabled tests to run on Windows. The following tests
> could not be ported due to Windows platform limitations and remain
> diabled:
>   - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
> sandbox).
>   - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
>   - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_common.hpp 
> 3d69e54647d34ba0f33930d84db6c052e46ebc89 
>   src/tests/containerizer/docker_tests.cpp 
> 0ac4a79e03d5e11ead5a57a9749e26c20a1ddd57 
> 
> 
> Diff: https://reviews.apache.org/r/63862/diff/6/
> 
> 
> Testing
> ---
> 
> Windows mesos-test:
> [==] 754 tests from 77 test cases ran. (270586 ms total)
> [  PASSED  ] 754 tests.
> 
> 
> Windows DockerTest only:
> [==] 11 tests from 1 test case ran. (85617 ms total)
> [  PASSED  ] 11 tests.
> 
> Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia 
> GPU):
> [==] 12 tests from 1 test case ran. (12413 ms total)
> [  PASSED  ] 12 tests.
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

[Joseph Wu]

> On Nov. 30, 2017, 6:33 p.m., Andrew Schwartzmeyer wrote:
> > src/tests/containerizer/docker_tests.cpp
> > Line 318 (original), 391-428 (patched)
> > 
> >
> > LGTM though another maintainer may want to take a look.

The current iteration of this this test (revision 5) looks fine.  (Marking as 
Fixed)


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/#review192436
---


On Jan. 5, 2018, 10:33 a.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63862/
> ---
> 
> (Updated Jan. 5, 2018, 10:33 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
> Kleiman, Jie Yu, John Kordich, Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ported the disabled tests to run on Windows. The following tests
> could not be ported due to Windows platform limitations and remain
> diabled:
>   - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
> sandbox).
>   - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
>   - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_tests.cpp 
> 0ac4a79e03d5e11ead5a57a9749e26c20a1ddd57 
> 
> 
> Diff: https://reviews.apache.org/r/63862/diff/5/
> 
> 
> Testing
> ---
> 
> Windows mesos-test:
> [==] 754 tests from 77 test cases ran. (270586 ms total)
> [  PASSED  ] 754 tests.
> 
> 
> Windows DockerTest only:
> [==] 11 tests from 1 test case ran. (85617 ms total)
> [  PASSED  ] 11 tests.
> 
> Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia 
> GPU):
> [==] 12 tests from 1 test case ran. (12413 ms total)
> [  PASSED  ] 12 tests.
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/#review195528
---




src/tests/containerizer/docker_tests.cpp
Lines 61-62 (patched)


Is it possible to run earlier/later versions of images?

i.e. If the base OS is 1710 (or later) can it still run this image?  Or if 
the base OS is 1708 (or earlier) will the image definitely fail?



src/tests/containerizer/docker_tests.cpp
Lines 127 (patched)


Avoid using `CHECK` which can prematurely stop the test suite.  Try 
`ASSERT_TRUE(future.ready());`.



src/tests/containerizer/docker_tests.cpp
Lines 155-163 (patched)


It doesn't really make a difference to the Linux tests whether they mount a 
file or directory.  We might as well make them all mount a directory; and 
thereby remove this helper.



src/tests/containerizer/docker_tests.cpp
Lines 580-582 (original), 712-715 (patched)


Do you know if this will _never_ be supported?
In which case, we should get rid of the `_TEMP_DISABLED_ON_WINDOWS` and 
make the disabling more permanent.


- Joseph Wu


On Jan. 5, 2018, 10:33 a.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63862/
> ---
> 
> (Updated Jan. 5, 2018, 10:33 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
> Kleiman, Jie Yu, John Kordich, Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ported the disabled tests to run on Windows. The following tests
> could not be ported due to Windows platform limitations and remain
> diabled:
>   - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
> sandbox).
>   - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
>   - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_tests.cpp 
> 0ac4a79e03d5e11ead5a57a9749e26c20a1ddd57 
> 
> 
> Diff: https://reviews.apache.org/r/63862/diff/5/
> 
> 
> Testing
> ---
> 
> Windows mesos-test:
> [==] 754 tests from 77 test cases ran. (270586 ms total)
> [  PASSED  ] 754 tests.
> 
> 
> Windows DockerTest only:
> [==] 11 tests from 1 test case ran. (85617 ms total)
> [  PASSED  ] 11 tests.
> 
> Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia 
> GPU):
> [==] 12 tests from 1 test case ran. (12413 ms total)
> [  PASSED  ] 12 tests.
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

[Akash Gupta]

> On Jan. 10, 2018, 1:27 p.m., Alexander Rukletsov wrote:
> > src/tests/containerizer/docker_tests.cpp
> > Lines 139-153 (patched)
> > 
> >
> > Again, this is something we should likely do in a broader scope. 
> > Chances are, someone else in a different place will try to solve the same 
> > problem.
> 
> Andrew Schwartzmeyer wrote:
> Same as above. At the point of someone else solving the same problem, 
> then it would make sense to move the code into a more general purpose 
> location and reuse it. But we shouldn't do it until then, because otherwise 
> we're just guessing at future technical needs.
> 
> Akash Gupta wrote:
> This is specific to Docker and only for test code that checks the 
> container exit value, which is onlt used here. So, I don't think other places 
> will ever use this.
> 
> Andrew Schwartzmeyer wrote:
> I was talking with Alex, and while I don't think `stout` is necessarily 
> the right place for this kind of code, there is potential clean up here:
> 
> ```
> src/tests/containerizer/docker_containerizer_tests.cpp
> 1288:  AWAIT_EXPECT_WEXITSTATUS_EQ(128 + SIGKILL, orphanRun);
> 1425:  AWAIT_EXPECT_WEXITSTATUS_EQ(128 + SIGKILL, orphanRun);
> 
> src/tests/containerizer/ns_tests.cpp
> 101:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, s->status());
> 
> src/tests/containerizer/docker_tests.cpp
> 170:  AWAIT_EXPECT_WEXITSTATUS_EQ(128 + SIGKILL, status);
> 250:  AWAIT_EXPECT_WEXITSTATUS_EQ(128 + SIGKILL, status);
> 318:  AWAIT_EXPECT_WEXITSTATUS_EQ(128 + SIGKILL, run);
> 449:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, run);
> 528:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, run);
> 574:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, run);
> 623:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, run);
> 844:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, status);
> 918:  AWAIT_EXPECT_WEXITSTATUS_EQ(128 + SIGKILL, status);
> 
> src/tests/containerizer/capabilities_tests.cpp
> 98:  AWAIT_EXPECT_WEXITSTATUS_NE(0, s->status());
> 122:  AWAIT_EXPECT_WEXITSTATUS_NE(0, s->status());
> 151:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, s->status());
> 
> 3rdparty/libprocess/src/tests/reap_tests.cpp
> 98:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, status);
> 172:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, status);
> 
> 3rdparty/libprocess/include/process/gtest.hpp
> 623:#define AWAIT_EXPECT_WEXITSTATUS_EQ_FOR(expected, actual, duration)   
>   \
> 627:#define AWAIT_EXPECT_WEXITSTATUS_EQ(expected, actual) 
>   \
> 628:  AWAIT_EXPECT_WEXITSTATUS_EQ_FOR(expected, actual, Seconds(15))
> 664:#define AWAIT_EXPECT_WEXITSTATUS_NE_FOR(expected, actual, duration)   
>   \
> 668:#define AWAIT_EXPECT_WEXITSTATUS_NE(expected, actual) 
>   \
> 669:  AWAIT_EXPECT_WEXITSTATUS_NE_FOR(expected, actual, Seconds(15))
> 
> 3rdparty/libprocess/src/tests/subprocess_tests.cpp
> 72:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
> 249:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
> 264:  AWAIT_EXPECT_WEXITSTATUS_EQ(1, s.get().status());
> 323:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
> 344:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
> 371:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
> 411:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
> 442:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
> 465:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
> 497:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
> 531:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
> 562:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
> 599:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
> 617:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
> 700:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
> 763:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
> 789:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
> 818:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
> 847:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
> 879:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
> ```
> 
> Especially the ones that do `128 + SIGKILL`; just WTF is that even doing? 
> No one should have to go to [Stack 
> Overflow](https://unix.stackexchange.com/a/99134) to understand what an 
> assertion in a test is doing.
> 
> It may be reasonable to go to `include/process/gtest.hpp` and make this 
> easier, with `AWAIT_EXPECT_EXIT_SIGKILL(status)` (and like 
> `AWAIT_EXPECT_EXIT_SUCCESS(status)` for `== 0`).

The weird exit code only happens to docker containers getting stopped/killed, 
so I think only the `128+SIGKILL` ones need to be cleaned up in 
`docker_tests.cpp` and `docker_containerizer_tests.cpp`


- Akash


---
This is an automatically generated e-mail. To reply, visit:

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

[Andrew Schwartzmeyer]

> On Jan. 10, 2018, 5:27 a.m., Alexander Rukletsov wrote:
> > src/tests/containerizer/docker_tests.cpp
> > Lines 139-153 (patched)
> > 
> >
> > Again, this is something we should likely do in a broader scope. 
> > Chances are, someone else in a different place will try to solve the same 
> > problem.
> 
> Andrew Schwartzmeyer wrote:
> Same as above. At the point of someone else solving the same problem, 
> then it would make sense to move the code into a more general purpose 
> location and reuse it. But we shouldn't do it until then, because otherwise 
> we're just guessing at future technical needs.
> 
> Akash Gupta wrote:
> This is specific to Docker and only for test code that checks the 
> container exit value, which is onlt used here. So, I don't think other places 
> will ever use this.

I was talking with Alex, and while I don't think `stout` is necessarily the 
right place for this kind of code, there is potential clean up here:

```
src/tests/containerizer/docker_containerizer_tests.cpp
1288:  AWAIT_EXPECT_WEXITSTATUS_EQ(128 + SIGKILL, orphanRun);
1425:  AWAIT_EXPECT_WEXITSTATUS_EQ(128 + SIGKILL, orphanRun);

src/tests/containerizer/ns_tests.cpp
101:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, s->status());

src/tests/containerizer/docker_tests.cpp
170:  AWAIT_EXPECT_WEXITSTATUS_EQ(128 + SIGKILL, status);
250:  AWAIT_EXPECT_WEXITSTATUS_EQ(128 + SIGKILL, status);
318:  AWAIT_EXPECT_WEXITSTATUS_EQ(128 + SIGKILL, run);
449:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, run);
528:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, run);
574:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, run);
623:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, run);
844:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, status);
918:  AWAIT_EXPECT_WEXITSTATUS_EQ(128 + SIGKILL, status);

src/tests/containerizer/capabilities_tests.cpp
98:  AWAIT_EXPECT_WEXITSTATUS_NE(0, s->status());
122:  AWAIT_EXPECT_WEXITSTATUS_NE(0, s->status());
151:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, s->status());

3rdparty/libprocess/src/tests/reap_tests.cpp
98:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, status);
172:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, status);

3rdparty/libprocess/include/process/gtest.hpp
623:#define AWAIT_EXPECT_WEXITSTATUS_EQ_FOR(expected, actual, duration) \
627:#define AWAIT_EXPECT_WEXITSTATUS_EQ(expected, actual)   \
628:  AWAIT_EXPECT_WEXITSTATUS_EQ_FOR(expected, actual, Seconds(15))
664:#define AWAIT_EXPECT_WEXITSTATUS_NE_FOR(expected, actual, duration) \
668:#define AWAIT_EXPECT_WEXITSTATUS_NE(expected, actual)   \
669:  AWAIT_EXPECT_WEXITSTATUS_NE_FOR(expected, actual, Seconds(15))

3rdparty/libprocess/src/tests/subprocess_tests.cpp
72:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
249:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
264:  AWAIT_EXPECT_WEXITSTATUS_EQ(1, s.get().status());
323:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
344:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
371:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
411:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
442:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
465:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
497:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
531:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
562:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
599:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
617:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
700:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
763:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
789:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
818:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
847:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
879:  AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
```

Especially the ones that do `128 + SIGKILL`; just WTF is that even doing? No 
one should have to go to [Stack 
Overflow](https://unix.stackexchange.com/a/99134) to understand what an 
assertion in a test is doing.

It may be reasonable to go to `include/process/gtest.hpp` and make this easier, 
with `AWAIT_EXPECT_EXIT_SIGKILL(status)` (and like 
`AWAIT_EXPECT_EXIT_SUCCESS(status)` for `== 0`).


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/#review195133
---


On Jan. 5, 2018, 10:33 a.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63862/
> ---
> 
> (Updated Jan. 5, 2018, 10:33 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
> Kleiman, Jie Yu, John Kordich, Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
> 

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

[Akash Gupta]

> On Jan. 10, 2018, 1:27 p.m., Alexander Rukletsov wrote:
> > src/tests/containerizer/docker_tests.cpp
> > Lines 130-137 (patched)
> > 
> >
> > Looks like instead of this adhoc routine we should rather introduce a 
> > root prefix in stout.
> 
> Andrew Schwartzmeyer wrote:
> I don't think we should introduce this abstraction into stout until it 
> becomes the case that other code needs it too. Currently, this abstraction is 
> needed solely to make the Docker tests compatible on both platforms. Let's 
> avoid unnecessary stout bloat.

Yeah, the function is just a helper function for some of the Docker tests. I 
don't see how this would be used anywhere else.


> On Jan. 10, 2018, 1:27 p.m., Alexander Rukletsov wrote:
> > src/tests/containerizer/docker_tests.cpp
> > Lines 139-153 (patched)
> > 
> >
> > Again, this is something we should likely do in a broader scope. 
> > Chances are, someone else in a different place will try to solve the same 
> > problem.
> 
> Andrew Schwartzmeyer wrote:
> Same as above. At the point of someone else solving the same problem, 
> then it would make sense to move the code into a more general purpose 
> location and reuse it. But we shouldn't do it until then, because otherwise 
> we're just guessing at future technical needs.

This is specific to Docker and only for test code that checks the container 
exit value, which is onlt used here. So, I don't think other places will ever 
use this.


- Akash


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/#review195133
---


On Jan. 5, 2018, 6:33 p.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63862/
> ---
> 
> (Updated Jan. 5, 2018, 6:33 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
> Kleiman, Jie Yu, John Kordich, Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ported the disabled tests to run on Windows. The following tests
> could not be ported due to Windows platform limitations and remain
> diabled:
>   - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
> sandbox).
>   - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
>   - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_tests.cpp 
> 0ac4a79e03d5e11ead5a57a9749e26c20a1ddd57 
> 
> 
> Diff: https://reviews.apache.org/r/63862/diff/5/
> 
> 
> Testing
> ---
> 
> Windows mesos-test:
> [==] 754 tests from 77 test cases ran. (270586 ms total)
> [  PASSED  ] 754 tests.
> 
> 
> Windows DockerTest only:
> [==] 11 tests from 1 test case ran. (85617 ms total)
> [  PASSED  ] 11 tests.
> 
> Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia 
> GPU):
> [==] 12 tests from 1 test case ran. (12413 ms total)
> [  PASSED  ] 12 tests.
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

[Andrew Schwartzmeyer]

> On Jan. 10, 2018, 5:27 a.m., Alexander Rukletsov wrote:
> > src/tests/containerizer/docker_tests.cpp
> > Lines 130-137 (patched)
> > 
> >
> > Looks like instead of this adhoc routine we should rather introduce a 
> > root prefix in stout.

I don't think we should introduce this abstraction into stout until it becomes 
the case that other code needs it too. Currently, this abstraction is needed 
solely to make the Docker tests compatible on both platforms. Let's avoid 
unnecessary stout bloat.


> On Jan. 10, 2018, 5:27 a.m., Alexander Rukletsov wrote:
> > src/tests/containerizer/docker_tests.cpp
> > Lines 139-153 (patched)
> > 
> >
> > Again, this is something we should likely do in a broader scope. 
> > Chances are, someone else in a different place will try to solve the same 
> > problem.

Same as above. At the point of someone else solving the same problem, then it 
would make sense to move the code into a more general purpose location and 
reuse it. But we shouldn't do it until then, because otherwise we're just 
guessing at future technical needs.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/#review195133
---


On Jan. 5, 2018, 10:33 a.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63862/
> ---
> 
> (Updated Jan. 5, 2018, 10:33 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
> Kleiman, Jie Yu, John Kordich, Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ported the disabled tests to run on Windows. The following tests
> could not be ported due to Windows platform limitations and remain
> diabled:
>   - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
> sandbox).
>   - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
>   - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_tests.cpp 
> 0ac4a79e03d5e11ead5a57a9749e26c20a1ddd57 
> 
> 
> Diff: https://reviews.apache.org/r/63862/diff/5/
> 
> 
> Testing
> ---
> 
> Windows mesos-test:
> [==] 754 tests from 77 test cases ran. (270586 ms total)
> [  PASSED  ] 754 tests.
> 
> 
> Windows DockerTest only:
> [==] 11 tests from 1 test case ran. (85617 ms total)
> [  PASSED  ] 11 tests.
> 
> Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia 
> GPU):
> [==] 12 tests from 1 test case ran. (12413 ms total)
> [  PASSED  ] 12 tests.
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/#review195138
---



PASS: Mesos patch 63862 was successfully built and tested.

Reviews applied: `['63859', '63860', '63861', '63862']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63862

- Mesos Reviewbot Windows


On Jan. 6, 2018, 2:33 a.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63862/
> ---
> 
> (Updated Jan. 6, 2018, 2:33 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
> Kleiman, Jie Yu, John Kordich, Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ported the disabled tests to run on Windows. The following tests
> could not be ported due to Windows platform limitations and remain
> diabled:
>   - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
> sandbox).
>   - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
>   - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_tests.cpp 
> 0ac4a79e03d5e11ead5a57a9749e26c20a1ddd57 
> 
> 
> Diff: https://reviews.apache.org/r/63862/diff/5/
> 
> 
> Testing
> ---
> 
> Windows mesos-test:
> [==] 754 tests from 77 test cases ran. (270586 ms total)
> [  PASSED  ] 754 tests.
> 
> 
> Windows DockerTest only:
> [==] 11 tests from 1 test case ran. (85617 ms total)
> [  PASSED  ] 11 tests.
> 
> Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia 
> GPU):
> [==] 12 tests from 1 test case ran. (12413 ms total)
> [  PASSED  ] 12 tests.
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/#review195133
---




src/tests/containerizer/docker_tests.cpp
Lines 130-137 (patched)


Looks like instead of this adhoc routine we should rather introduce a root 
prefix in stout.



src/tests/containerizer/docker_tests.cpp
Lines 139-153 (patched)


Again, this is something we should likely do in a broader scope. Chances 
are, someone else in a different place will try to solve the same problem.


- Alexander Rukletsov


On Jan. 5, 2018, 6:33 p.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63862/
> ---
> 
> (Updated Jan. 5, 2018, 6:33 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
> Kleiman, Jie Yu, John Kordich, Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ported the disabled tests to run on Windows. The following tests
> could not be ported due to Windows platform limitations and remain
> diabled:
>   - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
> sandbox).
>   - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
>   - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_tests.cpp 
> 0ac4a79e03d5e11ead5a57a9749e26c20a1ddd57 
> 
> 
> Diff: https://reviews.apache.org/r/63862/diff/5/
> 
> 
> Testing
> ---
> 
> Windows mesos-test:
> [==] 754 tests from 77 test cases ran. (270586 ms total)
> [  PASSED  ] 754 tests.
> 
> 
> Windows DockerTest only:
> [==] 11 tests from 1 test case ran. (85617 ms total)
> [  PASSED  ] 11 tests.
> 
> Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia 
> GPU):
> [==] 12 tests from 1 test case ran. (12413 ms total)
> [  PASSED  ] 12 tests.
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

[Akash Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/
---

(Updated Jan. 5, 2018, 6:33 p.m.)


Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
Kleiman, Jie Yu, John Kordich, Joseph Wu, and Michael Park.


Changes
---

Updated to reflect network changes.


Bugs: MESOS-7342
https://issues.apache.org/jira/browse/MESOS-7342


Repository: mesos


Description
---

Ported the disabled tests to run on Windows. The following tests
could not be ported due to Windows platform limitations and remain
diabled:
  - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
sandbox).
  - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
  - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).


Diffs (updated)
-

  src/tests/containerizer/docker_tests.cpp 
0ac4a79e03d5e11ead5a57a9749e26c20a1ddd57 


Diff: https://reviews.apache.org/r/63862/diff/5/

Changes: https://reviews.apache.org/r/63862/diff/4-5/


Testing
---

Windows mesos-test:
[==] 754 tests from 77 test cases ran. (270586 ms total)
[  PASSED  ] 754 tests.


Windows DockerTest only:
[==] 11 tests from 1 test case ran. (85617 ms total)
[  PASSED  ] 11 tests.

Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia GPU):
[==] 12 tests from 1 test case ran. (12413 ms total)
[  PASSED  ] 12 tests.


Thanks,

Akash Gupta

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

[Akash Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/
---

(Updated Jan. 5, 2018, 12:30 a.m.)


Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
Kleiman, Jie Yu, John Kordich, Joseph Wu, and Michael Park.


Changes
---

Rebased.


Bugs: MESOS-7342
https://issues.apache.org/jira/browse/MESOS-7342


Repository: mesos


Description
---

Ported the disabled tests to run on Windows. The following tests
could not be ported due to Windows platform limitations and remain
diabled:
  - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
sandbox).
  - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
  - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).


Diffs (updated)
-

  src/tests/containerizer/docker_tests.cpp 
0ac4a79e03d5e11ead5a57a9749e26c20a1ddd57 


Diff: https://reviews.apache.org/r/63862/diff/4/

Changes: https://reviews.apache.org/r/63862/diff/3-4/


Testing
---

Windows mesos-test:
[==] 754 tests from 77 test cases ran. (270586 ms total)
[  PASSED  ] 754 tests.


Windows DockerTest only:
[==] 11 tests from 1 test case ran. (85617 ms total)
[  PASSED  ] 11 tests.

Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia GPU):
[==] 12 tests from 1 test case ran. (12413 ms total)
[  PASSED  ] 12 tests.


Thanks,

Akash Gupta

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/#review193177
---


Ship it!




Ship It!

- Andrew Schwartzmeyer


On Dec. 7, 2017, 4:05 a.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63862/
> ---
> 
> (Updated Dec. 7, 2017, 4:05 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Jie Yu, John Kordich, and 
> Joseph Wu.
> 
> 
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ported the disabled tests to run on Windows. The following tests
> could not be ported due to Windows platform limitations and remain
> diabled:
>   - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
> sandbox).
>   - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
>   - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_tests.cpp 
> 5cabf5a0b0164f9923008677c58806c8931cbc8d 
> 
> 
> Diff: https://reviews.apache.org/r/63862/diff/3/
> 
> 
> Testing
> ---
> 
> Windows mesos-test:
> [==] 754 tests from 77 test cases ran. (270586 ms total)
> [  PASSED  ] 754 tests.
> 
> 
> Windows DockerTest only:
> [==] 11 tests from 1 test case ran. (85617 ms total)
> [  PASSED  ] 11 tests.
> 
> Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia 
> GPU):
> [==] 12 tests from 1 test case ran. (12413 ms total)
> [  PASSED  ] 12 tests.
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

[Akash Gupta]

> On Dec. 1, 2017, 2:33 a.m., Andrew Schwartzmeyer wrote:
> > src/tests/containerizer/docker_tests.cpp
> > Lines 62 (patched)
> > 
> >
> > We should probably comment as to why this doesn't use PowerShell 
> > (nanoserver image doesn't have it).
> > 
> > Especially considering that `SLEEP_COMMAND` exists elsewhere, someone 
> > could easily assume they should change it.
> 
> Akash Gupta wrote:
> There's a nanoserver image at `microsoft/powershell`. I can use that.

Added comment on why `SLEEP_COMMAND` can't be used.


> On Dec. 1, 2017, 2:33 a.m., Andrew Schwartzmeyer wrote:
> > src/tests/containerizer/docker_tests.cpp
> > Lines 107-111 (patched)
> > 
> >
> > Since this could end up being really slow and make the tests appear 
> > hung, I think we should `LOG(WARNING) << "Downloading Docker image...";` or 
> > something to that effect.
> > 
> > (So much better than Hours(1) though.)

Added.


> On Dec. 1, 2017, 2:33 a.m., Andrew Schwartzmeyer wrote:
> > src/tests/containerizer/docker_tests.cpp
> > Lines 121-128 (patched)
> > 
> >
> > I see where this is quite useful, but perhaps the name could be a bit 
> > mores descriptive? I was thinking `from_root_dir` maybe?

Changed.


> On Dec. 1, 2017, 2:33 a.m., Andrew Schwartzmeyer wrote:
> > src/tests/containerizer/docker_tests.cpp
> > Line 170 (original), 232-237 (patched)
> > 
> >
> > Saw your reply explaining this on the review. I think we need to add a 
> > comment with the same explanation.

Yeah. Added an explanation


- Akash


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/#review192436
---


On Dec. 7, 2017, 12:05 p.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63862/
> ---
> 
> (Updated Dec. 7, 2017, 12:05 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Jie Yu, John Kordich, and 
> Joseph Wu.
> 
> 
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ported the disabled tests to run on Windows. The following tests
> could not be ported due to Windows platform limitations and remain
> diabled:
>   - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
> sandbox).
>   - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
>   - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_tests.cpp 
> 5cabf5a0b0164f9923008677c58806c8931cbc8d 
> 
> 
> Diff: https://reviews.apache.org/r/63862/diff/3/
> 
> 
> Testing
> ---
> 
> Windows mesos-test:
> [==] 754 tests from 77 test cases ran. (270586 ms total)
> [  PASSED  ] 754 tests.
> 
> 
> Windows DockerTest only:
> [==] 11 tests from 1 test case ran. (85617 ms total)
> [  PASSED  ] 11 tests.
> 
> Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia 
> GPU):
> [==] 12 tests from 1 test case ran. (12413 ms total)
> [  PASSED  ] 12 tests.
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

[Akash Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/
---

(Updated Dec. 7, 2017, 12:05 p.m.)


Review request for mesos, Andrew Schwartzmeyer, Jie Yu, John Kordich, and 
Joseph Wu.


Changes
---

Now running custom powershell image that doesn't need to `--isolation=hyperv` 
workaround.


Bugs: MESOS-7342
https://issues.apache.org/jira/browse/MESOS-7342


Repository: mesos


Description
---

Ported the disabled tests to run on Windows. The following tests
could not be ported due to Windows platform limitations and remain
diabled:
  - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
sandbox).
  - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
  - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).


Diffs (updated)
-

  src/tests/containerizer/docker_tests.cpp 
5cabf5a0b0164f9923008677c58806c8931cbc8d 


Diff: https://reviews.apache.org/r/63862/diff/3/

Changes: https://reviews.apache.org/r/63862/diff/2-3/


Testing
---

Windows mesos-test:
[==] 754 tests from 77 test cases ran. (270586 ms total)
[  PASSED  ] 754 tests.


Windows DockerTest only:
[==] 11 tests from 1 test case ran. (85617 ms total)
[  PASSED  ] 11 tests.

Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia GPU):
[==] 12 tests from 1 test case ran. (12413 ms total)
[  PASSED  ] 12 tests.


Thanks,

Akash Gupta

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

[Andrew Schwartzmeyer]

> On Dec. 1, 2017, 3:25 a.m., Mesos Reviewbot Windows wrote:
> > FAIL: Mesos libprocess-tests failed to build
> > 
> > Reviews applied: `['63859', '63860', '63861', '63862']`
> > 
> > Failed command: `cmake.exe --build . --target libprocess-tests --config 
> > Debug`
> > 
> > All the build artifacts available at: 
> > http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63862
> > 
> > Relevant logs:
> > 
> > - 
> > [libprocess-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63862/logs/libprocess-tests-build-cmake-stdout.log):
> > 
> > ```
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(62): 
> > warning C4996: 'GetVersionExW': was declared deprecated (compiling source 
> > file 
> > C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\state_machine_tests.cpp) 
> > [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(451): 
> > warning C4996: 'GetVersionExW': was declared deprecated (compiling source 
> > file 
> > C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\state_machine_tests.cpp) 
> > [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(805): 
> > warning C4244: 'argument': conversion from 'ULONG_PTR' to 'pid_t', possible 
> > loss of data (compiling source file 
> > C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\state_machine_tests.cpp) 
> > [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(62): 
> > warning C4996: 'GetVersionExW': was declared deprecated (compiling source 
> > file 
> > C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\subprocess_tests.cpp) 
> > [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(451): 
> > warning C4996: 'GetVersionExW': was declared deprecated (compiling source 
> > file 
> > C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\subprocess_tests.cpp) 
> > [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(62): 
> > warning C4996: 'GetVersionExW': was declared deprecated (compiling source 
> > file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\system_tests.cpp) 
> > [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(451): 
> > warning C4996: 'GetVersionExW': was declared deprecated (compiling source 
> > file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\system_tests.cpp) 
> > [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(805): 
> > warning C4244: 'argument': conversion from 'ULONG_PTR' to 'pid_t', possible 
> > loss of data (compiling source file 
> > C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\subprocess_tests.cpp) 
> > [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(805): 
> > warning C4244: 'argument': conversion from 'ULONG_PTR' to 'pid_t', possible 
> > loss of data (compiling source file 
> > C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\system_tests.cpp) 
> > [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(62): 
> > warning C4996: 'GetVersionExW': was declared deprecated (compiling source 
> > file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\time_tests.cpp) 
> > [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(451): 
> > warning C4996: 'GetVersionExW': was declared deprecated (compiling source 
> > file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\time_tests.cpp) 
> > [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(805): 
> > warning C4244: 'argument': conversion from 'ULONG_PTR' to 'pid_t', possible 
> > loss of data (compiling source file 
> > C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\time_tests.cpp) 
> > [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(62): 
> > warning C4996: 'GetVersionExW': was declared deprecated (compiling source 
> > file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\ssl_tests.cpp) 
> > [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(451): 
> > warning C4996: 'GetVersionExW': was declared deprecated (compiling source 
> > file 

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

[Akash Gupta]

> On Dec. 1, 2017, 2:33 a.m., Andrew Schwartzmeyer wrote:
> > src/tests/containerizer/docker_tests.cpp
> > Lines 62 (patched)
> > 
> >
> > We should probably comment as to why this doesn't use PowerShell 
> > (nanoserver image doesn't have it).
> > 
> > Especially considering that `SLEEP_COMMAND` exists elsewhere, someone 
> > could easily assume they should change it.

There's a nanoserver image at `microsoft/powershell`. I can use that.


> On Dec. 1, 2017, 2:33 a.m., Andrew Schwartzmeyer wrote:
> > src/tests/containerizer/docker_tests.cpp
> > Lines 63 (patched)
> > 
> >
> > Is this the canonical path it should use on Windows? Seems like we 
> > could choose an arbitrary path.

It's an arbitrary path. I just chose it because the Linux test uses 
`/mnt/sandbox/mesos`


- Akash


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/#review192436
---


On Dec. 1, 2017, 2:34 a.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63862/
> ---
> 
> (Updated Dec. 1, 2017, 2:34 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Jie Yu, John Kordich, and 
> Joseph Wu.
> 
> 
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ported the disabled tests to run on Windows. The following tests
> could not be ported due to Windows platform limitations and remain
> diabled:
>   - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
> sandbox).
>   - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
>   - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_tests.cpp 
> 5cabf5a0b0164f9923008677c58806c8931cbc8d 
> 
> 
> Diff: https://reviews.apache.org/r/63862/diff/2/
> 
> 
> Testing
> ---
> 
> Windows mesos-test:
> [==] 754 tests from 77 test cases ran. (270586 ms total)
> [  PASSED  ] 754 tests.
> 
> 
> Windows DockerTest only:
> [==] 11 tests from 1 test case ran. (85617 ms total)
> [  PASSED  ] 11 tests.
> 
> Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia 
> GPU):
> [==] 12 tests from 1 test case ran. (12413 ms total)
> [  PASSED  ] 12 tests.
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

[Andrew Schwartzmeyer]

> On Dec. 1, 2017, 3:25 a.m., Mesos Reviewbot Windows wrote:
> > FAIL: Mesos libprocess-tests failed to build
> > 
> > Reviews applied: `['63859', '63860', '63861', '63862']`
> > 
> > Failed command: `cmake.exe --build . --target libprocess-tests --config 
> > Debug`
> > 
> > All the build artifacts available at: 
> > http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63862
> > 
> > Relevant logs:
> > 
> > - 
> > [libprocess-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63862/logs/libprocess-tests-build-cmake-stdout.log):
> > 
> > ```
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(62): 
> > warning C4996: 'GetVersionExW': was declared deprecated (compiling source 
> > file 
> > C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\state_machine_tests.cpp) 
> > [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(451): 
> > warning C4996: 'GetVersionExW': was declared deprecated (compiling source 
> > file 
> > C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\state_machine_tests.cpp) 
> > [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(805): 
> > warning C4244: 'argument': conversion from 'ULONG_PTR' to 'pid_t', possible 
> > loss of data (compiling source file 
> > C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\state_machine_tests.cpp) 
> > [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(62): 
> > warning C4996: 'GetVersionExW': was declared deprecated (compiling source 
> > file 
> > C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\subprocess_tests.cpp) 
> > [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(451): 
> > warning C4996: 'GetVersionExW': was declared deprecated (compiling source 
> > file 
> > C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\subprocess_tests.cpp) 
> > [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(62): 
> > warning C4996: 'GetVersionExW': was declared deprecated (compiling source 
> > file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\system_tests.cpp) 
> > [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(451): 
> > warning C4996: 'GetVersionExW': was declared deprecated (compiling source 
> > file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\system_tests.cpp) 
> > [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(805): 
> > warning C4244: 'argument': conversion from 'ULONG_PTR' to 'pid_t', possible 
> > loss of data (compiling source file 
> > C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\subprocess_tests.cpp) 
> > [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(805): 
> > warning C4244: 'argument': conversion from 'ULONG_PTR' to 'pid_t', possible 
> > loss of data (compiling source file 
> > C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\system_tests.cpp) 
> > [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(62): 
> > warning C4996: 'GetVersionExW': was declared deprecated (compiling source 
> > file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\time_tests.cpp) 
> > [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(451): 
> > warning C4996: 'GetVersionExW': was declared deprecated (compiling source 
> > file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\time_tests.cpp) 
> > [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(805): 
> > warning C4244: 'argument': conversion from 'ULONG_PTR' to 'pid_t', possible 
> > loss of data (compiling source file 
> > C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\time_tests.cpp) 
> > [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(62): 
> > warning C4996: 'GetVersionExW': was declared deprecated (compiling source 
> > file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\ssl_tests.cpp) 
> > [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(451): 
> > warning C4996: 'GetVersionExW': was declared deprecated (compiling source 
> > file 

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/#review192473
---



FAIL: Mesos libprocess-tests failed to build

Reviews applied: `['63859', '63860', '63861', '63862']`

Failed command: `cmake.exe --build . --target libprocess-tests --config Debug`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63862

Relevant logs:

- 
[libprocess-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63862/logs/libprocess-tests-build-cmake-stdout.log):

```
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(62): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\state_machine_tests.cpp) 
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(451): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\state_machine_tests.cpp) 
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(805): warning 
C4244: 'argument': conversion from 'ULONG_PTR' to 'pid_t', possible loss of 
data (compiling source file 
C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\state_machine_tests.cpp) 
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(62): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\subprocess_tests.cpp) 
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(451): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\subprocess_tests.cpp) 
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(62): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\system_tests.cpp) 
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(451): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\system_tests.cpp) 
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(805): warning 
C4244: 'argument': conversion from 'ULONG_PTR' to 'pid_t', possible loss of 
data (compiling source file 
C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\subprocess_tests.cpp) 
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(805): warning 
C4244: 'argument': conversion from 'ULONG_PTR' to 'pid_t', possible loss of 
data (compiling source file 
C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\system_tests.cpp) 
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(62): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\time_tests.cpp) 
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(451): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\time_tests.cpp) 
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(805): warning 
C4244: 'argument': conversion from 'ULONG_PTR' to 'pid_t', possible loss of 
data (compiling source file 
C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\time_tests.cpp) 
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(62): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\ssl_tests.cpp) 
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(451): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\ssl_tests.cpp) 
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/#review192436
---




src/tests/containerizer/docker_tests.cpp
Lines 62 (patched)


We should probably comment as to why this doesn't use PowerShell 
(nanoserver image doesn't have it).

Especially considering that `SLEEP_COMMAND` exists elsewhere, someone could 
easily assume they should change it.



src/tests/containerizer/docker_tests.cpp
Lines 63 (patched)


Is this the canonical path it should use on Windows? Seems like we could 
choose an arbitrary path.



src/tests/containerizer/docker_tests.cpp
Lines 107-111 (patched)


Since this could end up being really slow and make the tests appear hung, I 
think we should `LOG(WARNING) << "Downloading Docker image...";` or something 
to that effect.

(So much better than Hours(1) though.)



src/tests/containerizer/docker_tests.cpp
Lines 121-128 (patched)


I see where this is quite useful, but perhaps the name could be a bit mores 
descriptive? I was thinking `from_root_dir` maybe?



src/tests/containerizer/docker_tests.cpp
Line 170 (original), 232-237 (patched)


Saw your reply explaining this on the review. I think we need to add a 
comment with the same explanation.



src/tests/containerizer/docker_tests.cpp
Line 318 (original), 391-428 (patched)


LGTM though another maintainer may want to take a look.



src/tests/containerizer/docker_tests.cpp
Lines 624-630 (patched)


Ah the woes of new technology.


- Andrew Schwartzmeyer


On Nov. 27, 2017, 9:45 a.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63862/
> ---
> 
> (Updated Nov. 27, 2017, 9:45 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and John Kordich.
> 
> 
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ported the disabled tests to run on Windows. The following tests
> could not be ported due to Windows platform limitations and remain
> diabled:
>   - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
> sandbox).
>   - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
>   - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_tests.cpp 
> 5cabf5a0b0164f9923008677c58806c8931cbc8d 
> 
> 
> Diff: https://reviews.apache.org/r/63862/diff/2/
> 
> 
> Testing
> ---
> 
> Windows mesos-test:
> [==] 754 tests from 77 test cases ran. (270586 ms total)
> [  PASSED  ] 754 tests.
> 
> 
> Windows DockerTest only:
> [==] 11 tests from 1 test case ran. (85617 ms total)
> [  PASSED  ] 11 tests.
> 
> Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia 
> GPU):
> [==] 12 tests from 1 test case ran. (12413 ms total)
> [  PASSED  ] 12 tests.
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

[Andrew Schwartzmeyer]

> On Nov. 16, 2017, 11:25 a.m., Andrew Schwartzmeyer wrote:
> > src/tests/containerizer/docker_tests.cpp
> > Lines 67 (patched)
> > 
> >
> > You could declare a `Seconds(30)` and not have to use  
> > `Seconds(DOCKER_WAIT)` below.
> > 
> > It'd be nicer if we didn't have to adjust the timeouts at all...
> 
> Akash Gupta wrote:
> Hopefully it can be removed when the nanoserver image works since boots 
> up way faster...

Glad it worked out!


> On Nov. 16, 2017, 11:25 a.m., Andrew Schwartzmeyer wrote:
> > src/tests/containerizer/docker_tests.cpp
> > Lines 79-82 (patched)
> > 
> >
> > Is this assumed not fail? I don't know, but if it can fail, we should 
> > `CHECK_SOME` it before `get()`.
> 
> Akash Gupta wrote:
> It can't fail since validate = false, so it just calls a constructor.

Fair enough.


> On Nov. 16, 2017, 11:25 a.m., Andrew Schwartzmeyer wrote:
> > src/tests/containerizer/docker_tests.cpp
> > Lines 231 (patched)
> > 
> >
> > We're not checking the status code?
> 
> Akash Gupta wrote:
> On Hyper-V isolation, the status code is -1, which causes the 
> `AWAIT_EXPECT_WEXITSTATUS_EQ` macro to fail since it thinks that the process 
> failed to start. On process isolation, the status code is 
> `STATUS_CONTROL_C_EXIT`. So, I just decided to check if there was a status 
> code, and then rely on `docker ps` to determine if the container actually 
> stopped.

Ah, we should at least comment this in.


> On Nov. 16, 2017, 11:25 a.m., Andrew Schwartzmeyer wrote:
> > src/tests/containerizer/docker_tests.cpp
> > Lines 400 (patched)
> > 
> >
> > Should we maybe do `strings::remove(PREFIX, "/", container.name)` for a 
> > safer test? (Otherwise we're just assuming here that `container.name` will 
> > always be prefixed with a slash.)
> 
> Akash Gupta wrote:
> `docker inspect` will always have a / in front of the container name. 
> This is because it's more like a path, so /X means container X on the local 
> machine. So, the output would actually be wrong if it didn't have the slash 
> prefix. The weird part is that Mesos `docker->ps()` isn't actually `docker 
> ps`, but more like `docker inspect` on all containers returned by `docker ps 
> (-a)`, so I check for the slash here.

Gotcha. Let's get it in a comment.


> On Nov. 16, 2017, 11:25 a.m., Andrew Schwartzmeyer wrote:
> > src/tests/containerizer/docker_tests.cpp
> > Lines 611 (patched)
> > 
> >
> > Should we get an actual Windows temp directory instead of `C:\tmp`?
> 
> Akash Gupta wrote:
> It's just an arbitary path in the container, so the specific place 
> doesn't matter. The container is going to be deleted anyway at the end of the 
> test.

Gotcha.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/#review191223
---


On Nov. 27, 2017, 9:45 a.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63862/
> ---
> 
> (Updated Nov. 27, 2017, 9:45 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and John Kordich.
> 
> 
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ported the disabled tests to run on Windows. The following tests
> could not be ported due to Windows platform limitations and remain
> diabled:
>   - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
> sandbox).
>   - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
>   - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_tests.cpp 
> 5cabf5a0b0164f9923008677c58806c8931cbc8d 
> 
> 
> Diff: https://reviews.apache.org/r/63862/diff/2/
> 
> 
> Testing
> ---
> 
> Windows mesos-test:
> [==] 754 tests from 77 test cases ran. (270586 ms total)
> [  PASSED  ] 754 tests.
> 
> 
> Windows DockerTest only:
> [==] 11 tests from 1 test case ran. (85617 ms total)
> [  PASSED  ] 11 tests.
> 
> Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia 
> GPU):
> [==] 12 tests from 1 test case ran. (12413 ms total)
> [  PASSED  ] 12 tests.
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

[Akash Gupta]

> On Nov. 16, 2017, 7:25 p.m., Andrew Schwartzmeyer wrote:
> > src/tests/containerizer/docker_tests.cpp
> > Lines 121-124 (patched)
> > 
> >
> > Would it be possible to instead change the default network setting to 
> > `bridge`? We may have talked about this, I don't remember. What should the 
> > default be if `host` doesn't work on Windows?
> 
> Akash Gupta wrote:
> I'm not sure. The default is set in the protobuf, so I'm not sure how the 
> default can be changed for Linux vs Windows. I guess we can have `host` AND 
> `bridge` = `nat`, but that seems hacky.

Resolved by having bridge and host = nat.


> On Nov. 16, 2017, 7:25 p.m., Andrew Schwartzmeyer wrote:
> > src/tests/containerizer/docker_tests.cpp
> > Lines 399-401 (patched)
> > 
> >
> > Would this read better with an `all_of`?
> 
> Akash Gupta wrote:
> Yeah I can remove the loops with `std::algorithm`

eh, I think keeping the loop reads the best in this case.


> On Nov. 16, 2017, 7:25 p.m., Andrew Schwartzmeyer wrote:
> > src/tests/containerizer/docker_tests.cpp
> > Lines 578-624 (original), 703-752 (patched)
> > 
> >
> > Wait, why did we remove it from the list of skipped tests?
> 
> Akash Gupta wrote:
> I #ifdef'd out the tests that won't work due to limitations in Windows at 
> the OS level based off this JIRA issue 
> https://issues.apache.org/jira/browse/MESOS-6392 . Should they still be 
> TEST_F_TEMP_DISABLED_ON_WINDOWS?

after discussing, we agreed to change to TEST_F_TEMP_DISABLED_ON_WINDOWS.


> On Nov. 16, 2017, 7:25 p.m., Andrew Schwartzmeyer wrote:
> > src/tests/containerizer/docker_tests.cpp
> > Lines 790-919 (original), 926-1058 (patched)
> > 
> >
> > Why are these being compiled out?
> 
> Akash Gupta wrote:
> I #ifdef'd out the tests that won't work due to limitations in Windows at 
> the OS level based off this JIRA issue 
> https://issues.apache.org/jira/browse/MESOS-6392 . Should they still be 
> TEST_F_TEMP_DISABLED_ON_WINDOWS?

after discussing, we agreed to change to TEST_F_TEMP_DISABLED_ON_WINDOWS


- Akash


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/#review191223
---


On Nov. 27, 2017, 5:45 p.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63862/
> ---
> 
> (Updated Nov. 27, 2017, 5:45 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and John Kordich.
> 
> 
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ported the disabled tests to run on Windows. The following tests
> could not be ported due to Windows platform limitations and remain
> diabled:
>   - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
> sandbox).
>   - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
>   - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_tests.cpp 
> 5cabf5a0b0164f9923008677c58806c8931cbc8d 
> 
> 
> Diff: https://reviews.apache.org/r/63862/diff/2/
> 
> 
> Testing
> ---
> 
> Windows mesos-test:
> [==] 754 tests from 77 test cases ran. (270586 ms total)
> [  PASSED  ] 754 tests.
> 
> 
> Windows DockerTest only:
> [==] 11 tests from 1 test case ran. (85617 ms total)
> [  PASSED  ] 11 tests.
> 
> Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia 
> GPU):
> [==] 12 tests from 1 test case ran. (12413 ms total)
> [  PASSED  ] 12 tests.
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

[Akash Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/
---

(Updated Nov. 27, 2017, 5:45 p.m.)


Review request for mesos, Andrew Schwartzmeyer and John Kordich.


Changes
---

Rebased + addressed feedback. I also changed the image to use the nanserver 
image instead since it is 50x smaller. However, the nanoserver image doesn't 
work properly with volume mounts in process isolation mode, so I changed the 
mount tests to use hyper-v isolation, which works fine.


Summary (updated)
-

Windows: Ported docker_tests.cpp.


Bugs: MESOS-7342
https://issues.apache.org/jira/browse/MESOS-7342


Repository: mesos


Description (updated)
---

Ported the disabled tests to run on Windows. The following tests
could not be ported due to Windows platform limitations and remain
diabled:
  - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
sandbox).
  - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
  - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).


Diffs (updated)
-

  src/tests/containerizer/docker_tests.cpp 
5cabf5a0b0164f9923008677c58806c8931cbc8d 


Diff: https://reviews.apache.org/r/63862/diff/2/

Changes: https://reviews.apache.org/r/63862/diff/1-2/


Testing (updated)
---

Windows mesos-test:
[==] 754 tests from 77 test cases ran. (270586 ms total)
[  PASSED  ] 754 tests.


Windows DockerTest only:
[==] 11 tests from 1 test case ran. (85617 ms total)
[  PASSED  ] 11 tests.

Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia GPU):
[==] 12 tests from 1 test case ran. (12413 ms total)
[  PASSED  ] 12 tests.


Thanks,

Akash Gupta