Re: Review Request 64000: Allowed stringification of hashmaps of stringifiable types.

[Benjamin Bannier]

> On Nov. 27, 2017, 7:24 p.m., Jie Yu wrote:
> > include/mesos/type_utils.hpp
> > Line 467 (original), 467 (patched)
> > 
> >
> > Do you also need to update v1/mesos.cpp?

This makes me wonder whether we should just remove these duplicated 
declarations from these mesos-specific headers, and instead move this code into 
`stout/hashmap.hpp`. Does that make sense?


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64000/#review191910
---


On Nov. 27, 2017, 4 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64000/
> ---
> 
> (Updated Nov. 27, 2017, 4 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and haosdent huang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allowed stringification of hashmaps of stringifiable types.
> 
> 
> Diffs
> -
> 
>   include/mesos/type_utils.hpp f7f23270fadc75a8737f32ec1c3fbc01f6321248 
>   src/common/type_utils.cpp 14267559f228f23aff2e21b987795b9f4fee93fc 
> 
> 
> Diff: https://reviews.apache.org/r/64000/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 64000: Allowed stringification of hashmaps of stringifiable types.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64000/#review191910
---




include/mesos/type_utils.hpp
Line 467 (original), 467 (patched)


Do you also need to update v1/mesos.cpp?


- Jie Yu


On Nov. 27, 2017, 3 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64000/
> ---
> 
> (Updated Nov. 27, 2017, 3 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and haosdent huang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allowed stringification of hashmaps of stringifiable types.
> 
> 
> Diffs
> -
> 
>   include/mesos/type_utils.hpp f7f23270fadc75a8737f32ec1c3fbc01f6321248 
>   src/common/type_utils.cpp 14267559f228f23aff2e21b987795b9f4fee93fc 
> 
> 
> Diff: https://reviews.apache.org/r/64000/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 64000: Allowed stringification of hashmaps of stringifiable types.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64000/#review191909
---


Ship it!




Ship It!

- Jie Yu


On Nov. 27, 2017, 3 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64000/
> ---
> 
> (Updated Nov. 27, 2017, 3 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and haosdent huang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allowed stringification of hashmaps of stringifiable types.
> 
> 
> Diffs
> -
> 
>   include/mesos/type_utils.hpp f7f23270fadc75a8737f32ec1c3fbc01f6321248 
>   src/common/type_utils.cpp 14267559f228f23aff2e21b987795b9f4fee93fc 
> 
> 
> Diff: https://reviews.apache.org/r/64000/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 64000: Allowed stringification of hashmaps of stringifiable types.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64000/
---

(Updated Nov. 27, 2017, 4 p.m.)


Review request for mesos, Alexander Rukletsov and haosdent huang.


Repository: mesos


Description
---

Allowed stringification of hashmaps of stringifiable types.


Diffs
-

  include/mesos/type_utils.hpp f7f23270fadc75a8737f32ec1c3fbc01f6321248 
  src/common/type_utils.cpp 14267559f228f23aff2e21b987795b9f4fee93fc 


Diff: https://reviews.apache.org/r/64000/diff/1/


Testing
---

`make check`


Thanks,

Benjamin Bannier