Re: Review Request 64104: Added dependency of curl to agent. Enabled most health check tests.

2017-12-04 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64104/#review192799
---



FAIL: Some Mesos libprocess-tests failed.

Reviews applied: `['64102', '64103', '64104']`

Failed command: 
`C:\DCOS\mesos\3rdparty\libprocess\src\tests\Debug\libprocess-tests.exe`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64104

Relevant logs:

- 
[libprocess-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64104/logs/libprocess-tests-stdout.log):

```
[   OK ] Scheme/HTTPTest.WWWAuthenticateHeader/0 (530 ms)
[ RUN  ] Scheme/HTTPTest.WWWAuthenticateHeader/1
[   OK ] Scheme/HTTPTest.WWWAuthenticateHeader/1 (70 ms)
[ RUN  ] Scheme/HTTPTest.Accepts/0
[   OK ] Scheme/HTTPTest.Accepts/0 (663 ms)
[ RUN  ] Scheme/HTTPTest.Accepts/1
[   OK ] Scheme/HTTPTest.Accepts/1 (89 ms)
[--] 36 tests from Scheme/HTTPTest (16421 ms total)

[--] 4 tests from SSLVerifyIPAdd/SSLTest
[ RUN  ] SSLVerifyIPAdd/SSLTest.BasicSameProcess/0
[   OK ] SSLVerifyIPAdd/SSLTest.BasicSameProcess/0 (504 ms)
[ RUN  ] SSLVerifyIPAdd/SSLTest.BasicSameProcess/1
[   OK ] SSLVerifyIPAdd/SSLTest.BasicSameProcess/1 (828 ms)
[ RUN  ] SSLVerifyIPAdd/SSLTest.RequireCertificate/0
[   OK ] SSLVerifyIPAdd/SSLTest.RequireCertificate/0 (907 ms)
[ RUN  ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1
[   OK ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1 (1152 ms)
[--] 4 tests from SSLVerifyIPAdd/SSLTest (3568 ms total)

[--] Global test environment tear-down
[==] 222 tests from 35 test cases ran. (53878 ms total)
[  PASSED  ] 221 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] SSLTest.VerifyCertificate

 1 FAILED TEST
  YOU HAVE 19 DISABLED TESTS

```

- 
[libprocess-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64104/logs/libprocess-tests-stderr.log):

```
LIBPROCESS_SSL_VERIFY_CERT set to true
I1205 01:11:20.762363  5040 openssl.cpp:563] Using CA file: 
C:\Users\mesos\AppData\Local\Temp\UStHYp\cert.pem
WARNING: Logging before InitGoogleLogging() is written to STDERR
I1205 01:11:21.960752  3644 openssl.cpp:509] CA directory path unspecified! 
NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=
I1205 01:11:21.961752  3644 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I1205 01:11:21.961752  3644 openssl.cpp:526] Will use IP address verification 
in subject alternative name certificate extension.
I1205 01:11:21.961752  3644 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT 
implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1205 01:11:21.966751  3644 openssl.cpp:563] Using CA file: 
C:\Users\mesos\AppData\Local\Temp\aZKTiO\cert.pem
bject alternative name certificate extension.
I1205 01:11:19.922644  1180 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT 
implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1205 01:11:19.922644  1180 openssl.cpp:563] Using CA file: 
C:\Users\mesos\AppData\Local\Temp\2bQdjd\cert.pem
I1205 01:11:19.923641  1180 openssl.cpp:566] Using CA dir: 
C:\Users\mesos\AppData\Local\Temp\2bQdjd
I1205 01:11:20.453356  1180 openssl.cpp:509] CA directory path unspecified! 
NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=
I1205 01:11:20.453356  1180 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I1205 01:11:20.457684  1180 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT 
implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1205 01:11:20.457684  1180 openssl.cpp:563] Using CA file: 
C:\Users\mesos\AppData\Local\Temp\UStHYp\cert.pem
I1205 01:11:21.662744  1180 openssl.cpp:509] CA directory path unspecified! 
NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=
I1205 01:11:21.662744  1180 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I1205 01:11:21.662744  1180 openssl.cpp:526] Will use IP address verification 
in subject alternative name certificate extension.
I1205 01:11:21.662744  1180 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT 
implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1205 01:11:21.662744  1180 openssl.cpp:563] Using CA file: 
C:\Users\mesos\AppData\Local\Temp\aZKTiO\cert.pem
I1205 01:11:22.178691  3300 process.cpp:887] Failed to accept socket: future 
discarded
```

- Mesos Reviewbot Windows


On Dec. 4, 2017, 6:54 p.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64104/
>

Re: Review Request 64104: Added dependency of curl to agent. Enabled most health check tests.

2017-12-04 Thread John Kordich via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64104/
---

(Updated Dec. 4, 2017, 6:54 p.m.)


Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jeff Coffler, and 
Joseph Wu.


Changes
---

Rebased on master and addressed comments.


Bugs: MESOS-6709
https://issues.apache.org/jira/browse/MESOS-6709


Repository: mesos


Description
---

Added dependency of curl to agent. Enabled most health check tests.


Diffs (updated)
-

  src/slave/CMakeLists.txt 6f08f3dc95f3a1408cbef7b8f0b0cc2522558924 
  src/tests/health_check_tests.cpp 56721fac4a464f3cad40dbf4e6bc4fb7b1a780d4 


Diff: https://reviews.apache.org/r/64104/diff/2/

Changes: https://reviews.apache.org/r/64104/diff/1-2/


Testing
---

There are two health check tests which are not enabled yet, because they 
require the IOSwitchboard to be ported first. We can't resolve MESOS-6709 quite 
yet until that is addressed. The rest of the tests pass on both Linux/Windows, 
as mentioned in #64102


Thanks,

John Kordich

Re: Review Request 64104: Added dependency of curl to agent. Enabled most health check tests.

2017-12-04 Thread Andrew Schwartzmeyer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64104/#review192730
---




src/tests/health_check_tests.cpp
Lines 852-853 (original), 852-853 (patched)


Nit: join lines.



src/tests/health_check_tests.cpp
Lines 1396-1398 (original), 1396-1398 (patched)


Nit: remove now resolved TODO comment.



src/tests/health_check_tests.cpp
Lines 1489-1492 (original), 1489-1492 (patched)


Nit: ditto.



src/tests/health_check_tests.cpp
Lines 1947-1948 (original), 1947-1948 (patched)


Nit: join lines.



src/tests/health_check_tests.cpp
Lines 2224-2225 (original), 2224-2225 (patched)


Nit: join lines.


- Andrew Schwartzmeyer


On Nov. 30, 2017, 9:18 a.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64104/
> ---
> 
> (Updated Nov. 30, 2017, 9:18 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jeff Coffler, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-6709
> https://issues.apache.org/jira/browse/MESOS-6709
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added dependency of curl to agent. Enabled most health check tests.
> 
> 
> Diffs
> -
> 
>   src/slave/CMakeLists.txt 6f08f3dc95f3a1408cbef7b8f0b0cc2522558924 
>   src/tests/health_check_tests.cpp c0dcba265363f2149b217b189ee5a8e925e40ea1 
> 
> 
> Diff: https://reviews.apache.org/r/64104/diff/1/
> 
> 
> Testing
> ---
> 
> There are two health check tests which are not enabled yet, because they 
> require the IOSwitchboard to be ported first. We can't resolve MESOS-6709 
> quite yet until that is addressed. The rest of the tests pass on both 
> Linux/Windows, as mentioned in #64102
> 
> 
> Thanks,
> 
> John Kordich
> 
>

Re: Review Request 64104: Added dependency of curl to agent. Enabled most health check tests.

2017-12-01 Thread Andrew Schwartzmeyer 


> On Nov. 30, 2017, 6:04 p.m., Andrew Schwartzmeyer wrote:
> > src/tests/health_check_tests.cpp
> > Lines 2491-2492 (original), 2491-2492 (patched)
> > 
> >
> > This seems like it would be broken on other platforms if Docker isn't 
> > installed. I'll ping Jie and Joe and see if there's an existing issue.
> 
> Akash Gupta wrote:
> I don't think the DOCKER part is needed. It calls 
> `MesosContainerizer::create` to run a docker image (so universal container 
> mode), so there shouldn't be a dependency on docker.

Ah you're right! It uses a Docker image but explicitly does not use Docker 
(cause who wants Docker anyway?).


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64104/#review192433
---


On Nov. 30, 2017, 9:18 a.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64104/
> ---
> 
> (Updated Nov. 30, 2017, 9:18 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jeff Coffler, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-6709
> https://issues.apache.org/jira/browse/MESOS-6709
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added dependency of curl to agent. Enabled most health check tests.
> 
> 
> Diffs
> -
> 
>   src/slave/CMakeLists.txt 6f08f3dc95f3a1408cbef7b8f0b0cc2522558924 
>   src/tests/health_check_tests.cpp c0dcba265363f2149b217b189ee5a8e925e40ea1 
> 
> 
> Diff: https://reviews.apache.org/r/64104/diff/1/
> 
> 
> Testing
> ---
> 
> There are two health check tests which are not enabled yet, because they 
> require the IOSwitchboard to be ported first. We can't resolve MESOS-6709 
> quite yet until that is addressed. The rest of the tests pass on both 
> Linux/Windows, as mentioned in #64102
> 
> 
> Thanks,
> 
> John Kordich
> 
>

Re: Review Request 64104: Added dependency of curl to agent. Enabled most health check tests.

2017-12-01 Thread Akash Gupta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64104/#review192559
---




src/tests/health_check_tests.cpp
Line 565 (original), 565 (patched)


The docker tests should be disabled for now since they don't work. For 
example, this tests tries running the `alpine` image on Windows. I'm working on 
enabling the docker health checks on Windows.



src/tests/health_check_tests.cpp
Line 2492 (original), 2492 (patched)


Should remove the `DOCKER_` since it uses the mesos containerizer.


- Akash Gupta


On Nov. 30, 2017, 5:18 p.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64104/
> ---
> 
> (Updated Nov. 30, 2017, 5:18 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jeff Coffler, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-6709
> https://issues.apache.org/jira/browse/MESOS-6709
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added dependency of curl to agent. Enabled most health check tests.
> 
> 
> Diffs
> -
> 
>   src/slave/CMakeLists.txt 6f08f3dc95f3a1408cbef7b8f0b0cc2522558924 
>   src/tests/health_check_tests.cpp c0dcba265363f2149b217b189ee5a8e925e40ea1 
> 
> 
> Diff: https://reviews.apache.org/r/64104/diff/1/
> 
> 
> Testing
> ---
> 
> There are two health check tests which are not enabled yet, because they 
> require the IOSwitchboard to be ported first. We can't resolve MESOS-6709 
> quite yet until that is addressed. The rest of the tests pass on both 
> Linux/Windows, as mentioned in #64102
> 
> 
> Thanks,
> 
> John Kordich
> 
>

Re: Review Request 64104: Added dependency of curl to agent. Enabled most health check tests.

2017-12-01 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64104/#review192485
---



FAIL: Failed to apply the current review.

Failed command: `python.exe .\support\apply-reviews.py -n -r 64104`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64104

Relevant logs:

- 
[apply-review-64104-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64104/logs/apply-review-64104-stdout.log):

```
error: patch failed: src/tests/health_check_tests.cpp:1944
error: src/tests/health_check_tests.cpp: patch does not apply
```

- Mesos Reviewbot Windows


On Nov. 30, 2017, 12:18 p.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64104/
> ---
> 
> (Updated Nov. 30, 2017, 12:18 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jeff Coffler, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-6709
> https://issues.apache.org/jira/browse/MESOS-6709
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added dependency of curl to agent. Enabled most health check tests.
> 
> 
> Diffs
> -
> 
>   src/slave/CMakeLists.txt 6f08f3dc95f3a1408cbef7b8f0b0cc2522558924 
>   src/tests/health_check_tests.cpp c0dcba265363f2149b217b189ee5a8e925e40ea1 
> 
> 
> Diff: https://reviews.apache.org/r/64104/diff/1/
> 
> 
> Testing
> ---
> 
> There are two health check tests which are not enabled yet, because they 
> require the IOSwitchboard to be ported first. We can't resolve MESOS-6709 
> quite yet until that is addressed. The rest of the tests pass on both 
> Linux/Windows, as mentioned in #64102
> 
> 
> Thanks,
> 
> John Kordich
> 
>

Re: Review Request 64104: Added dependency of curl to agent. Enabled most health check tests.

2017-11-30 Thread Andrew Schwartzmeyer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64104/#review192433
---


Fix it, then Ship it!





src/slave/CMakeLists.txt
Lines 25-28 (patched)


This is going to conflict with https://reviews.apache.org/r/63342/, but 
I'll get it taken care of.



src/tests/health_check_tests.cpp
Lines 2491-2492 (original), 2491-2492 (patched)


This seems like it would be broken on other platforms if Docker isn't 
installed. I'll ping Jie and Joe and see if there's an existing issue.


- Andrew Schwartzmeyer


On Nov. 30, 2017, 9:18 a.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64104/
> ---
> 
> (Updated Nov. 30, 2017, 9:18 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jeff Coffler, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-6709
> https://issues.apache.org/jira/browse/MESOS-6709
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added dependency of curl to agent. Enabled most health check tests.
> 
> 
> Diffs
> -
> 
>   src/slave/CMakeLists.txt 6f08f3dc95f3a1408cbef7b8f0b0cc2522558924 
>   src/tests/health_check_tests.cpp c0dcba265363f2149b217b189ee5a8e925e40ea1 
> 
> 
> Diff: https://reviews.apache.org/r/64104/diff/1/
> 
> 
> Testing
> ---
> 
> There are two health check tests which are not enabled yet, because they 
> require the IOSwitchboard to be ported first. We can't resolve MESOS-6709 
> quite yet until that is addressed. The rest of the tests pass on both 
> Linux/Windows, as mentioned in #64102
> 
> 
> Thanks,
> 
> John Kordich
> 
>