Re: Review Request 64195: Updated the tests to use MULTI_ROLE frameworks by default.

2017-12-01 Thread Benjamin Mahler
> On Dec. 1, 2017, 1:16 a.m., Michael Park wrote: > > src/tests/slave_tests.cpp > > Line 860 (original), 860 (patched) > > > > > > Huh... so these used to be an empty string? These used to be `"*"` (the default for

Re: Review Request 64195: Updated the tests to use MULTI_ROLE frameworks by default.

2017-12-01 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64195/#review192484 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 64195: Updated the tests to use MULTI_ROLE frameworks by default.

2017-11-30 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64195/#review192421 --- Ship it! src/tests/persistent_volume_tests.cpp Line 150