Re: Review Request 64561: Removed resource categories in UpdateSlaveMessage.

2017-12-13 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64561/ --- (Updated Dec. 13, 2017, 7:34 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 64561: Removed resource categories in UpdateSlaveMessage.

2017-12-13 Thread Jie Yu
> On Dec. 13, 2017, 12:20 p.m., Benjamin Bannier wrote: > > src/slave/slave.cpp > > Line 6992 (original) > > > > > > One motivation for such helper functions can be that it becomes clearer > > than

Re: Review Request 64561: Removed resource categories in UpdateSlaveMessage.

2017-12-13 Thread Jie Yu
> On Dec. 13, 2017, 12:20 p.m., Benjamin Bannier wrote: > > src/master/master.hpp > > Line 502 (original), 502 (patched) > > > > > > Let's not do this in this patch as it is an unrelated change. Instead > > we

Re: Review Request 64561: Removed resource categories in UpdateSlaveMessage.

2017-12-13 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64561/#review193671 --- Fix it, then Ship it! This implements the same functionality

Re: Review Request 64561: Removed resource categories in UpdateSlaveMessage.

2017-12-12 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64561/#review193641 --- FAIL: Some Mesos tests failed. Reviews applied: `['64557',