Re: Review Request 64644: Refactored and fixed bugs for SLRP resource reconciliation.

2017-12-16 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64644/#review194010
---



PASS: Mesos patch 64644 was successfully built and tested.

Reviews applied: `['64621', '64591', '64644']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64644

- Mesos Reviewbot Windows


On Dec. 15, 2017, 8:21 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64644/
> ---
> 
> (Updated Dec. 15, 2017, 8:21 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Refactored and fixed bugs for SLRP resource reconciliation.
> 
> 
> Diffs
> -
> 
>   src/resource_provider/storage/provider.cpp 
> 158b6b408002209aa9a79a6772da30c984aad61a 
> 
> 
> Diff: https://reviews.apache.org/r/64644/diff/2/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 64644: Refactored and fixed bugs for SLRP resource reconciliation.

2017-12-15 Thread Chun-Hung Hsiao 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64644/
---

(Updated Dec. 15, 2017, 8:21 p.m.)


Review request for mesos, Jie Yu and Joseph Wu.


Changes
---

Addressed comments.


Repository: mesos


Description
---

Refactored and fixed bugs for SLRP resource reconciliation.


Diffs (updated)
-

  src/resource_provider/storage/provider.cpp 
158b6b408002209aa9a79a6772da30c984aad61a 


Diff: https://reviews.apache.org/r/64644/diff/2/

Changes: https://reviews.apache.org/r/64644/diff/1-2/


Testing
---

sudo make check


Thanks,

Chun-Hung Hsiao

Re: Review Request 64644: Refactored and fixed bugs for SLRP resource reconciliation.

2017-12-15 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64644/#review193968
---


Fix it, then Ship it!




Please also add some more comments about the recocile function


src/resource_provider/storage/provider.cpp
Lines 1048 (patched)


NOTE?


- Jie Yu


On Dec. 15, 2017, 10:06 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64644/
> ---
> 
> (Updated Dec. 15, 2017, 10:06 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Refactored and fixed bugs for SLRP resource reconciliation.
> 
> 
> Diffs
> -
> 
>   src/resource_provider/storage/provider.cpp 
> 17acf1b430b81e31bd97b117a44477eebab7e6f4 
> 
> 
> Diff: https://reviews.apache.org/r/64644/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 64644: Refactored and fixed bugs for SLRP resource reconciliation.

2017-12-15 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64644/#review193967
---




src/resource_provider/storage/provider.cpp
Lines 1072 (patched)


hum, should be `!checkpointed.contains(uncoverted)`


- Jie Yu


On Dec. 15, 2017, 10:06 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64644/
> ---
> 
> (Updated Dec. 15, 2017, 10:06 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Refactored and fixed bugs for SLRP resource reconciliation.
> 
> 
> Diffs
> -
> 
>   src/resource_provider/storage/provider.cpp 
> 17acf1b430b81e31bd97b117a44477eebab7e6f4 
> 
> 
> Diff: https://reviews.apache.org/r/64644/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>