Re: Review Request 64970: Use tox for linting and testing code living uder src/python.

2018-05-09 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64970/#review202749 --- support/mesos-style.py Lines 379 (patched)

Re: Review Request 64970: Use tox for linting and testing code living uder src/python.

2018-04-12 Thread Eric Chung
> On April 6, 2018, 9:46 a.m., Armand Grillet wrote: > > src/python/lib/tox.ini > > Lines 19 (patched) > > > > > > As this is here, the line `pylint==1.6.4` in > > support/pip-requirements.txt should be removed.

Re: Review Request 64970: Use tox for linting and testing code living uder src/python.

2018-04-06 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64970/#review200634 --- Fix it, then Ship it! src/python/lib/tox.ini Lines 19

Re: Review Request 64970: Use tox for linting and testing code living uder src/python.

2018-03-15 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64970/#review199255 --- Patch looks great! Reviews applied: [64970] Passed command:

Re: Review Request 64970: Use tox for linting and testing code living uder src/python.

2018-03-14 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64970/#review199174 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 64970: Use tox for linting and testing code living uder src/python.

2018-03-14 Thread Eric Chung
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64970/ --- (Updated March 14, 2018, 3:05 p.m.) Review request for mesos, Armand Grillet,

Re: Review Request 64970: Use tox for linting and testing code living uder src/python.

2018-03-14 Thread Eric Chung
> On March 1, 2018, 11:20 p.m., Kevin Klues wrote: > > support/mesos-style.py > > Lines 413-414 (patched) > > > > > > This could probably be one line. ``` * Module mesos-style C:409, 0: Line too long

Re: Review Request 64970: Use tox for linting and testing code living uder src/python.

2018-03-14 Thread Eric Chung
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64970/ --- (Updated March 14, 2018, 3:02 p.m.) Review request for mesos, Armand Grillet,

Re: Review Request 64970: Use tox for linting and testing code living uder src/python.

2018-03-01 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64970/#review198478 --- src/python/cli_new/tox.ini Lines 1-22 (patched)

Re: Review Request 64970: Use tox for linting and testing code living uder src/python.

2018-03-01 Thread Eric Chung
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64970/ --- (Updated March 1, 2018, 10:34 p.m.) Review request for mesos, Armand Grillet,

Re: Review Request 64970: Use tox for linting and testing code living uder src/python.

2018-02-02 Thread Eric Chung
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64970/#review196716 --- src/python/cli_new/tox.ini Lines 21 (patched)

Re: Review Request 64970: Use tox for linting and testing code living uder src/python.

2018-01-18 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64970/#review195757 --- PASS: Mesos patch 64970 was successfully built and tested.