Re: Review Request 65160: Removed some redundant `get` calls in stout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65160/ --- (Updated Feb. 21, 2018, 2:31 p.m.) Review request for mesos, Andrew Schwartzmeyer and Michael Park. Repository: mesos Description --- Removed some redundant `get` calls in stout. Diffs - 3rdparty/stout/include/stout/flags/flags.hpp 4de093d675b094a438e38ecbc867837f7cbc5f7c 3rdparty/stout/include/stout/ip.hpp b4abcb963d3ac9ef4a3bda935225d5d2e52f5fd0 3rdparty/stout/include/stout/json.hpp 7484f4aab0025a1b6e5d51484f92b0aef96fe433 3rdparty/stout/include/stout/os.hpp c366ad03bbf9a850551fd824680a4afffc77782a 3rdparty/stout/include/stout/os/linux.hpp 50352c947d63e9babff948d90d1b7b9303d03d77 3rdparty/stout/include/stout/os/osx.hpp 504af3e650ab680d65107448b302ca7cf99e9ad6 3rdparty/stout/include/stout/os/posix/bootid.hpp 7ea5e4631b14c48455af7c9feec98bcb4ae79d75 3rdparty/stout/include/stout/os/posix/fork.hpp a29967dcb32c112793adb60693cfef808a52b63d 3rdparty/stout/include/stout/os/posix/killtree.hpp 9f18a48b94ddcbc4b3881ff4ab94c777bb10028d 3rdparty/stout/include/stout/os/posix/shell.hpp 175de46a10fb8ab2a3c14d3b70ce73de042e6387 3rdparty/stout/include/stout/os/posix/which.hpp 96586ddebdcdbc8a84fc5317828a474796d582ed 3rdparty/stout/include/stout/os/pstree.hpp fe382a19f510d10479a2f4bc8c7d0daff8ef7b36 3rdparty/stout/include/stout/posix/os.hpp dfee0faa084932bf60c93c7aae63665225cd4ab1 3rdparty/stout/include/stout/protobuf.hpp 7f8ed34b7ecd10bb0d69e17c74a0272f0bdbbafc 3rdparty/stout/include/stout/result.hpp 1bf353b76b064d5901624097cfa18aa9aab05909 3rdparty/stout/include/stout/try.hpp 90f8aed56ce5d77e70af9e516faad152083d1488 3rdparty/stout/tests/ip_tests.cpp a38e93c630bc4cbd337d8712a0edadc607382f22 3rdparty/stout/tests/os/filesystem_tests.cpp 2204d104a5739086a8fdf6fe21032d0d12c980ad 3rdparty/stout/tests/os/process_tests.cpp cbae66cdb96ee5f20fc33e4f8ca2bbeeec227b00 3rdparty/stout/tests/os/systems_tests.cpp 44a922108b6f45ff3bd7ec08a86da6e50c43e469 3rdparty/stout/tests/os_tests.cpp 11f17206688e09e86706d2d57d029f1c29d35e0d 3rdparty/stout/tests/proc_tests.cpp b0e3720ae199507405b66e3e9286619f84667a83 3rdparty/stout/tests/some_tests.cpp 685873505b68099039387e63c6faf49f3e4db4e6 Diff: https://reviews.apache.org/r/65160/diff/3/ Testing (updated) --- * `make check` * tested on a number of platforms and configurations on internal CI These changes were made automatically with https://github.com/mesos/clang-tools-extra/pull/13 with only a few minor additions in surrounding code. Thanks, Benjamin Bannier
Re: Review Request 65160: Removed some redundant `get` calls in stout.
> On Feb. 12, 2018, 8:12 p.m., Andrew Schwartzmeyer wrote: > > I noticed that this didn't apply the automated reviewer to any Windows-only > > files. On the one hand, I have clean-up patches in progress that would be > > no fun to rebase afterward, on the other hand, why were those files > > ignored? Was it on purpose, or could I apply the same tools on Windows to > > automatically clean up that portion of the code base too? These changes where generated automatically by a linter running on the AST seen by the compiler (https://github.com/mesos/clang-tools-extra/pull/13). This does require a compiler setup visiting all files with e.g., proper compiler switches. I was able to run this for some configurations on Linux and macos, but did not attempt this for a Windows configuration. - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65160/#review197291 --- On Feb. 12, 2018, 3:07 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65160/ > --- > > (Updated Feb. 12, 2018, 3:07 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Michael Park. > > > Repository: mesos > > > Description > --- > > Removed some redundant `get` calls in stout. > > > Diffs > - > > 3rdparty/stout/include/stout/flags/flags.hpp > 4de093d675b094a438e38ecbc867837f7cbc5f7c > 3rdparty/stout/include/stout/ip.hpp > b4abcb963d3ac9ef4a3bda935225d5d2e52f5fd0 > 3rdparty/stout/include/stout/json.hpp > 7484f4aab0025a1b6e5d51484f92b0aef96fe433 > 3rdparty/stout/include/stout/os.hpp > c366ad03bbf9a850551fd824680a4afffc77782a > 3rdparty/stout/include/stout/os/linux.hpp > 50352c947d63e9babff948d90d1b7b9303d03d77 > 3rdparty/stout/include/stout/os/osx.hpp > 504af3e650ab680d65107448b302ca7cf99e9ad6 > 3rdparty/stout/include/stout/os/posix/bootid.hpp > 7ea5e4631b14c48455af7c9feec98bcb4ae79d75 > 3rdparty/stout/include/stout/os/posix/fork.hpp > a29967dcb32c112793adb60693cfef808a52b63d > 3rdparty/stout/include/stout/os/posix/killtree.hpp > 9f18a48b94ddcbc4b3881ff4ab94c777bb10028d > 3rdparty/stout/include/stout/os/posix/shell.hpp > 175de46a10fb8ab2a3c14d3b70ce73de042e6387 > 3rdparty/stout/include/stout/os/posix/which.hpp > 96586ddebdcdbc8a84fc5317828a474796d582ed > 3rdparty/stout/include/stout/os/pstree.hpp > fe382a19f510d10479a2f4bc8c7d0daff8ef7b36 > 3rdparty/stout/include/stout/posix/os.hpp > dfee0faa084932bf60c93c7aae63665225cd4ab1 > 3rdparty/stout/include/stout/protobuf.hpp > 7f8ed34b7ecd10bb0d69e17c74a0272f0bdbbafc > 3rdparty/stout/include/stout/result.hpp > 1bf353b76b064d5901624097cfa18aa9aab05909 > 3rdparty/stout/include/stout/try.hpp > 90f8aed56ce5d77e70af9e516faad152083d1488 > 3rdparty/stout/tests/ip_tests.cpp a38e93c630bc4cbd337d8712a0edadc607382f22 > 3rdparty/stout/tests/os/filesystem_tests.cpp > 2204d104a5739086a8fdf6fe21032d0d12c980ad > 3rdparty/stout/tests/os/process_tests.cpp > cbae66cdb96ee5f20fc33e4f8ca2bbeeec227b00 > 3rdparty/stout/tests/os/systems_tests.cpp > 44a922108b6f45ff3bd7ec08a86da6e50c43e469 > 3rdparty/stout/tests/os_tests.cpp 11f17206688e09e86706d2d57d029f1c29d35e0d > 3rdparty/stout/tests/proc_tests.cpp > b0e3720ae199507405b66e3e9286619f84667a83 > 3rdparty/stout/tests/some_tests.cpp > 685873505b68099039387e63c6faf49f3e4db4e6 > > > Diff: https://reviews.apache.org/r/65160/diff/3/ > > > Testing > --- > > `make check` > > These changes were made automatically with > https://github.com/mesos/clang-tools-extra/pull/13 with only a few minor > additions in surrounding code. > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 65160: Removed some redundant `get` calls in stout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65160/#review197291 --- Ship it! I noticed that this didn't apply the automated reviewer to any Windows-only files. On the one hand, I have clean-up patches in progress that would be no fun to rebase afterward, on the other hand, why were those files ignored? Was it on purpose, or could I apply the same tools on Windows to automatically clean up that portion of the code base too? - Andrew Schwartzmeyer On Feb. 12, 2018, 6:07 a.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65160/ > --- > > (Updated Feb. 12, 2018, 6:07 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Michael Park. > > > Repository: mesos > > > Description > --- > > Removed some redundant `get` calls in stout. > > > Diffs > - > > 3rdparty/stout/include/stout/flags/flags.hpp > 4de093d675b094a438e38ecbc867837f7cbc5f7c > 3rdparty/stout/include/stout/ip.hpp > b4abcb963d3ac9ef4a3bda935225d5d2e52f5fd0 > 3rdparty/stout/include/stout/json.hpp > 7484f4aab0025a1b6e5d51484f92b0aef96fe433 > 3rdparty/stout/include/stout/os.hpp > c366ad03bbf9a850551fd824680a4afffc77782a > 3rdparty/stout/include/stout/os/linux.hpp > 50352c947d63e9babff948d90d1b7b9303d03d77 > 3rdparty/stout/include/stout/os/osx.hpp > 504af3e650ab680d65107448b302ca7cf99e9ad6 > 3rdparty/stout/include/stout/os/posix/bootid.hpp > 7ea5e4631b14c48455af7c9feec98bcb4ae79d75 > 3rdparty/stout/include/stout/os/posix/fork.hpp > a29967dcb32c112793adb60693cfef808a52b63d > 3rdparty/stout/include/stout/os/posix/killtree.hpp > 9f18a48b94ddcbc4b3881ff4ab94c777bb10028d > 3rdparty/stout/include/stout/os/posix/shell.hpp > 175de46a10fb8ab2a3c14d3b70ce73de042e6387 > 3rdparty/stout/include/stout/os/posix/which.hpp > 96586ddebdcdbc8a84fc5317828a474796d582ed > 3rdparty/stout/include/stout/os/pstree.hpp > fe382a19f510d10479a2f4bc8c7d0daff8ef7b36 > 3rdparty/stout/include/stout/posix/os.hpp > dfee0faa084932bf60c93c7aae63665225cd4ab1 > 3rdparty/stout/include/stout/protobuf.hpp > 7f8ed34b7ecd10bb0d69e17c74a0272f0bdbbafc > 3rdparty/stout/include/stout/result.hpp > 1bf353b76b064d5901624097cfa18aa9aab05909 > 3rdparty/stout/include/stout/try.hpp > 90f8aed56ce5d77e70af9e516faad152083d1488 > 3rdparty/stout/tests/ip_tests.cpp a38e93c630bc4cbd337d8712a0edadc607382f22 > 3rdparty/stout/tests/os/filesystem_tests.cpp > 2204d104a5739086a8fdf6fe21032d0d12c980ad > 3rdparty/stout/tests/os/process_tests.cpp > cbae66cdb96ee5f20fc33e4f8ca2bbeeec227b00 > 3rdparty/stout/tests/os/systems_tests.cpp > 44a922108b6f45ff3bd7ec08a86da6e50c43e469 > 3rdparty/stout/tests/os_tests.cpp 11f17206688e09e86706d2d57d029f1c29d35e0d > 3rdparty/stout/tests/proc_tests.cpp > b0e3720ae199507405b66e3e9286619f84667a83 > 3rdparty/stout/tests/some_tests.cpp > 685873505b68099039387e63c6faf49f3e4db4e6 > > > Diff: https://reviews.apache.org/r/65160/diff/3/ > > > Testing > --- > > `make check` > > These changes were made automatically with > https://github.com/mesos/clang-tools-extra/pull/13 with only a few minor > additions in surrounding code. > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 65160: Removed some redundant `get` calls in stout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65160/ --- (Updated Feb. 12, 2018, 3:07 p.m.) Review request for mesos, Andrew Schwartzmeyer and Michael Park. Changes --- Rebased. Repository: mesos Description --- Removed some redundant `get` calls in stout. Diffs (updated) - 3rdparty/stout/include/stout/flags/flags.hpp 4de093d675b094a438e38ecbc867837f7cbc5f7c 3rdparty/stout/include/stout/ip.hpp b4abcb963d3ac9ef4a3bda935225d5d2e52f5fd0 3rdparty/stout/include/stout/json.hpp 7484f4aab0025a1b6e5d51484f92b0aef96fe433 3rdparty/stout/include/stout/os.hpp c366ad03bbf9a850551fd824680a4afffc77782a 3rdparty/stout/include/stout/os/linux.hpp 50352c947d63e9babff948d90d1b7b9303d03d77 3rdparty/stout/include/stout/os/osx.hpp 504af3e650ab680d65107448b302ca7cf99e9ad6 3rdparty/stout/include/stout/os/posix/bootid.hpp 7ea5e4631b14c48455af7c9feec98bcb4ae79d75 3rdparty/stout/include/stout/os/posix/fork.hpp a29967dcb32c112793adb60693cfef808a52b63d 3rdparty/stout/include/stout/os/posix/killtree.hpp 9f18a48b94ddcbc4b3881ff4ab94c777bb10028d 3rdparty/stout/include/stout/os/posix/shell.hpp 175de46a10fb8ab2a3c14d3b70ce73de042e6387 3rdparty/stout/include/stout/os/posix/which.hpp 96586ddebdcdbc8a84fc5317828a474796d582ed 3rdparty/stout/include/stout/os/pstree.hpp fe382a19f510d10479a2f4bc8c7d0daff8ef7b36 3rdparty/stout/include/stout/posix/os.hpp dfee0faa084932bf60c93c7aae63665225cd4ab1 3rdparty/stout/include/stout/protobuf.hpp 7f8ed34b7ecd10bb0d69e17c74a0272f0bdbbafc 3rdparty/stout/include/stout/result.hpp 1bf353b76b064d5901624097cfa18aa9aab05909 3rdparty/stout/include/stout/try.hpp 90f8aed56ce5d77e70af9e516faad152083d1488 3rdparty/stout/tests/ip_tests.cpp a38e93c630bc4cbd337d8712a0edadc607382f22 3rdparty/stout/tests/os/filesystem_tests.cpp 2204d104a5739086a8fdf6fe21032d0d12c980ad 3rdparty/stout/tests/os/process_tests.cpp cbae66cdb96ee5f20fc33e4f8ca2bbeeec227b00 3rdparty/stout/tests/os/systems_tests.cpp 44a922108b6f45ff3bd7ec08a86da6e50c43e469 3rdparty/stout/tests/os_tests.cpp 11f17206688e09e86706d2d57d029f1c29d35e0d 3rdparty/stout/tests/proc_tests.cpp b0e3720ae199507405b66e3e9286619f84667a83 3rdparty/stout/tests/some_tests.cpp 685873505b68099039387e63c6faf49f3e4db4e6 Diff: https://reviews.apache.org/r/65160/diff/3/ Changes: https://reviews.apache.org/r/65160/diff/2-3/ Testing --- `make check` These changes were made automatically with https://github.com/mesos/clang-tools-extra/pull/13 with only a few minor additions in surrounding code. Thanks, Benjamin Bannier
