Re: Review Request 65161: Removed some redundant `get` calls in libprocess.

2018-02-21 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65161/
---

(Updated Feb. 21, 2018, 2:31 p.m.)


Review request for mesos, Andrew Schwartzmeyer and Michael Park.


Repository: mesos


Description
---

Removed some redundant `get` calls in libprocess.


Diffs
-

  3rdparty/libprocess/include/process/gmock.hpp 
231efcd989b829b5cfba8e5d69ca5cb2c4bf0428 
  3rdparty/libprocess/include/process/gtest.hpp 
eee726653d52af2e4a148819e420ebd22e5123a9 
  3rdparty/libprocess/include/process/system.hpp 
21bd3300b104eaa56642f19c3dcb95950ab94830 
  3rdparty/libprocess/src/http.cpp 76a65e02fd83219b198d0b8fde3f8208e1c606b5 
  3rdparty/libprocess/src/http_proxy.cpp 
f584238aadd86875d7c87736653f394e716397de 
  3rdparty/libprocess/src/metrics/metrics.cpp 
f79541853b4c826014ee969633345c3d51520ecf 
  3rdparty/libprocess/src/openssl.cpp f2fe90bfdf87dbc674b231f6392e95a95ebd9736 
  3rdparty/libprocess/src/process.cpp 42e7adf740b234ebf23d2dcb71440749c0ed87ec 
  3rdparty/libprocess/src/ssl/utilities.cpp 
9b1d6229c3aa7d7045d492d377223d56bca16156 
  3rdparty/libprocess/src/subprocess_posix.hpp 
25eb44ab7f68907c30008ae729403a986cb1898a 
  3rdparty/libprocess/src/tests/benchmarks.cpp 
48b5f5cf38d8fb4d77025f9723031075ca8ab677 
  3rdparty/libprocess/src/tests/collect_tests.cpp 
7c2ba902d2fba340a5fae49a911a9e84223fe1ce 
  3rdparty/libprocess/src/tests/future_tests.cpp 
bd98154cfa2020b7423951f070fca7b0447d3cd5 
  3rdparty/libprocess/src/tests/http_tests.cpp 
a60f6b132aff00da42e733f5c5f387dff2428ed2 
  3rdparty/libprocess/src/tests/metrics_tests.cpp 
5a5a2e581d0917ad5aa6aa93257ec0dddc895725 
  3rdparty/libprocess/src/tests/process_tests.cpp 
96b1675dea7df675667c61ff2bd1d1cc8231a457 
  3rdparty/libprocess/src/tests/reap_tests.cpp 
f8a8593b685c5e5a9321d970a57e9ebdff127c24 
  3rdparty/libprocess/src/tests/ssl_tests.cpp 
71f2df8cd2377ae1be762ec7a0fb0d2f7b210e4b 
  3rdparty/libprocess/src/tests/statistics_tests.cpp 
144b5109cfb7640b29bec8de8f5b2ad00665212f 
  3rdparty/libprocess/src/tests/subprocess_tests.cpp 
8211ae63e75359705af2bb9ac02a7cbdb28e3252 
  3rdparty/libprocess/src/tests/system_tests.cpp 
6beb973e079c00ba3e632d6fb6c3c332483d203f 
  3rdparty/libprocess/src/tests/timeseries_tests.cpp 
4177fb673bbf510fe835af396cd76dae48a9ec85 


Diff: https://reviews.apache.org/r/65161/diff/2/


Testing (updated)
---

* `make check`
* tested on a number of platforms and configurations on internal CI

These changes were made automatically with 
https://github.com/mesos/clang-tools-extra/pull/13 with only a few minor 
additions in surrounding code.


Thanks,

Benjamin Bannier

Re: Review Request 65161: Removed some redundant `get` calls in libprocess.

2018-02-13 Thread Benjamin Bannier 


> On Feb. 12, 2018, 8:09 p.m., Andrew Schwartzmeyer wrote:
> > 3rdparty/libprocess/include/process/gtest.hpp
> > Lines 429-430 (original), 429-430 (patched)
> > 
> >
> > Ha! It's funny it caught the one in the string.

Sadly we still needed a human to look at the change on l.430 and make the 
change on l.429.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65161/#review197290
---


On Feb. 12, 2018, 3:07 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65161/
> ---
> 
> (Updated Feb. 12, 2018, 3:07 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed some redundant `get` calls in libprocess.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/gmock.hpp 
> 231efcd989b829b5cfba8e5d69ca5cb2c4bf0428 
>   3rdparty/libprocess/include/process/gtest.hpp 
> eee726653d52af2e4a148819e420ebd22e5123a9 
>   3rdparty/libprocess/include/process/system.hpp 
> 21bd3300b104eaa56642f19c3dcb95950ab94830 
>   3rdparty/libprocess/src/http.cpp 76a65e02fd83219b198d0b8fde3f8208e1c606b5 
>   3rdparty/libprocess/src/http_proxy.cpp 
> f584238aadd86875d7c87736653f394e716397de 
>   3rdparty/libprocess/src/metrics/metrics.cpp 
> f79541853b4c826014ee969633345c3d51520ecf 
>   3rdparty/libprocess/src/openssl.cpp 
> f2fe90bfdf87dbc674b231f6392e95a95ebd9736 
>   3rdparty/libprocess/src/process.cpp 
> 42e7adf740b234ebf23d2dcb71440749c0ed87ec 
>   3rdparty/libprocess/src/ssl/utilities.cpp 
> 9b1d6229c3aa7d7045d492d377223d56bca16156 
>   3rdparty/libprocess/src/subprocess_posix.hpp 
> 25eb44ab7f68907c30008ae729403a986cb1898a 
>   3rdparty/libprocess/src/tests/benchmarks.cpp 
> 48b5f5cf38d8fb4d77025f9723031075ca8ab677 
>   3rdparty/libprocess/src/tests/collect_tests.cpp 
> 7c2ba902d2fba340a5fae49a911a9e84223fe1ce 
>   3rdparty/libprocess/src/tests/future_tests.cpp 
> bd98154cfa2020b7423951f070fca7b0447d3cd5 
>   3rdparty/libprocess/src/tests/http_tests.cpp 
> a60f6b132aff00da42e733f5c5f387dff2428ed2 
>   3rdparty/libprocess/src/tests/metrics_tests.cpp 
> 5a5a2e581d0917ad5aa6aa93257ec0dddc895725 
>   3rdparty/libprocess/src/tests/process_tests.cpp 
> 96b1675dea7df675667c61ff2bd1d1cc8231a457 
>   3rdparty/libprocess/src/tests/reap_tests.cpp 
> f8a8593b685c5e5a9321d970a57e9ebdff127c24 
>   3rdparty/libprocess/src/tests/ssl_tests.cpp 
> 71f2df8cd2377ae1be762ec7a0fb0d2f7b210e4b 
>   3rdparty/libprocess/src/tests/statistics_tests.cpp 
> 144b5109cfb7640b29bec8de8f5b2ad00665212f 
>   3rdparty/libprocess/src/tests/subprocess_tests.cpp 
> 8211ae63e75359705af2bb9ac02a7cbdb28e3252 
>   3rdparty/libprocess/src/tests/system_tests.cpp 
> 6beb973e079c00ba3e632d6fb6c3c332483d203f 
>   3rdparty/libprocess/src/tests/timeseries_tests.cpp 
> 4177fb673bbf510fe835af396cd76dae48a9ec85 
> 
> 
> Diff: https://reviews.apache.org/r/65161/diff/2/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> These changes were made automatically with 
> https://github.com/mesos/clang-tools-extra/pull/13 with only a few minor 
> additions in surrounding code.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 65161: Removed some redundant `get` calls in libprocess.

2018-02-12 Thread Andrew Schwartzmeyer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65161/#review197290
---


Ship it!





3rdparty/libprocess/include/process/gtest.hpp
Lines 429-430 (original), 429-430 (patched)


Ha! It's funny it caught the one in the string.


- Andrew Schwartzmeyer


On Feb. 12, 2018, 6:07 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65161/
> ---
> 
> (Updated Feb. 12, 2018, 6:07 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed some redundant `get` calls in libprocess.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/gmock.hpp 
> 231efcd989b829b5cfba8e5d69ca5cb2c4bf0428 
>   3rdparty/libprocess/include/process/gtest.hpp 
> eee726653d52af2e4a148819e420ebd22e5123a9 
>   3rdparty/libprocess/include/process/system.hpp 
> 21bd3300b104eaa56642f19c3dcb95950ab94830 
>   3rdparty/libprocess/src/http.cpp 76a65e02fd83219b198d0b8fde3f8208e1c606b5 
>   3rdparty/libprocess/src/http_proxy.cpp 
> f584238aadd86875d7c87736653f394e716397de 
>   3rdparty/libprocess/src/metrics/metrics.cpp 
> f79541853b4c826014ee969633345c3d51520ecf 
>   3rdparty/libprocess/src/openssl.cpp 
> f2fe90bfdf87dbc674b231f6392e95a95ebd9736 
>   3rdparty/libprocess/src/process.cpp 
> 42e7adf740b234ebf23d2dcb71440749c0ed87ec 
>   3rdparty/libprocess/src/ssl/utilities.cpp 
> 9b1d6229c3aa7d7045d492d377223d56bca16156 
>   3rdparty/libprocess/src/subprocess_posix.hpp 
> 25eb44ab7f68907c30008ae729403a986cb1898a 
>   3rdparty/libprocess/src/tests/benchmarks.cpp 
> 48b5f5cf38d8fb4d77025f9723031075ca8ab677 
>   3rdparty/libprocess/src/tests/collect_tests.cpp 
> 7c2ba902d2fba340a5fae49a911a9e84223fe1ce 
>   3rdparty/libprocess/src/tests/future_tests.cpp 
> bd98154cfa2020b7423951f070fca7b0447d3cd5 
>   3rdparty/libprocess/src/tests/http_tests.cpp 
> a60f6b132aff00da42e733f5c5f387dff2428ed2 
>   3rdparty/libprocess/src/tests/metrics_tests.cpp 
> 5a5a2e581d0917ad5aa6aa93257ec0dddc895725 
>   3rdparty/libprocess/src/tests/process_tests.cpp 
> 96b1675dea7df675667c61ff2bd1d1cc8231a457 
>   3rdparty/libprocess/src/tests/reap_tests.cpp 
> f8a8593b685c5e5a9321d970a57e9ebdff127c24 
>   3rdparty/libprocess/src/tests/ssl_tests.cpp 
> 71f2df8cd2377ae1be762ec7a0fb0d2f7b210e4b 
>   3rdparty/libprocess/src/tests/statistics_tests.cpp 
> 144b5109cfb7640b29bec8de8f5b2ad00665212f 
>   3rdparty/libprocess/src/tests/subprocess_tests.cpp 
> 8211ae63e75359705af2bb9ac02a7cbdb28e3252 
>   3rdparty/libprocess/src/tests/system_tests.cpp 
> 6beb973e079c00ba3e632d6fb6c3c332483d203f 
>   3rdparty/libprocess/src/tests/timeseries_tests.cpp 
> 4177fb673bbf510fe835af396cd76dae48a9ec85 
> 
> 
> Diff: https://reviews.apache.org/r/65161/diff/2/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> These changes were made automatically with 
> https://github.com/mesos/clang-tools-extra/pull/13 with only a few minor 
> additions in surrounding code.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 65161: Removed some redundant `get` calls in libprocess.

2018-02-12 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65161/
---

(Updated Feb. 12, 2018, 3:07 p.m.)


Review request for mesos, Andrew Schwartzmeyer and Michael Park.


Changes
---

Rebased.


Repository: mesos


Description
---

Removed some redundant `get` calls in libprocess.


Diffs (updated)
-

  3rdparty/libprocess/include/process/gmock.hpp 
231efcd989b829b5cfba8e5d69ca5cb2c4bf0428 
  3rdparty/libprocess/include/process/gtest.hpp 
eee726653d52af2e4a148819e420ebd22e5123a9 
  3rdparty/libprocess/include/process/system.hpp 
21bd3300b104eaa56642f19c3dcb95950ab94830 
  3rdparty/libprocess/src/http.cpp 76a65e02fd83219b198d0b8fde3f8208e1c606b5 
  3rdparty/libprocess/src/http_proxy.cpp 
f584238aadd86875d7c87736653f394e716397de 
  3rdparty/libprocess/src/metrics/metrics.cpp 
f79541853b4c826014ee969633345c3d51520ecf 
  3rdparty/libprocess/src/openssl.cpp f2fe90bfdf87dbc674b231f6392e95a95ebd9736 
  3rdparty/libprocess/src/process.cpp 42e7adf740b234ebf23d2dcb71440749c0ed87ec 
  3rdparty/libprocess/src/ssl/utilities.cpp 
9b1d6229c3aa7d7045d492d377223d56bca16156 
  3rdparty/libprocess/src/subprocess_posix.hpp 
25eb44ab7f68907c30008ae729403a986cb1898a 
  3rdparty/libprocess/src/tests/benchmarks.cpp 
48b5f5cf38d8fb4d77025f9723031075ca8ab677 
  3rdparty/libprocess/src/tests/collect_tests.cpp 
7c2ba902d2fba340a5fae49a911a9e84223fe1ce 
  3rdparty/libprocess/src/tests/future_tests.cpp 
bd98154cfa2020b7423951f070fca7b0447d3cd5 
  3rdparty/libprocess/src/tests/http_tests.cpp 
a60f6b132aff00da42e733f5c5f387dff2428ed2 
  3rdparty/libprocess/src/tests/metrics_tests.cpp 
5a5a2e581d0917ad5aa6aa93257ec0dddc895725 
  3rdparty/libprocess/src/tests/process_tests.cpp 
96b1675dea7df675667c61ff2bd1d1cc8231a457 
  3rdparty/libprocess/src/tests/reap_tests.cpp 
f8a8593b685c5e5a9321d970a57e9ebdff127c24 
  3rdparty/libprocess/src/tests/ssl_tests.cpp 
71f2df8cd2377ae1be762ec7a0fb0d2f7b210e4b 
  3rdparty/libprocess/src/tests/statistics_tests.cpp 
144b5109cfb7640b29bec8de8f5b2ad00665212f 
  3rdparty/libprocess/src/tests/subprocess_tests.cpp 
8211ae63e75359705af2bb9ac02a7cbdb28e3252 
  3rdparty/libprocess/src/tests/system_tests.cpp 
6beb973e079c00ba3e632d6fb6c3c332483d203f 
  3rdparty/libprocess/src/tests/timeseries_tests.cpp 
4177fb673bbf510fe835af396cd76dae48a9ec85 


Diff: https://reviews.apache.org/r/65161/diff/2/

Changes: https://reviews.apache.org/r/65161/diff/1-2/


Testing
---

`make check`

These changes were made automatically with 
https://github.com/mesos/clang-tools-extra/pull/13 with only a few minor 
additions in surrounding code.


Thanks,

Benjamin Bannier