Re: Review Request 65166: Added libprocess benchmarks to cmake build setup.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65166/#review195654
---


Ship it!




Ship It!

- Andrew Schwartzmeyer


On Jan. 17, 2018, 12:42 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65166/
> ---
> 
> (Updated Jan. 17, 2018, 12:42 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> To make sure that `benchmarks` is built as part of the tests we add a
> dependency of `libprocess-tests` on `benchmarks` even though no actual
> compile- or runtime dependency exists.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/CMakeLists.txt 
> 8b76cab4d549e18e34aef39863188f37cde74223 
> 
> 
> Diff: https://reviews.apache.org/r/65166/diff/2/
> 
> 
> Testing
> ---
> 
> `make check`
> `ninja benchmarks && ./3rdparty/libprocess/src/tests/benchmarks`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 65166: Added libprocess benchmarks to cmake build setup.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65166/#review195653
---



PASS: Mesos patch 65166 was successfully built and tested.

Reviews applied: `['65166']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65166

- Mesos Reviewbot Windows


On Jan. 17, 2018, 8:42 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65166/
> ---
> 
> (Updated Jan. 17, 2018, 8:42 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> To make sure that `benchmarks` is built as part of the tests we add a
> dependency of `libprocess-tests` on `benchmarks` even though no actual
> compile- or runtime dependency exists.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/CMakeLists.txt 
> 8b76cab4d549e18e34aef39863188f37cde74223 
> 
> 
> Diff: https://reviews.apache.org/r/65166/diff/2/
> 
> 
> Testing
> ---
> 
> `make check`
> `ninja benchmarks && ./3rdparty/libprocess/src/tests/benchmarks`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 65166: Added libprocess benchmarks to cmake build setup.

[Andrew Schwartzmeyer]

> On Jan. 17, 2018, 2:12 p.m., Andrew Schwartzmeyer wrote:
> > 3rdparty/libprocess/src/tests/CMakeLists.txt
> > Lines 98-101 (patched)
> > 
> >
> > Would you rather it be part of the `tests` target explicitly? You could 
> > add it 
> > [here](https://github.com/apache/mesos/blob/24a746d85780051d862db0697b63c3c52db4362a/CMakeLists.txt#L60).
> > 
> > ```
> > add_custom_target(tests DEPENDS stout-tests libprocess-tests 
> > mesos-tests)
> > ```
> > 
> > I think it probably makes more sense.

Then again, it's explicitly benchmarks for libprocess, so it also makes sense 
as a dependency of `libprocess-tests`. Yeah, nevermind, this is fine I think.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65166/#review195651
---


On Jan. 17, 2018, 12:42 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65166/
> ---
> 
> (Updated Jan. 17, 2018, 12:42 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> To make sure that `benchmarks` is built as part of the tests we add a
> dependency of `libprocess-tests` on `benchmarks` even though no actual
> compile- or runtime dependency exists.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/CMakeLists.txt 
> 8b76cab4d549e18e34aef39863188f37cde74223 
> 
> 
> Diff: https://reviews.apache.org/r/65166/diff/2/
> 
> 
> Testing
> ---
> 
> `make check`
> `ninja benchmarks && ./3rdparty/libprocess/src/tests/benchmarks`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 65166: Added libprocess benchmarks to cmake build setup.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65166/#review195651
---




3rdparty/libprocess/src/tests/CMakeLists.txt
Lines 98-101 (patched)


Would you rather it be part of the `tests` target explicitly? You could add 
it 
[here](https://github.com/apache/mesos/blob/24a746d85780051d862db0697b63c3c52db4362a/CMakeLists.txt#L60).

```
add_custom_target(tests DEPENDS stout-tests libprocess-tests mesos-tests)
```

I think it probably makes more sense.


- Andrew Schwartzmeyer


On Jan. 17, 2018, 12:42 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65166/
> ---
> 
> (Updated Jan. 17, 2018, 12:42 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> To make sure that `benchmarks` is built as part of the tests we add a
> dependency of `libprocess-tests` on `benchmarks` even though no actual
> compile- or runtime dependency exists.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/CMakeLists.txt 
> 8b76cab4d549e18e34aef39863188f37cde74223 
> 
> 
> Diff: https://reviews.apache.org/r/65166/diff/2/
> 
> 
> Testing
> ---
> 
> `make check`
> `ninja benchmarks && ./3rdparty/libprocess/src/tests/benchmarks`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 65166: Added libprocess benchmarks to cmake build setup.

[Benjamin Bannier]

> On Jan. 17, 2018, 7:58 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/src/tests/CMakeLists.txt
> > Lines 91-93 (patched)
> > 
> >
> > We don't want to build this executable by default, so drop a 
> > `EXCLUDE_FROM_ALL` in here.
> > 
> > ```
> > add_executable(
> >   benchmarks EXCLUDE_FROM_ALL
> >   benchmarks.cpp
> >   benchmarks.pb.cc)
> > ```

Like discussed offline, we would still want to make sure that this target is 
built at all. I added a dummy dependency of `libprocess-tests` on `benchmarks` 
to make sure it is built as part of e.g., `check`.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65166/#review195631
---


On Jan. 17, 2018, 9:42 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65166/
> ---
> 
> (Updated Jan. 17, 2018, 9:42 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> To make sure that `benchmarks` is built as part of the tests we add a
> dependency of `libprocess-tests` on `benchmarks` even though no actual
> compile- or runtime dependency exists.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/CMakeLists.txt 
> 8b76cab4d549e18e34aef39863188f37cde74223 
> 
> 
> Diff: https://reviews.apache.org/r/65166/diff/2/
> 
> 
> Testing
> ---
> 
> `make check`
> `ninja benchmarks && ./3rdparty/libprocess/src/tests/benchmarks`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 65166: Added libprocess benchmarks to cmake build setup.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65166/
---

(Updated Jan. 17, 2018, 9:42 p.m.)


Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.


Changes
---

Addressed comments from Joseph.


Repository: mesos


Description (updated)
---

To make sure that `benchmarks` is built as part of the tests we add a
dependency of `libprocess-tests` on `benchmarks` even though no actual
compile- or runtime dependency exists.


Diffs (updated)
-

  3rdparty/libprocess/src/tests/CMakeLists.txt 
8b76cab4d549e18e34aef39863188f37cde74223 


Diff: https://reviews.apache.org/r/65166/diff/2/

Changes: https://reviews.apache.org/r/65166/diff/1-2/


Testing
---

`make check`
`ninja benchmarks && ./3rdparty/libprocess/src/tests/benchmarks`


Thanks,

Benjamin Bannier

Re: Review Request 65166: Added libprocess benchmarks to cmake build setup.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65166/#review195631
---


Fix it, then Ship it!





3rdparty/libprocess/src/tests/CMakeLists.txt
Lines 81-82 (patched)


Stylistically, we've cut back a bit on these header sections (we could 
probably revise the text in the stout/tests CMakeLists).  

It is nice to call out since benchmarks are not normally built.  You could 
change it to something like:
```
# LIBPROCESS BENCHMARK TESTS

```



3rdparty/libprocess/src/tests/CMakeLists.txt
Lines 91-93 (patched)


We don't want to build this executable by default, so drop a 
`EXCLUDE_FROM_ALL` in here.

```
add_executable(
  benchmarks EXCLUDE_FROM_ALL
  benchmarks.cpp
  benchmarks.pb.cc)
```


- Joseph Wu


On Jan. 15, 2018, 3:48 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65166/
> ---
> 
> (Updated Jan. 15, 2018, 3:48 a.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added libprocess benchmarks to cmake build setup.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/CMakeLists.txt 
> 8b76cab4d549e18e34aef39863188f37cde74223 
> 
> 
> Diff: https://reviews.apache.org/r/65166/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> `ninja benchmarks && ./3rdparty/libprocess/src/tests/benchmarks`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 65166: Added libprocess benchmarks to cmake build setup.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65166/#review195418
---



PASS: Mesos patch 65166 was successfully built and tested.

Reviews applied: `['65166']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65166

- Mesos Reviewbot Windows


On Jan. 15, 2018, 3:48 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65166/
> ---
> 
> (Updated Jan. 15, 2018, 3:48 a.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added libprocess benchmarks to cmake build setup.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/CMakeLists.txt 
> 8b76cab4d549e18e34aef39863188f37cde74223 
> 
> 
> Diff: https://reviews.apache.org/r/65166/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> `ninja benchmarks && ./3rdparty/libprocess/src/tests/benchmarks`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>