Re: Review Request 65446: Added helper function for the agent to send `ExitedExecutorMessage`.

2018-02-08 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65446/#review197105
---


Ship it!




Ship It!

- Vinod Kone


On Feb. 5, 2018, 2:45 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65446/
> ---
> 
> (Updated Feb. 5, 2018, 2:45 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Vinod Kone.
> 
> 
> Bugs: MESOS-1720
> https://issues.apache.org/jira/browse/MESOS-1720
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added helper function for the agent to send `ExitedExecutorMessage`.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.hpp 09c01ebd1b5e8008ba9e7d412042f1db76a2c5a5 
>   src/slave/slave.cpp a6a5c93ab2d541c870cb52587495de20ed5ac1f4 
> 
> 
> Diff: https://reviews.apache.org/r/65446/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 65446: Added helper function for the agent to send `ExitedExecutorMessage`.

2018-02-04 Thread Meng Zhu 


> On Feb. 1, 2018, 10:24 a.m., Chun-Hung Hsiao wrote:
> > src/slave/slave.cpp
> > Lines 8141 (patched)
> > 
> >
> > Please leave a TODO here to say that we will need to add some 
> > reconciliation logic during re-registration since we don't retry this 
> > message.

You mean during agent re-regisetration with master? We already have 
reconciliation logic in master `reconcileKnownSlave()` that takes care of 
unknown executors.


- Meng


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65446/#review196640
---


On Feb. 4, 2018, 6:45 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65446/
> ---
> 
> (Updated Feb. 4, 2018, 6:45 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Vinod Kone.
> 
> 
> Bugs: MESOS-1720
> https://issues.apache.org/jira/browse/MESOS-1720
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added helper function for the agent to send `ExitedExecutorMessage`.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.hpp 09c01ebd1b5e8008ba9e7d412042f1db76a2c5a5 
>   src/slave/slave.cpp a6a5c93ab2d541c870cb52587495de20ed5ac1f4 
> 
> 
> Diff: https://reviews.apache.org/r/65446/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 65446: Added helper function for the agent to send `ExitedExecutorMessage`.

2018-02-04 Thread Meng Zhu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65446/
---

(Updated Feb. 4, 2018, 6:45 p.m.)


Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Vinod Kone.


Changes
---

Patch updated per discussion with Vinod. Made the status code optional and `-1` 
by default.


Bugs: MESOS-1720
https://issues.apache.org/jira/browse/MESOS-1720


Repository: mesos


Description
---

Added helper function for the agent to send `ExitedExecutorMessage`.


Diffs (updated)
-

  src/slave/slave.hpp 09c01ebd1b5e8008ba9e7d412042f1db76a2c5a5 
  src/slave/slave.cpp a6a5c93ab2d541c870cb52587495de20ed5ac1f4 


Diff: https://reviews.apache.org/r/65446/diff/2/

Changes: https://reviews.apache.org/r/65446/diff/1-2/


Testing
---

make check


Thanks,

Meng Zhu

Re: Review Request 65446: Added helper function for the agent to send `ExitedExecutorMessage`.

2018-02-01 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65446/#review196663
---


Ship it!




Ship It!

- Vinod Kone


On Feb. 1, 2018, 2:01 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65446/
> ---
> 
> (Updated Feb. 1, 2018, 2:01 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Vinod Kone.
> 
> 
> Bugs: MESOS-1720
> https://issues.apache.org/jira/browse/MESOS-1720
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added helper function for the agent to send `ExitedExecutorMessage`.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.hpp 09c01ebd1b5e8008ba9e7d412042f1db76a2c5a5 
>   src/slave/slave.cpp a6a5c93ab2d541c870cb52587495de20ed5ac1f4 
> 
> 
> Diff: https://reviews.apache.org/r/65446/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 65446: Added helper function for the agent to send `ExitedExecutorMessage`.

2018-02-01 Thread Chun-Hung Hsiao 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65446/#review196640
---


Fix it, then Ship it!





src/slave/slave.cpp
Lines 8141 (patched)


Please leave a TODO here to say that we will need to add some 
reconciliation logic during re-registration since we don't retry this message.


- Chun-Hung Hsiao


On Feb. 1, 2018, 2:01 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65446/
> ---
> 
> (Updated Feb. 1, 2018, 2:01 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Vinod Kone.
> 
> 
> Bugs: MESOS-1720
> https://issues.apache.org/jira/browse/MESOS-1720
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added helper function for the agent to send `ExitedExecutorMessage`.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.hpp 09c01ebd1b5e8008ba9e7d412042f1db76a2c5a5 
>   src/slave/slave.cpp a6a5c93ab2d541c870cb52587495de20ed5ac1f4 
> 
> 
> Diff: https://reviews.apache.org/r/65446/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>