Re: Review Request 65522: Fixed some log messages in `slave.cpp`.

2018-02-07 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65522/#review197049 --- FAIL: Failed to apply the dependent review: 65520. Failed

Re: Review Request 65522: Fixed some log messages in `slave.cpp`.

2018-02-07 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65522/ --- (Updated Feb. 7, 2018, 9:49 p.m.) Review request for mesos, Gaston Kleiman and

Re: Review Request 65522: Fixed some log messages in `slave.cpp`.

2018-02-07 Thread Chun-Hung Hsiao
> On Feb. 6, 2018, 6:29 p.m., Gaston Kleiman wrote: > > src/slave/slave.cpp > > Line 9530 (original), 9529 (patched) > > > > > > I noticed that if a single task is passed, we surround its ID in single > > quotes,

Re: Review Request 65522: Fixed some log messages in `slave.cpp`.

2018-02-07 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65522/#review197042 --- FAIL: Failed to apply the dependent review: 65520. Failed

Re: Review Request 65522: Fixed some log messages in `slave.cpp`.

2018-02-07 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65522/ --- (Updated Feb. 7, 2018, 6:45 p.m.) Review request for mesos, Gaston Kleiman and

Re: Review Request 65522: Fixed some log messages in `slave.cpp`.

2018-02-06 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65522/#review196947 --- Ship it! Ship It! - Jie Yu On Feb. 6, 2018, 4:17 a.m.,

Re: Review Request 65522: Fixed some log messages in `slave.cpp`.

2018-02-06 Thread Gaston Kleiman
> On Feb. 6, 2018, 10:29 a.m., Gaston Kleiman wrote: > > src/slave/slave.cpp > > Line 9530 (original), 9529 (patched) > > > > > > I noticed that if a single task is passed, we surround its ID in single > > quotes,

Re: Review Request 65522: Fixed some log messages in `slave.cpp`.

2018-02-06 Thread Chun-Hung Hsiao
> On Feb. 6, 2018, 6:29 p.m., Gaston Kleiman wrote: > > src/slave/slave.cpp > > Line 9530 (original), 9529 (patched) > > > > > > I noticed that if a single task is passed, we surround its ID in single > > quotes,

Re: Review Request 65522: Fixed some log messages in `slave.cpp`.

2018-02-06 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65522/#review196906 --- Fix it, then Ship it! I noticed a minor inconsistency in

Re: Review Request 65522: Fixed some log messages in `slave.cpp`.

2018-02-05 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65522/#review196865 --- FAIL: Some of the unit tests failed. Please check the relevant