Re: Review Request 65522: Fixed some log messages in `slave.cpp`.

2018-02-07 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65522/#review197049
---



FAIL: Failed to apply the dependent review: 65520.

Failed command: `python.exe .\support\apply-reviews.py -n -r 65520`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65522

Relevant logs:

- 
[apply-review-65520-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65522/logs/apply-review-65520-stdout.log):

```
error: patch failed: src/tests/storage_local_resource_provider_tests.cpp:73
error: src/tests/storage_local_resource_provider_tests.cpp: patch does not apply
```

- Mesos Reviewbot Windows


On Feb. 7, 2018, 9:49 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65522/
> ---
> 
> (Updated Feb. 7, 2018, 9:49 p.m.)
> 
> 
> Review request for mesos, Gaston Kleiman and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed some log messages in `slave.cpp`.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp a6a5c93ab2d541c870cb52587495de20ed5ac1f4 
> 
> 
> Diff: https://reviews.apache.org/r/65522/diff/3/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 65522: Fixed some log messages in `slave.cpp`.

2018-02-07 Thread Chun-Hung Hsiao 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65522/
---

(Updated Feb. 7, 2018, 9:49 p.m.)


Review request for mesos, Gaston Kleiman and Greg Mann.


Repository: mesos


Description
---

Fixed some log messages in `slave.cpp`.


Diffs (updated)
-

  src/slave/slave.cpp a6a5c93ab2d541c870cb52587495de20ed5ac1f4 


Diff: https://reviews.apache.org/r/65522/diff/3/

Changes: https://reviews.apache.org/r/65522/diff/2-3/


Testing
---

sudo make check


Thanks,

Chun-Hung Hsiao

Re: Review Request 65522: Fixed some log messages in `slave.cpp`.

2018-02-07 Thread Chun-Hung Hsiao 


> On Feb. 6, 2018, 6:29 p.m., Gaston Kleiman wrote:
> > src/slave/slave.cpp
> > Line 9530 (original), 9529 (patched)
> > 
> >
> > I noticed that if a single task is passed, we surround its ID in single 
> > quotes, but we don't do that if a task groups is passed.
> > 
> > We might want to do this consistently.
> 
> Chun-Hung Hsiao wrote:
> Would you prefer iterating throuch each ID and qouting them, or add a 
> pair of brackets surrounding them?
> 
> Gaston Kleiman wrote:
> I'd vote for the former.

Reverted this change for now since not everyone agrees on this one.


- Chun-Hung


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65522/#review196906
---


On Feb. 7, 2018, 6:45 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65522/
> ---
> 
> (Updated Feb. 7, 2018, 6:45 p.m.)
> 
> 
> Review request for mesos, Gaston Kleiman and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed some log messages in `slave.cpp`.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp a6a5c93ab2d541c870cb52587495de20ed5ac1f4 
> 
> 
> Diff: https://reviews.apache.org/r/65522/diff/2/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 65522: Fixed some log messages in `slave.cpp`.

2018-02-07 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65522/#review197042
---



FAIL: Failed to apply the dependent review: 65520.

Failed command: `python.exe .\support\apply-reviews.py -n -r 65520`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65522

Relevant logs:

- 
[apply-review-65520-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65522/logs/apply-review-65520-stdout.log):

```
error: patch failed: src/tests/storage_local_resource_provider_tests.cpp:73
error: src/tests/storage_local_resource_provider_tests.cpp: patch does not apply
```

- Mesos Reviewbot Windows


On Feb. 7, 2018, 6:45 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65522/
> ---
> 
> (Updated Feb. 7, 2018, 6:45 p.m.)
> 
> 
> Review request for mesos, Gaston Kleiman and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed some log messages in `slave.cpp`.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp a6a5c93ab2d541c870cb52587495de20ed5ac1f4 
> 
> 
> Diff: https://reviews.apache.org/r/65522/diff/2/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 65522: Fixed some log messages in `slave.cpp`.

2018-02-07 Thread Chun-Hung Hsiao 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65522/
---

(Updated Feb. 7, 2018, 6:45 p.m.)


Review request for mesos, Gaston Kleiman and Greg Mann.


Changes
---

Addressed Gaston's comments.


Repository: mesos


Description
---

Fixed some log messages in `slave.cpp`.


Diffs (updated)
-

  src/slave/slave.cpp a6a5c93ab2d541c870cb52587495de20ed5ac1f4 


Diff: https://reviews.apache.org/r/65522/diff/2/

Changes: https://reviews.apache.org/r/65522/diff/1-2/


Testing
---

sudo make check


Thanks,

Chun-Hung Hsiao

Re: Review Request 65522: Fixed some log messages in `slave.cpp`.

2018-02-06 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65522/#review196947
---


Ship it!




Ship It!

- Jie Yu


On Feb. 6, 2018, 4:17 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65522/
> ---
> 
> (Updated Feb. 6, 2018, 4:17 a.m.)
> 
> 
> Review request for mesos, Gaston Kleiman and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed some log messages in `slave.cpp`.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp a6a5c93ab2d541c870cb52587495de20ed5ac1f4 
> 
> 
> Diff: https://reviews.apache.org/r/65522/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 65522: Fixed some log messages in `slave.cpp`.

2018-02-06 Thread Gaston Kleiman 


> On Feb. 6, 2018, 10:29 a.m., Gaston Kleiman wrote:
> > src/slave/slave.cpp
> > Line 9530 (original), 9529 (patched)
> > 
> >
> > I noticed that if a single task is passed, we surround its ID in single 
> > quotes, but we don't do that if a task groups is passed.
> > 
> > We might want to do this consistently.
> 
> Chun-Hung Hsiao wrote:
> Would you prefer iterating throuch each ID and qouting them, or add a 
> pair of brackets surrounding them?

I'd vote for the former.


- Gaston


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65522/#review196906
---


On Feb. 5, 2018, 8:17 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65522/
> ---
> 
> (Updated Feb. 5, 2018, 8:17 p.m.)
> 
> 
> Review request for mesos, Gaston Kleiman and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed some log messages in `slave.cpp`.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp a6a5c93ab2d541c870cb52587495de20ed5ac1f4 
> 
> 
> Diff: https://reviews.apache.org/r/65522/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 65522: Fixed some log messages in `slave.cpp`.

2018-02-06 Thread Chun-Hung Hsiao 


> On Feb. 6, 2018, 6:29 p.m., Gaston Kleiman wrote:
> > src/slave/slave.cpp
> > Line 9530 (original), 9529 (patched)
> > 
> >
> > I noticed that if a single task is passed, we surround its ID in single 
> > quotes, but we don't do that if a task groups is passed.
> > 
> > We might want to do this consistently.

Would you prefer iterating throuch each ID and qouting them, or add a pair of 
brackets surrounding them?


- Chun-Hung


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65522/#review196906
---


On Feb. 6, 2018, 4:17 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65522/
> ---
> 
> (Updated Feb. 6, 2018, 4:17 a.m.)
> 
> 
> Review request for mesos, Gaston Kleiman and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed some log messages in `slave.cpp`.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp a6a5c93ab2d541c870cb52587495de20ed5ac1f4 
> 
> 
> Diff: https://reviews.apache.org/r/65522/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 65522: Fixed some log messages in `slave.cpp`.

2018-02-06 Thread Gaston Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65522/#review196906
---


Fix it, then Ship it!




I noticed a minor inconsistency in `taskOrTaskGroup` that we might want to 
address in a different patch.


src/slave/slave.cpp
Line 2091 (original), 2091 (patched)


nit: s/was killed partially/was partially killed/ here and below.



src/slave/slave.cpp
Line 9530 (original), 9529 (patched)


I noticed that if a single task is passed, we surround its ID in single 
quotes, but we don't do that if a task groups is passed.

We might want to do this consistently.


- Gaston Kleiman


On Feb. 5, 2018, 8:17 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65522/
> ---
> 
> (Updated Feb. 5, 2018, 8:17 p.m.)
> 
> 
> Review request for mesos, Gaston Kleiman and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed some log messages in `slave.cpp`.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp a6a5c93ab2d541c870cb52587495de20ed5ac1f4 
> 
> 
> Diff: https://reviews.apache.org/r/65522/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 65522: Fixed some log messages in `slave.cpp`.

2018-02-05 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65522/#review196865
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['65032', '65471', '65472', '65060', '65499', '65520', 
'65523', '65521', '65061', '65522']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65522

Relevant logs:

- 
[mesos-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65522/logs/mesos-tests-cmake-stdout.log):

```
 D:\DCOS\mesos\mesos\src\java\jni\convert.cpp(415): warning C4267: 
'argument': conversion from 'size_t' to 'jsize', possible loss of data 
[D:\DCOS\mesos\src\java\mesos-java.vcxproj]
 D:\DCOS\mesos\mesos\src\java\jni\convert.cpp(437): warning C4267: 
'argument': conversion from 'size_t' to 'jsize', possible loss of data 
[D:\DCOS\mesos\src\java\mesos-java.vcxproj]
 D:\DCOS\mesos\mesos\src\java\jni\convert.cpp(438): warning C4267: 
'argument': conversion from 'size_t' to 'jsize', possible loss of data 
[D:\DCOS\mesos\src\java\mesos-java.vcxproj]
 D:\DCOS\mesos\mesos\src\java\jni\convert.cpp(460): warning C4267: 
'argument': conversion from 'size_t' to 'jsize', possible loss of data 
[D:\DCOS\mesos\src\java\mesos-java.vcxproj]
 D:\DCOS\mesos\mesos\src\java\jni\convert.cpp(461): warning C4267: 
'argument': conversion from 'size_t' to 'jsize', possible loss of data 
[D:\DCOS\mesos\src\java\mesos-java.vcxproj]
 D:\DCOS\mesos\mesos\src\java\jni\convert.cpp(500): warning C4267: 
'argument': conversion from 'size_t' to 'jsize', possible loss of data 
[D:\DCOS\mesos\src\java\mesos-java.vcxproj]
 D:\DCOS\mesos\mesos\src\java\jni\convert.cpp(501): warning C4267: 
'argument': conversion from 'size_t' to 'jsize', possible loss of data 
[D:\DCOS\mesos\src\java\mesos-java.vcxproj]
 
D:\DCOS\mesos\mesos\src\java\jni\org_apache_mesos_state_Variable.cpp(44): 
warning C4267: 'argument': conversion from 'size_t' to 'jsize', possible loss 
of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
 
D:\DCOS\mesos\mesos\src\java\jni\org_apache_mesos_state_Variable.cpp(45): 
warning C4267: 'argument': conversion from 'size_t' to 'jsize', possible loss 
of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
 D:\DCOS\mesos\mesos\src\jvm\jvm.cpp(95): warning C4267: '=': 
conversion from 'size_t' to 'jint', possible loss of data 
[D:\DCOS\mesos\src\java\mesos-java.vcxproj]
 D:\DCOS\mesos\mesos\src\jvm\jvm.cpp(463): warning C4244: 
'initializing': conversion from 'jchar' to 'char', possible loss of data 
[D:\DCOS\mesos\src\java\mesos-java.vcxproj]
 D:\DCOS\mesos\mesos\src\jvm\jvm.cpp(493): warning C4244: 
'initializing': conversion from 'jlong' to 'long', possible loss of data 
[D:\DCOS\mesos\src\java\mesos-java.vcxproj]
 D:\DCOS\mesos\mesos\src\jvm\jvm.cpp(654): warning C4244: 
'initializing': conversion from 'jchar' to 'char', possible loss of data 
[D:\DCOS\mesos\src\java\mesos-java.vcxproj]
 D:\DCOS\mesos\mesos\src\jvm\jvm.cpp(693): warning C4244: 
'initializing': conversion from 'jlong' to 'long', possible loss of data 
[D:\DCOS\mesos\src\java\mesos-java.vcxproj]
 D:\DCOS\mesos\mesos\src\jvm\jvm.cpp(770): warning C4244: 
'initializing': conversion from 'jchar' to 'char', possible loss of data 
[D:\DCOS\mesos\src\java\mesos-java.vcxproj]
 D:\DCOS\mesos\mesos\src\jvm\jvm.cpp(809): warning C4244: 
'initializing': conversion from 'jlong' to 'long', possible loss of data 
[D:\DCOS\mesos\src\java\mesos-java.vcxproj]


   "D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
   (Link target) -> 
 cluster.obj : error LNK2019: unresolved external symbol "class 
Try,class std::allocator >,class std::allocator,class std::allocator 
> > >,class Error> __cdecl mesos::csi::paths::getContainerPaths(class 
std::basic_string const &,class std::basic_string const &,class std::basic_string const &)" 
(?getContainerPaths@paths@csi@mesos@@YA?AV?$Try@V?$list@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@V?$allocator@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@2@@std@@VErrorAEBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@00@Z)
 referenced in function "public: void __cdecl ::operator()(void)const " 
(??R@@QEBAXXZ) 
[D:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
 cluster.obj : error LNK2019: unresolved external symbol "class 
Try __cdecl 
mesos::csi::paths::parseContainerPath(class std::basic_string const &,class