Re: Review Request 65574: Windows: Fixed handle inheritance in `create_process` wrapper.

2018-02-21 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65574/#review197994 --- Ship it! Ship It! - Akash Gupta On Feb. 21, 2018, 1:19

Re: Review Request 65574: Windows: Fixed handle inheritance in `create_process` wrapper.

2018-02-20 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65574/ --- (Updated Feb. 20, 2018, 5:19 p.m.) Review request for mesos, Akash Gupta, Jeff

Re: Review Request 65574: Windows: Fixed handle inheritance in `create_process` wrapper.

2018-02-20 Thread Andrew Schwartzmeyer
> On Feb. 20, 2018, 4:01 p.m., Akash Gupta wrote: > > 3rdparty/stout/include/stout/os/windows/shell.hpp > > Lines 275 (patched) > > > > > > It seems like you can have a race condition here if you send the same > >

Re: Review Request 65574: Windows: Fixed handle inheritance in `create_process` wrapper.

2018-02-20 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65574/#review197823 --- 3rdparty/stout/include/stout/os/windows/shell.hpp Lines 275

Re: Review Request 65574: Windows: Fixed handle inheritance in `create_process` wrapper.

2018-02-09 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65574/#review197196 --- LGTM, but I'd like this part of the chain to be committed