Re: Review Request 65593: Added a test to ensure master removes fail-launched deafult executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65593/#review197228 --- Patch looks great! Reviews applied: [65445, 65504, 65446, 65449, 65448, 65593] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Feb. 10, 2018, 12:36 a.m., Meng Zhu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65593/ > --- > > (Updated Feb. 10, 2018, 12:36 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-1720 > https://issues.apache.org/jira/browse/MESOS-1720 > > > Repository: mesos > > > Description > --- > > This test ensures that agent sends ExitedExecutorMessage when the > task group fails to launch due to unscheule GC failure. So that > master's executor bookkeeping entry is removed. > > > Diffs > - > > src/tests/slave_tests.cpp 628b0d0fc862264c9553e1660c7df548df9cd4a1 > > > Diff: https://reviews.apache.org/r/65593/diff/1/ > > > Testing > --- > > make check > > > Thanks, > > Meng Zhu > >
Re: Review Request 65593: Added a test to ensure master removes fail-launched deafult executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65593/#review197212 --- PASS: Mesos patch 65593 was successfully built and tested. Reviews applied: `['65445', '65504', '65446', '65449', '65448', '65593']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65593 - Mesos Reviewbot Windows On Feb. 10, 2018, 12:36 a.m., Meng Zhu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65593/ > --- > > (Updated Feb. 10, 2018, 12:36 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-1720 > https://issues.apache.org/jira/browse/MESOS-1720 > > > Repository: mesos > > > Description > --- > > This test ensures that agent sends ExitedExecutorMessage when the > task group fails to launch due to unscheule GC failure. So that > master's executor bookkeeping entry is removed. > > > Diffs > - > > src/tests/slave_tests.cpp 628b0d0fc862264c9553e1660c7df548df9cd4a1 > > > Diff: https://reviews.apache.org/r/65593/diff/1/ > > > Testing > --- > > make check > > > Thanks, > > Meng Zhu > >