Re: Review Request 65593: Added tests to check executor that failed to launch is removed.

2018-02-13 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65593/#review197478
---



Patch looks great!

Reviews applied: [65445, 65504, 65446, 65449, 65448, 65626, 65593]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Feb. 14, 2018, 3:33 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65593/
> ---
> 
> (Updated Feb. 14, 2018, 3:33 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-1720
> https://issues.apache.org/jira/browse/MESOS-1720
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Theses tests ensure that agent sends ExitedExecutorMessage when the
> task group fails to launch due to unschedule GC failure and when
> the task fails to launch due to task authorization failure.
> So that master's executor bookkeeping entry is removed.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 628b0d0fc862264c9553e1660c7df548df9cd4a1 
> 
> 
> Diff: https://reviews.apache.org/r/65593/diff/4/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 65593: Added tests to check executor that failed to launch is removed.

2018-02-13 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65593/#review197476
---



PASS: Mesos patch 65593 was successfully built and tested.

Reviews applied: `['65445', '65504', '65446', '65449', '65448', '65626', 
'65593']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65593

- Mesos Reviewbot Windows


On Feb. 14, 2018, 3:33 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65593/
> ---
> 
> (Updated Feb. 14, 2018, 3:33 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-1720
> https://issues.apache.org/jira/browse/MESOS-1720
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Theses tests ensure that agent sends ExitedExecutorMessage when the
> task group fails to launch due to unschedule GC failure and when
> the task fails to launch due to task authorization failure.
> So that master's executor bookkeeping entry is removed.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 628b0d0fc862264c9553e1660c7df548df9cd4a1 
> 
> 
> Diff: https://reviews.apache.org/r/65593/diff/4/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 65593: Added tests to check executor that failed to launch is removed.

2018-02-13 Thread Meng Zhu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65593/
---

(Updated Feb. 13, 2018, 7:33 p.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-1720
https://issues.apache.org/jira/browse/MESOS-1720


Repository: mesos


Description
---

Theses tests ensure that agent sends ExitedExecutorMessage when the
task group fails to launch due to unschedule GC failure and when
the task fails to launch due to task authorization failure.
So that master's executor bookkeeping entry is removed.


Diffs (updated)
-

  src/tests/slave_tests.cpp 628b0d0fc862264c9553e1660c7df548df9cd4a1 


Diff: https://reviews.apache.org/r/65593/diff/4/

Changes: https://reviews.apache.org/r/65593/diff/3-4/


Testing
---

make check


Thanks,

Meng Zhu

Re: Review Request 65593: Added tests to check executor that failed to launch is removed.

2018-02-13 Thread Chun-Hung Hsiao 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65593/#review197470
---


Fix it, then Ship it!





src/tests/slave_tests.cpp
Lines 4841 (patched)


Dispatch this in the slave's context.



src/tests/slave_tests.cpp
Lines 4852-4854 (patched)


These are not required since `exitedExecutorMessage` is processed 
synchronously in the master's context.



src/tests/slave_tests.cpp
Lines 4986 (patched)


Ditto.



src/tests/slave_tests.cpp
Lines 4997-4999 (patched)


Ditto.


- Chun-Hung Hsiao


On Feb. 13, 2018, 6:26 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65593/
> ---
> 
> (Updated Feb. 13, 2018, 6:26 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-1720
> https://issues.apache.org/jira/browse/MESOS-1720
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Theses tests ensure that agent sends ExitedExecutorMessage when the
> task group fails to launch due to unschedule GC failure and when
> the task fails to launch due to task authorization failure.
> So that master's executor bookkeeping entry is removed.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 628b0d0fc862264c9553e1660c7df548df9cd4a1 
> 
> 
> Diff: https://reviews.apache.org/r/65593/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 65593: Added tests to check executor that failed to launch is removed.

2018-02-13 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65593/#review197388
---



PASS: Mesos patch 65593 was successfully built and tested.

Reviews applied: `['65445', '65504', '65446', '65449', '65448', '65626', 
'65593']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65593

- Mesos Reviewbot Windows


On Feb. 13, 2018, 6:26 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65593/
> ---
> 
> (Updated Feb. 13, 2018, 6:26 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-1720
> https://issues.apache.org/jira/browse/MESOS-1720
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Theses tests ensure that agent sends ExitedExecutorMessage when the
> task group fails to launch due to unschedule GC failure and when
> the task fails to launch due to task authorization failure.
> So that master's executor bookkeeping entry is removed.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 628b0d0fc862264c9553e1660c7df548df9cd4a1 
> 
> 
> Diff: https://reviews.apache.org/r/65593/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 65593: Added tests to check executor that failed to launch is removed.

2018-02-12 Thread Meng Zhu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65593/
---

(Updated Feb. 12, 2018, 10:26 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Added one more test for task authorization failure.


Summary (updated)
-

Added tests to check executor that failed to launch is removed.


Bugs: MESOS-1720
https://issues.apache.org/jira/browse/MESOS-1720


Repository: mesos


Description (updated)
---

Theses tests ensure that agent sends ExitedExecutorMessage when the
task group fails to launch due to unschedule GC failure and when
the task fails to launch due to task authorization failure.
So that master's executor bookkeeping entry is removed.


Diffs (updated)
-

  src/tests/slave_tests.cpp 628b0d0fc862264c9553e1660c7df548df9cd4a1 


Diff: https://reviews.apache.org/r/65593/diff/3/

Changes: https://reviews.apache.org/r/65593/diff/2-3/


Testing
---

make check


Thanks,

Meng Zhu