Re: Review Request 65624: Added fetcher tests for `stderr` output.

2018-02-21 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65624/#review198054 --- Ship it! Ship It! - Akash Gupta On Feb. 20, 2018, 7:40

Re: Review Request 65624: Added fetcher tests for `stderr` output.

2018-02-21 Thread Andrew Schwartzmeyer
> On Feb. 20, 2018, 11:43 a.m., Jeff Coffler wrote: > > src/tests/fetcher_tests.cpp > > Lines 132 (patched) > > > > > > These tests pretty much check the fetcher in a "stand-alone" > > environment. Could you add

Re: Review Request 65624: Added fetcher tests for `stderr` output.

2018-02-20 Thread Andrew Schwartzmeyer
> On Feb. 20, 2018, 11:43 a.m., Jeff Coffler wrote: > > src/tests/fetcher_tests.cpp > > Lines 132 (patched) > > > > > > These tests pretty much check the fetcher in a "stand-alone" > > environment. Could you add

Re: Review Request 65624: Added fetcher tests for `stderr` output.

2018-02-20 Thread Jeff Coffler
> On Feb. 20, 2018, 7:43 p.m., Jeff Coffler wrote: > > src/tests/fetcher_tests.cpp > > Lines 132 (patched) > > > > > > These tests pretty much check the fetcher in a "stand-alone" > > environment. Could you add

Re: Review Request 65624: Added fetcher tests for `stderr` output.

2018-02-20 Thread Andrew Schwartzmeyer
> On Feb. 20, 2018, 11:43 a.m., Jeff Coffler wrote: > > src/tests/fetcher_tests.cpp > > Lines 132 (patched) > > > > > > These tests pretty much check the fetcher in a "stand-alone" > > environment. Could you add

Re: Review Request 65624: Added fetcher tests for `stderr` output.

2018-02-20 Thread Jeff Coffler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65624/#review197799 --- src/tests/fetcher_tests.cpp Lines 132 (patched)

Re: Review Request 65624: Added fetcher tests for `stderr` output.

2018-02-13 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65624/#review197400 --- Patch looks great! Reviews applied: [65397, 65398, 65399, 65400,

Re: Review Request 65624: Added fetcher tests for `stderr` output.

2018-02-12 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65624/#review197378 --- PASS: Mesos patch 65624 was successfully built and tested.