Re: Review Request 65674: Introduced helper for creating Mesos UUIDs.

2018-03-02 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65674/#review198539
---



Patch looks great!

Reviews applied: [65587, 65588, 65589, 65590, 65591, 65673, 65674]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Feb. 15, 2018, 6:54 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65674/
> ---
> 
> (Updated Feb. 15, 2018, 6:54 a.m.)
> 
> 
> Review request for mesos and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduced helper for creating Mesos UUIDs.
> 
> 
> Diffs
> -
> 
>   src/common/protobuf_utils.hpp 9a940db188436b9c5a39b0637cb4c15ee2ab5266 
>   src/common/protobuf_utils.cpp f516091e9208552488c154f34adde6f20d3413bf 
>   src/resource_provider/manager.cpp cc195a3d35b93dd6493951de1ff8a1cb8a886377 
>   src/resource_provider/storage/provider.cpp 
> 63dde512fd8cc9f68f5f48a96869eb09b23b6f4a 
>   src/slave/slave.cpp e2facb3c15a2f907f6497c58a36842ed707f2c70 
>   src/tests/operation_status_update_manager_tests.cpp 
> c4429f40e1d7226be59d8ba4283bd91e16799d5a 
>   src/tests/resource_provider_manager_tests.cpp 
> c8997ec41fe0c3e02b0f6ab205c9009205c992da 
>   src/tests/resource_provider_validation_tests.cpp 
> 9f34c459e24396815f4a785815f83923e276874f 
>   src/tests/slave_tests.cpp e253317a67019302f18afe11e2a314e716cec226 
> 
> 
> Diff: https://reviews.apache.org/r/65674/diff/3/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 65674: Introduced helper for creating Mesos UUIDs.

2018-03-02 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65674/#review198523
---



PASS: Mesos patch 65674 was successfully built and tested.

Reviews applied: `['65587', '65588', '65589', '65590', '65591', '65673', 
'65674']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65674

- Mesos Reviewbot Windows


On Feb. 15, 2018, 2:54 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65674/
> ---
> 
> (Updated Feb. 15, 2018, 2:54 p.m.)
> 
> 
> Review request for mesos and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduced helper for creating Mesos UUIDs.
> 
> 
> Diffs
> -
> 
>   src/common/protobuf_utils.hpp 9a940db188436b9c5a39b0637cb4c15ee2ab5266 
>   src/common/protobuf_utils.cpp f516091e9208552488c154f34adde6f20d3413bf 
>   src/resource_provider/manager.cpp cc195a3d35b93dd6493951de1ff8a1cb8a886377 
>   src/resource_provider/storage/provider.cpp 
> 63dde512fd8cc9f68f5f48a96869eb09b23b6f4a 
>   src/slave/slave.cpp e2facb3c15a2f907f6497c58a36842ed707f2c70 
>   src/tests/operation_status_update_manager_tests.cpp 
> c4429f40e1d7226be59d8ba4283bd91e16799d5a 
>   src/tests/resource_provider_manager_tests.cpp 
> c8997ec41fe0c3e02b0f6ab205c9009205c992da 
>   src/tests/resource_provider_validation_tests.cpp 
> 9f34c459e24396815f4a785815f83923e276874f 
>   src/tests/slave_tests.cpp e253317a67019302f18afe11e2a314e716cec226 
> 
> 
> Diff: https://reviews.apache.org/r/65674/diff/3/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 65674: Introduced helper for creating Mesos UUIDs.

2018-02-24 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65674/#review198253
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['65587', '65588', '65589', '65590', '65591', '65673', 
'65674']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65674

Relevant logs:

- 
[stout-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65674/logs/stout-tests-stdout.log):

```
[ RUN  ] RmdirTest.SYMLINK_RemoveDirectoryWithSymbolicLinkTargetFile
[   OK ] RmdirTest.SYMLINK_RemoveDirectoryWithSymbolicLinkTargetFile (5 ms)
[ RUN  ] RmdirTest.RemoveDirectoryButPreserveRoot
[   OK ] RmdirTest.RemoveDirectoryButPreserveRoot (7 ms)
[--] 11 tests from RmdirTest (63 ms total)

[--] 1 test from SocketTests
[ RUN  ] SocketTests.InitSocket
[   OK ] SocketTests.InitSocket (2 ms)
[--] 1 test from SocketTests (2 ms total)

[--] 2 tests from StrerrorTest
[ RUN  ] StrerrorTest.ValidErrno
[   OK ] StrerrorTest.ValidErrno (1 ms)
[ RUN  ] StrerrorTest.InvalidErrno
[   OK ] StrerrorTest.InvalidErrno (0 ms)
[--] 2 tests from StrerrorTest (2 ms total)

[--] Global test environment tear-down
[==] 273 tests from 46 test cases ran. (5313 ms total)
[  PASSED  ] 270 tests.
[  FAILED  ] 3 tests, listed below:
[  FAILED  ] OsTest.SYMLINK_Realpath
[  FAILED  ] FsTest.CreateDirectoryAtMaxPath
[  FAILED  ] FsTest.CreateDirectoryLongerThanMaxPath

 3 FAILED TESTS
  YOU HAVE 7 DISABLED TESTS

```

- 
[stout-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65674/logs/stout-tests-stderr.log):

```
'invalid.command' is not recognized as an internal or external command,
operable program or batch file.
Subcommand 'subcommand' is not available
Usage: command  [OPTIONS]

Available subcommands:
help
subcommand2

Multiple subcommands have name 'subcommand'
```

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65674/logs/mesos-tests-stdout.log):

```
[   OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (125 ms)
[--] 9 tests from Endpoint/SlaveEndpointTest (1220 ms total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (37 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (43 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (83 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2407 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (2431 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2601 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (2626 ms total)

[--] Global test environment tear-down
[==] 914 tests from 90 test cases ran. (466657 ms total)
[  PASSED  ] 913 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] FilesTest.DebugTest

 1 FAILED TEST
  YOU HAVE 211 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65674/logs/mesos-tests-stderr.log):

```
I0224 11:52:18.096415  8992 slave.cpp:3876] Shutting down framework 
91b15ae2-7689-4f99-8efc-205e18ed6cb1-
I0224 11:52:18.096415  8320 master.cpp:10168] Updating the state of task 
9f6627de-11ea-4026-b319-7820a28354a9 of framework 
91b15ae2-7689-4f99-8efc-205e18ed6cb1- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0224 11:52:18.097440  8992 slave.cpp:6569] Shutting down executor 
'9f6627de-11ea-4026-b319-7820a28354a9' of framework 
91b15ae2-7689-4f99-8efc-205e18ed6cb1- at executor(1)@10.3.1.11:61952
I0224 11:52:18.098415  8992 slave.cpp:922] Agent terminating
W0224 11:52:18.098415  8992 slave.cpp:3872] Ignoring shutdown framework 
91b15ae2-7689-4f99-8efc-205e18ed6cb1- because it is terminating
I0224 11:52:18.100414  8320 master.cpp:10267] Removing task 
9f6627de-11ea-4026-b319-7820a28354a9 with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework 91b15ae2-7689-4f99-8efc-205e18ed6cb1- on 
agent 91b15ae2-7689-4f9I0224 11:52:17.346493  8824 exec.cpp:162] Version: 1.6.0
I0224 11:52:17.384498  2668 exec.cpp:236] Executor registered on ag

Re: Review Request 65674: Introduced helper for creating Mesos UUIDs.

2018-02-23 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65674/#review198202
---



Patch looks great!

Reviews applied: [65587, 65588, 65589, 65590, 65591, 65673, 65674]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Feb. 15, 2018, 2:54 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65674/
> ---
> 
> (Updated Feb. 15, 2018, 2:54 p.m.)
> 
> 
> Review request for mesos and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduced helper for creating Mesos UUIDs.
> 
> 
> Diffs
> -
> 
>   src/common/protobuf_utils.hpp 9a940db188436b9c5a39b0637cb4c15ee2ab5266 
>   src/common/protobuf_utils.cpp f516091e9208552488c154f34adde6f20d3413bf 
>   src/resource_provider/manager.cpp cc195a3d35b93dd6493951de1ff8a1cb8a886377 
>   src/resource_provider/storage/provider.cpp 
> 33abc0e05a804969ae14da9cb9c58698ba1aaea5 
>   src/slave/slave.cpp e2facb3c15a2f907f6497c58a36842ed707f2c70 
>   src/tests/operation_status_update_manager_tests.cpp 
> c4429f40e1d7226be59d8ba4283bd91e16799d5a 
>   src/tests/resource_provider_manager_tests.cpp 
> c8997ec41fe0c3e02b0f6ab205c9009205c992da 
>   src/tests/resource_provider_validation_tests.cpp 
> 9f34c459e24396815f4a785815f83923e276874f 
>   src/tests/slave_tests.cpp e253317a67019302f18afe11e2a314e716cec226 
> 
> 
> Diff: https://reviews.apache.org/r/65674/diff/2/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 65674: Introduced helper for creating Mesos UUIDs.

2018-02-23 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65674/#review198183
---



FAIL: Failed to apply the dependent review: 65587.

Failed command: `python.exe .\support\apply-reviews.py -n -r 65587`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65674

Relevant logs:

- 
[apply-review-65587-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65674/logs/apply-review-65587-stdout.log):

```

*** Please tell me who you are.

Run

  git config --global user.email "y...@example.com"
  git config --global user.name "Your Name"

to set your account's default identity.
Omit --global to set the identity only in this repository.

fatal: unable to auto-detect email address (got 'SYSTEM@build-srv-04.(none)')
```

- Mesos Reviewbot Windows


On Feb. 15, 2018, 2:54 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65674/
> ---
> 
> (Updated Feb. 15, 2018, 2:54 p.m.)
> 
> 
> Review request for mesos and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduced helper for creating Mesos UUIDs.
> 
> 
> Diffs
> -
> 
>   src/common/protobuf_utils.hpp 9a940db188436b9c5a39b0637cb4c15ee2ab5266 
>   src/common/protobuf_utils.cpp f516091e9208552488c154f34adde6f20d3413bf 
>   src/resource_provider/manager.cpp cc195a3d35b93dd6493951de1ff8a1cb8a886377 
>   src/resource_provider/storage/provider.cpp 
> 33abc0e05a804969ae14da9cb9c58698ba1aaea5 
>   src/slave/slave.cpp e2facb3c15a2f907f6497c58a36842ed707f2c70 
>   src/tests/operation_status_update_manager_tests.cpp 
> c4429f40e1d7226be59d8ba4283bd91e16799d5a 
>   src/tests/resource_provider_manager_tests.cpp 
> c8997ec41fe0c3e02b0f6ab205c9009205c992da 
>   src/tests/resource_provider_validation_tests.cpp 
> 9f34c459e24396815f4a785815f83923e276874f 
>   src/tests/slave_tests.cpp e253317a67019302f18afe11e2a314e716cec226 
> 
> 
> Diff: https://reviews.apache.org/r/65674/diff/2/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 65674: Introduced helper for creating Mesos UUIDs.

2018-02-23 Thread Jan Schlicht 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65674/#review198172
---




src/common/protobuf_utils.hpp
Lines 187 (patched)


Nit: We should document that using `None()` here will create a random UUID. 
These helper function currently have the semantic that an `Option` parameter 
indicated an optional field in the underlying protobuf. This assumption is 
broken here. And (not yours) is also broken in `createOperation` were we should 
document it as well.


- Jan Schlicht


On Feb. 15, 2018, 3:54 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65674/
> ---
> 
> (Updated Feb. 15, 2018, 3:54 p.m.)
> 
> 
> Review request for mesos and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduced helper for creating Mesos UUIDs.
> 
> 
> Diffs
> -
> 
>   src/common/protobuf_utils.hpp 9a940db188436b9c5a39b0637cb4c15ee2ab5266 
>   src/common/protobuf_utils.cpp b5c2997ada8362e42150fa3cfd762120e5ea715f 
>   src/resource_provider/manager.cpp cc195a3d35b93dd6493951de1ff8a1cb8a886377 
>   src/slave/slave.cpp c5ec62c0e55e7416d9cd2a49c13459b85e315150 
>   src/tests/operation_status_update_manager_tests.cpp 
> c4429f40e1d7226be59d8ba4283bd91e16799d5a 
>   src/tests/resource_provider_manager_tests.cpp 
> c8997ec41fe0c3e02b0f6ab205c9009205c992da 
>   src/tests/resource_provider_validation_tests.cpp 
> 9f34c459e24396815f4a785815f83923e276874f 
>   src/tests/slave_tests.cpp d2c242eae3169bff3b0197a36f171cd668ba 
> 
> 
> Diff: https://reviews.apache.org/r/65674/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 65674: Introduced helper for creating Mesos UUIDs.

2018-02-22 Thread Jan Schlicht 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65674/#review198119
---


Ship it!




Ship It!

- Jan Schlicht


On Feb. 15, 2018, 3:54 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65674/
> ---
> 
> (Updated Feb. 15, 2018, 3:54 p.m.)
> 
> 
> Review request for mesos and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduced helper for creating Mesos UUIDs.
> 
> 
> Diffs
> -
> 
>   src/common/protobuf_utils.hpp 9a940db188436b9c5a39b0637cb4c15ee2ab5266 
>   src/common/protobuf_utils.cpp b5c2997ada8362e42150fa3cfd762120e5ea715f 
>   src/resource_provider/manager.cpp cc195a3d35b93dd6493951de1ff8a1cb8a886377 
>   src/slave/slave.cpp c5ec62c0e55e7416d9cd2a49c13459b85e315150 
>   src/tests/operation_status_update_manager_tests.cpp 
> c4429f40e1d7226be59d8ba4283bd91e16799d5a 
>   src/tests/resource_provider_manager_tests.cpp 
> c8997ec41fe0c3e02b0f6ab205c9009205c992da 
>   src/tests/resource_provider_validation_tests.cpp 
> 9f34c459e24396815f4a785815f83923e276874f 
>   src/tests/slave_tests.cpp d2c242eae3169bff3b0197a36f171cd668ba 
> 
> 
> Diff: https://reviews.apache.org/r/65674/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 65674: Introduced helper for creating Mesos UUIDs.

2018-02-15 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65674/#review197622
---



Bad patch!

Reviews applied: [65674, 65673, 65591, 65590, 65589, 65588, 65587]

Failed command: python support/apply-reviews.py -n -r 65591

Error:
2018-02-15 15:50:38 URL:https://reviews.apache.org/r/65591/diff/raw/ 
[39317/39317] -> "65591.patch" [1]
error: patch failed: src/master/master.cpp:7565
error: src/master/master.cpp: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/21657/console

- Mesos Reviewbot


On Feb. 15, 2018, 2:54 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65674/
> ---
> 
> (Updated Feb. 15, 2018, 2:54 p.m.)
> 
> 
> Review request for mesos and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduced helper for creating Mesos UUIDs.
> 
> 
> Diffs
> -
> 
>   src/common/protobuf_utils.hpp 9a940db188436b9c5a39b0637cb4c15ee2ab5266 
>   src/common/protobuf_utils.cpp b5c2997ada8362e42150fa3cfd762120e5ea715f 
>   src/resource_provider/manager.cpp cc195a3d35b93dd6493951de1ff8a1cb8a886377 
>   src/slave/slave.cpp c5ec62c0e55e7416d9cd2a49c13459b85e315150 
>   src/tests/operation_status_update_manager_tests.cpp 
> c4429f40e1d7226be59d8ba4283bd91e16799d5a 
>   src/tests/resource_provider_manager_tests.cpp 
> c8997ec41fe0c3e02b0f6ab205c9009205c992da 
>   src/tests/resource_provider_validation_tests.cpp 
> 9f34c459e24396815f4a785815f83923e276874f 
>   src/tests/slave_tests.cpp d2c242eae3169bff3b0197a36f171cd668ba 
> 
> 
> Diff: https://reviews.apache.org/r/65674/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 65674: Introduced helper for creating Mesos UUIDs.

2018-02-15 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65674/#review197621
---



FAIL: Failed to apply the dependent review: 65589.

Failed command: `python.exe .\support\apply-reviews.py -n -r 65589`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65674

Relevant logs:

- 
[apply-review-65589-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65674/logs/apply-review-65589-stdout.log):

```
error: patch failed: src/v1/mesos.cpp:16
error: src/v1/mesos.cpp: patch does not apply
```

- Mesos Reviewbot Windows


On Feb. 15, 2018, 2:54 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65674/
> ---
> 
> (Updated Feb. 15, 2018, 2:54 p.m.)
> 
> 
> Review request for mesos and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduced helper for creating Mesos UUIDs.
> 
> 
> Diffs
> -
> 
>   src/common/protobuf_utils.hpp 9a940db188436b9c5a39b0637cb4c15ee2ab5266 
>   src/common/protobuf_utils.cpp b5c2997ada8362e42150fa3cfd762120e5ea715f 
>   src/resource_provider/manager.cpp cc195a3d35b93dd6493951de1ff8a1cb8a886377 
>   src/slave/slave.cpp c5ec62c0e55e7416d9cd2a49c13459b85e315150 
>   src/tests/operation_status_update_manager_tests.cpp 
> c4429f40e1d7226be59d8ba4283bd91e16799d5a 
>   src/tests/resource_provider_manager_tests.cpp 
> c8997ec41fe0c3e02b0f6ab205c9009205c992da 
>   src/tests/resource_provider_validation_tests.cpp 
> 9f34c459e24396815f4a785815f83923e276874f 
>   src/tests/slave_tests.cpp d2c242eae3169bff3b0197a36f171cd668ba 
> 
> 
> Diff: https://reviews.apache.org/r/65674/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>