----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65706/#review197755 -----------------------------------------------------------
LGTM. I cannot say a lot on the systemd and docker setup files; maybe you could pull in somebody who has a better idea there? support/mesos-mini/Dockerfile Lines 35 (patched) <https://reviews.apache.org/r/65706/#comment278038> `DOCKER_URL` support/mesos-mini/Dockerfile Lines 54-56 (original), 69-72 (patched) <https://reviews.apache.org/r/65706/#comment278037> We should be able to use a single invocation of `systemctl` here, RUN systemctl enable \ docker \ mesos-slave \ mesos-master \ maratho - Benjamin Bannier On Feb. 19, 2018, 7:30 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65706/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2018, 7:30 a.m.) > > > Review request for mesos and Benjamin Bannier. > > > Repository: mesos > > > Description > ------- > > Added Docker daemon to the Mesos mini container. > > > Diffs > ----- > > support/mesos-mini/Dockerfile 23568a30387fd8a77a3fb7f596f6019d1cd55d1c > support/mesos-mini/docker.service PRE-CREATION > support/mesos-mini/docker_daemon.json PRE-CREATION > support/mesos-mini/docker_env.sh PRE-CREATION > > > Diff: https://reviews.apache.org/r/65706/diff/1/ > > > Testing > ------- > > Built the image and tested locally. > > > Thanks, > > Jie Yu > >