Re: Review Request 65749: Added a new binary to test a hung Docker daemon.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65749/ --- (Updated Feb. 22, 2018, 11:24 p.m.) Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park. Bugs: MESOS-8591 https://issues.apache.org/jira/browse/MESOS-8591 Repository: mesos Description --- This binary is meant to be used in concert with the test fixture added by the next patch in this chain. These patches allow a test author to specify that particular calls to the Docker daemon should be delayed for a specified duration. Diffs - src/Makefile.am a2ba1e6de0868c7a4fe58304ec479dce039bc288 src/tests/CMakeLists.txt ade5180f6e072112ad4836aa436e8545260d2ae6 src/tests/test_docker.cpp PRE-CREATION Diff: https://reviews.apache.org/r/65749/diff/1/ Testing --- Thanks, Greg Mann
Re: Review Request 65749: Added a new binary to test a hung Docker daemon.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65749/#review198144 --- FAIL: Failed to apply the dependent review: 65683. Failed command: `python.exe .\support\apply-reviews.py -n -r 65683` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65749 Relevant logs: - [apply-review-65683-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65749/logs/apply-review-65683-stdout.log): ``` error: patch failed: src/docker/docker.cpp:1308 error: src/docker/docker.cpp: patch does not apply ``` - Mesos Reviewbot Windows On Feb. 22, 2018, 2:05 a.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65749/ > --- > > (Updated Feb. 22, 2018, 2:05 a.m.) > > > Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park. > > > Bugs: MESOS-8591 > https://issues.apache.org/jira/browse/MESOS-8591 > > > Repository: mesos > > > Description > --- > > This binary is meant to be used in concert with the > test fixture added by the next patch in this chain. > These patches allow a test author to specify that > particular calls to the Docker daemon should be > delayed for a specified duration. > > > Diffs > - > > src/Makefile.am a2ba1e6de0868c7a4fe58304ec479dce039bc288 > src/tests/CMakeLists.txt ade5180f6e072112ad4836aa436e8545260d2ae6 > src/tests/test_docker.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/65749/diff/1/ > > > Testing > --- > > > Thanks, > > Greg Mann > >
Re: Review Request 65749: Added a new binary to test a hung Docker daemon.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65749/#review198104 --- Just realized this binary is not necessary - it would be simpler if I just do this logic in the shell script which is written to disk in https://reviews.apache.org/r/65751/ - Greg Mann On Feb. 22, 2018, 10:05 a.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65749/ > --- > > (Updated Feb. 22, 2018, 10:05 a.m.) > > > Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park. > > > Bugs: MESOS-8591 > https://issues.apache.org/jira/browse/MESOS-8591 > > > Repository: mesos > > > Description > --- > > This binary is meant to be used in concert with the > test fixture added by the next patch in this chain. > These patches allow a test author to specify that > particular calls to the Docker daemon should be > delayed for a specified duration. > > > Diffs > - > > src/Makefile.am a2ba1e6de0868c7a4fe58304ec479dce039bc288 > src/tests/CMakeLists.txt ade5180f6e072112ad4836aa436e8545260d2ae6 > src/tests/test_docker.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/65749/diff/1/ > > > Testing > --- > > > Thanks, > > Greg Mann > >
