Re: Review Request 65811: Add `path::clean` to stout for normalizing path (for POSIX only now)

2018-03-16 Thread Jie Yu
> On March 16, 2018, 11:17 p.m., Jie Yu wrote: > > 3rdparty/stout/include/stout/path.hpp > > Lines 65 (patched) > > > > > > Can you add some tests for this? This warrents some tests. Also, please > > reach out to

Re: Review Request 65811: Add `path::clean` to stout for normalizing path (for POSIX only now)

2018-03-16 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65811/#review199363 --- 3rdparty/stout/include/stout/path.hpp Lines 65 (patched)

Re: Review Request 65811: Add `path::clean` to stout for normalizing path (for POSIX only now)

2018-03-16 Thread Jie Yu
> On March 2, 2018, 8:06 p.m., Chun-Hung Hsiao wrote: > > 3rdparty/stout/include/stout/path.hpp > > Lines 65 (patched) > > > > > > How about s/clean/normalize/? > > Jason Lai wrote: > Indeed I considered this

Re: Review Request 65811: Add `path::clean` to stout for normalizing path (for POSIX only now)

2018-03-14 Thread Jason Lai
> On March 2, 2018, 8:06 p.m., Chun-Hung Hsiao wrote: > > 3rdparty/stout/include/stout/path.hpp > > Lines 65 (patched) > > > > > > How about s/clean/normalize/? Indeed I considered this option. And I also considered

Re: Review Request 65811: Add `path::clean` to stout for normalizing path (for POSIX only now)

2018-03-02 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65811/#review198548 --- 3rdparty/stout/include/stout/path.hpp Lines 65 (patched)

Re: Review Request 65811: Add `path::clean` to stout for normalizing path (for POSIX only now)

2018-03-02 Thread Jason Lai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65811/ --- (Updated March 2, 2018, 7:40 p.m.) Review request for mesos, Anish Gupta, Eric

Re: Review Request 65811: Add `path::clean` to stout for normalizing path (for POSIX only now)

2018-02-27 Thread Jason Lai
> On Feb. 27, 2018, 5:42 p.m., Zhitao Li wrote: > > 3rdparty/stout/include/stout/path.hpp > > Lines 61 (patched) > > > > > > Can you clarify whether the rules also apply to windows properly with > > correct

Re: Review Request 65811: Add `path::clean` to stout for normalizing path (for POSIX only now)

2018-02-27 Thread Jason Lai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65811/ --- (Updated Feb. 27, 2018, 6:52 p.m.) Review request for mesos, Anish Gupta, Eric

Re: Review Request 65811: Add `path::clean` to stout for normalizing path (for POSIX only now)

2018-02-27 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65811/#review198334 --- 3rdparty/stout/include/stout/path.hpp Lines 61 (patched)