Re: Review Request 65811: Add `path::normalize` to stout for normalizing path (for POSIX only now)

2018-09-24 Thread Jason Lai
> On Sept. 24, 2018, 7:53 p.m., Eric Chung wrote: > > 3rdparty/stout/include/stout/path.hpp > > Lines 63 (patched) > > > > > > perhaps rephrase as: `...without touching the actual filesystem.` Fixed. > On Sept.

Re: Review Request 65811: Add `path::normalize` to stout for normalizing path (for POSIX only now)

2018-09-24 Thread Jason Lai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65811/ --- (Updated Sept. 24, 2018, 8:38 p.m.) Review request for mesos, Anish Gupta,

Re: Review Request 65811: Add `path::normalize` to stout for normalizing path (for POSIX only now)

2018-09-24 Thread Eric Chung
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65811/#review208903 --- 3rdparty/stout/include/stout/path.hpp Lines 63 (patched)

Re: Review Request 65811: Add `path::normalize` to stout for normalizing path (for POSIX only now)

2018-09-21 Thread Jason Lai
> On May 18, 2018, 10:08 p.m., Jie Yu wrote: > > 3rdparty/stout/include/stout/path.hpp > > Lines 60 (patched) > > > > > > In fact, I'd return `Try` if it escapes the root path, this will allow > > us to avoid some

Re: Review Request 65811: Add `path::normalize` to stout for normalizing path (for POSIX only now)

2018-09-21 Thread Jason Lai
> On May 18, 2018, 4:57 p.m., Jie Yu wrote: > > 3rdparty/stout/include/stout/path.hpp > > Lines 87 (patched) > > > > > > I small nits, i'd suggest the following to make the logic a bit easier > > to understand: > >

Re: Review Request 65811: Add `path::normalize` to stout for normalizing path (for POSIX only now)

2018-09-21 Thread Jason Lai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65811/ --- (Updated Sept. 21, 2018, 9:53 p.m.) Review request for mesos, Anish Gupta,

Re: Review Request 65811: Add `path::normalize` to stout for normalizing path (for POSIX only now)

2018-05-22 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65811/#review203605 --- Please update the commit message to < 72 characters: ``` $

Re: Review Request 65811: Add `path::normalize` to stout for normalizing path (for POSIX only now)

2018-05-21 Thread Jie Yu
> On May 18, 2018, 4:57 p.m., Jie Yu wrote: > > 3rdparty/stout/include/stout/path.hpp > > Lines 87 (patched) > > > > > > I small nits, i'd suggest the following to make the logic a bit easier > > to understand: > >

Re: Review Request 65811: Add `path::normalize` to stout for normalizing path (for POSIX only now)

2018-05-21 Thread Jie Yu
> On May 18, 2018, 4:57 p.m., Jie Yu wrote: > > 3rdparty/stout/include/stout/path.hpp > > Lines 87 (patched) > > > > > > I small nits, i'd suggest the following to make the logic a bit easier > > to understand: > >

Re: Review Request 65811: Add `path::normalize` to stout for normalizing path (for POSIX only now)

2018-05-20 Thread Jason Lai
> On May 18, 2018, 4:57 p.m., Jie Yu wrote: > > 3rdparty/stout/include/stout/path.hpp > > Lines 87 (patched) > > > > > > I small nits, i'd suggest the following to make the logic a bit easier > > to understand: > >

Re: Review Request 65811: Add `path::normalize` to stout for normalizing path (for POSIX only now)

2018-05-18 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65811/#review203453 --- 3rdparty/stout/include/stout/path.hpp Lines 60 (patched)

Re: Review Request 65811: Add `path::normalize` to stout for normalizing path (for POSIX only now)

2018-05-18 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65811/#review203392 --- Ship it! 3rdparty/stout/include/stout/path.hpp Lines 87

Re: Review Request 65811: Add `path::normalize` to stout for normalizing path (for POSIX only now)

2018-05-17 Thread Jason Lai
> On May 14, 2018, 9:34 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/include/stout/path.hpp > > Lines 74 (patched) > > > > > > This should just be `is Abs = path::absolute(path)`. The function is > > already

Re: Review Request 65811: Add `path::normalize` to stout for normalizing path (for POSIX only now)

2018-05-16 Thread Jason Lai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65811/ --- (Updated May 17, 2018, 1:06 a.m.) Review request for mesos, Anish Gupta, Eric

Re: Review Request 65811: Add `path::normalize` to stout for normalizing path (for POSIX only now)

2018-05-14 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65811/#review203072 --- 3rdparty/stout/include/stout/path.hpp Lines 74 (patched)

Re: Review Request 65811: Add `path::normalize` to stout for normalizing path (for POSIX only now)

2018-05-08 Thread Jason Lai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65811/ --- (Updated May 8, 2018, 6:41 p.m.) Review request for mesos, Anish Gupta, Eric