Re: Review Request 65868: Added inspect retries to the docker containerizer in `update` method.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65868/#review198564 --- Ship it! This is an improvement, but maybe we need to return a failure eventually for the containerizer::update() call. We could do that at a followup patch. - Gilbert Song On March 1, 2018, 10:12 a.m., Andrei Budnik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65868/ > --- > > (Updated March 1, 2018, 10:12 a.m.) > > > Review request for mesos, Gilbert Song and Greg Mann. > > > Bugs: MESOS-8605 > https://issues.apache.org/jira/browse/MESOS-8605 > > > Repository: mesos > > > Description > --- > > This patch fixes the bug when a terminal status update is never sent > after termination of the docker executor, when the Docker daemon hangs > for `inspect` command. A terminal status update is postponed until > containerizer `update` completes that uses `inspect` command to get > a PID of the docker container. To address the issue, we retry `inspect` > in the loop. > > > Diffs > - > > src/slave/constants.hpp 030fb05186f7f360010bb7e5b4948faac69771cc > src/slave/containerizer/docker.cpp 1f4eeb4628517707ab866014fcda9d9b15053d1f > > > Diff: https://reviews.apache.org/r/65868/diff/1/ > > > Testing > --- > > sudo make check (Fedora 25) > internal CI > > > Thanks, > > Andrei Budnik > >
Re: Review Request 65868: Added inspect retries to the docker containerizer in `update` method.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65868/#review198466 --- Patch looks great! Reviews applied: [65786, 65787, 65751, 65750, 65683, 65713, 65759, 65868] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On March 1, 2018, 10:12 a.m., Andrei Budnik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65868/ > --- > > (Updated March 1, 2018, 10:12 a.m.) > > > Review request for mesos, Gilbert Song and Greg Mann. > > > Bugs: MESOS-8605 > https://issues.apache.org/jira/browse/MESOS-8605 > > > Repository: mesos > > > Description > --- > > This patch fixes the bug when a terminal status update is never sent > after termination of the docker executor, when the Docker daemon hangs > for `inspect` command. A terminal status update is postponed until > containerizer `update` completes that uses `inspect` command to get > a PID of the docker container. To address the issue, we retry `inspect` > in the loop. > > > Diffs > - > > src/slave/constants.hpp 030fb05186f7f360010bb7e5b4948faac69771cc > src/slave/containerizer/docker.cpp 1f4eeb4628517707ab866014fcda9d9b15053d1f > > > Diff: https://reviews.apache.org/r/65868/diff/1/ > > > Testing > --- > > sudo make check (Fedora 25) > internal CI > > > Thanks, > > Andrei Budnik > >
Re: Review Request 65868: Added inspect retries to the docker containerizer in `update` method.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65868/#review198463 --- PASS: Mesos patch 65868 was successfully built and tested. Reviews applied: `['65713', '65759', '65868']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65868 - Mesos Reviewbot Windows On March 1, 2018, 6:12 p.m., Andrei Budnik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65868/ > --- > > (Updated March 1, 2018, 6:12 p.m.) > > > Review request for mesos, Gilbert Song and Greg Mann. > > > Bugs: MESOS-8605 > https://issues.apache.org/jira/browse/MESOS-8605 > > > Repository: mesos > > > Description > --- > > This patch fixes the bug when a terminal status update is never sent > after termination of the docker executor, when the Docker daemon hangs > for `inspect` command. A terminal status update is postponed until > containerizer `update` completes that uses `inspect` command to get > a PID of the docker container. To address the issue, we retry `inspect` > in the loop. > > > Diffs > - > > src/slave/constants.hpp 030fb05186f7f360010bb7e5b4948faac69771cc > src/slave/containerizer/docker.cpp 1f4eeb4628517707ab866014fcda9d9b15053d1f > > > Diff: https://reviews.apache.org/r/65868/diff/1/ > > > Testing > --- > > sudo make check (Fedora 25) > internal CI > > > Thanks, > > Andrei Budnik > >
