Re: Review Request 66011: Windows: Set 3rdparty libraries to link to CRT dynamically.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66011/#review199461 --- Ship it! Ship It! - Joseph Wu On March 19, 2018, 12:13 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66011/ > --- > > (Updated March 19, 2018, 12:13 p.m.) > > > Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, John > Kordich, Joseph Wu, and Michael Park. > > > Bugs: MESOS-8659 > https://issues.apache.org/jira/browse/MESOS-8659 > > > Repository: mesos > > > Description > --- > > This also fixes a bug where the `libevent` build on Windows would add > `''` to the compiler flags, which is an unrecognized flag, and sets > the names of our `CMAKE_FORWARD_ARGS` variables consistently (some > were missing the `FORWARD` part). > > > Diffs > - > > 3rdparty/CMakeLists.txt e0c1538eaaef4bf6a198e89867a13763f264deb3 > > > Diff: https://reviews.apache.org/r/66011/diff/3/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 66011: Windows: Set 3rdparty libraries to link to CRT dynamically.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66011/ --- (Updated March 19, 2018, 12:13 p.m.) Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, John Kordich, Joseph Wu, and Michael Park. Changes --- Rebased. Bugs: MESOS-8659 https://issues.apache.org/jira/browse/MESOS-8659 Repository: mesos Description --- This also fixes a bug where the `libevent` build on Windows would add `''` to the compiler flags, which is an unrecognized flag, and sets the names of our `CMAKE_FORWARD_ARGS` variables consistently (some were missing the `FORWARD` part). Diffs (updated) - 3rdparty/CMakeLists.txt e0c1538eaaef4bf6a198e89867a13763f264deb3 Diff: https://reviews.apache.org/r/66011/diff/3/ Changes: https://reviews.apache.org/r/66011/diff/2-3/ Testing --- Thanks, Andrew Schwartzmeyer
Re: Review Request 66011: Windows: Set 3rdparty libraries to link to CRT dynamically.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66011/#review199034 --- Ship it! Ship It! - John Kordich On March 9, 2018, 10:39 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66011/ > --- > > (Updated March 9, 2018, 10:39 p.m.) > > > Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, John > Kordich, Joseph Wu, and Michael Park. > > > Bugs: MESOS-8659 > https://issues.apache.org/jira/browse/MESOS-8659 > > > Repository: mesos > > > Description > --- > > This also fixes a bug where the `libevent` build on Windows would add > `''` to the compiler flags, which is an unrecognized flag, and sets > the names of our `CMAKE_FORWARD_ARGS` variables consistently (some > were missing the `FORWARD` part). > > > Diffs > - > > 3rdparty/CMakeLists.txt 61dc788edf96ca6e8e3ee736eb232c0c118e6191 > > > Diff: https://reviews.apache.org/r/66011/diff/1/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
