Re: Review Request 66022: Based website-related Docker images on ubuntu16.

[Benjamin Bannier]

> On March 12, 2018, 12:51 p.m., Alexander Rukletsov wrote:
> > site/Dockerfile
> > Lines 12 (patched)
> > 
> >
> > You likely want to add `--no-install-recommends` here as well, right?

I definitely want to, and now actually do.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66022/#review199016
---


On March 12, 2018, 2:29 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66022/
> ---
> 
> (Updated March 12, 2018, 2:29 p.m.)
> 
> 
> Review request for mesos, Armand Grillet and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We require a recent ruby version in order to build current version of
> native ruby extensions required by the website generator setup.
> 
> Instead of manually installing non-upstream ruby versions with the
> existing centos7-based website images, this patch changes the images
> to be based on ubuntu16 instead which already contains a recent enough
> ruby versions in the upstream repositories.
> 
> We also change the images to reuse the existing mesos-build images
> instead of duplicating the image setup for these parts.
> 
> 
> Diffs
> -
> 
>   site/Dockerfile 2dd9e288df51b50ce3553045c58be978ce0f3e8e 
>   support/mesos-website/Dockerfile 4156eb4112060332bc62ab14d50a685cc7ee0348 
> 
> 
> Diff: https://reviews.apache.org/r/66022/diff/2/
> 
> 
> Testing
> ---
> 
> Manually built the dev and jenkin images and verified that they contained all 
> required tools.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 66022: Based website-related Docker images on ubuntu16.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66022/
---

(Updated March 12, 2018, 2:29 p.m.)


Review request for mesos, Armand Grillet and Vinod Kone.


Changes
---

Consistently used `--no-install-recommends` with installation.


Repository: mesos


Description
---

We require a recent ruby version in order to build current version of
native ruby extensions required by the website generator setup.

Instead of manually installing non-upstream ruby versions with the
existing centos7-based website images, this patch changes the images
to be based on ubuntu16 instead which already contains a recent enough
ruby versions in the upstream repositories.

We also change the images to reuse the existing mesos-build images
instead of duplicating the image setup for these parts.


Diffs (updated)
-

  site/Dockerfile 2dd9e288df51b50ce3553045c58be978ce0f3e8e 
  support/mesos-website/Dockerfile 4156eb4112060332bc62ab14d50a685cc7ee0348 


Diff: https://reviews.apache.org/r/66022/diff/2/

Changes: https://reviews.apache.org/r/66022/diff/1-2/


Testing
---

Manually built the dev and jenkin images and verified that they contained all 
required tools.


Thanks,

Benjamin Bannier

Re: Review Request 66022: Based website-related Docker images on ubuntu16.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66022/#review199016
---


Ship it!





site/Dockerfile
Lines 12 (patched)


You likely want to add `--no-install-recommends` here as well, right?


- Alexander Rukletsov


On March 10, 2018, 5:49 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66022/
> ---
> 
> (Updated March 10, 2018, 5:49 p.m.)
> 
> 
> Review request for mesos, Armand Grillet and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We require a recent ruby version in order to build current version of
> native ruby extensions required by the website generator setup.
> 
> Instead of manually installing non-upstream ruby versions with the
> existing centos7-based website images, this patch changes the images
> to be based on ubuntu16 instead which already contains a recent enough
> ruby versions in the upstream repositories.
> 
> We also change the images to reuse the existing mesos-build images
> instead of duplicating the image setup for these parts.
> 
> 
> Diffs
> -
> 
>   site/Dockerfile 2dd9e288df51b50ce3553045c58be978ce0f3e8e 
>   support/mesos-website/Dockerfile 4156eb4112060332bc62ab14d50a685cc7ee0348 
> 
> 
> Diff: https://reviews.apache.org/r/66022/diff/1/
> 
> 
> Testing
> ---
> 
> Manually built the dev and jenkin images and verified that they contained all 
> required tools.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 66022: Based website-related Docker images on ubuntu16.

[Armand Grillet]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66022/#review198990
---


Ship it!




Tested successfully using `mesos-website-dev.sh`. s/`ruby versions`/`ruby 
version` in the second paragraph of the commit message.

- Armand Grillet


On March 10, 2018, 5:49 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66022/
> ---
> 
> (Updated March 10, 2018, 5:49 p.m.)
> 
> 
> Review request for mesos, Armand Grillet and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We require a recent ruby version in order to build current version of
> native ruby extensions required by the website generator setup.
> 
> Instead of manually installing non-upstream ruby versions with the
> existing centos7-based website images, this patch changes the images
> to be based on ubuntu16 instead which already contains a recent enough
> ruby versions in the upstream repositories.
> 
> We also change the images to reuse the existing mesos-build images
> instead of duplicating the image setup for these parts.
> 
> 
> Diffs
> -
> 
>   site/Dockerfile 2dd9e288df51b50ce3553045c58be978ce0f3e8e 
>   support/mesos-website/Dockerfile 4156eb4112060332bc62ab14d50a685cc7ee0348 
> 
> 
> Diff: https://reviews.apache.org/r/66022/diff/1/
> 
> 
> Testing
> ---
> 
> Manually built the dev and jenkin images and verified that they contained all 
> required tools.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>