Re: Review Request 66260: Tested `max_completion_time` support in command executor.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66260/
---

(Updated April 23, 2018, 3:18 p.m.)


Review request for mesos, Jason Lai and James Peach.


Bugs: MESOS-8725
https://issues.apache.org/jira/browse/MESOS-8725


Repository: mesos


Description
---

Tested `max_completion_time` support in command executor.


Diffs (updated)
-

  src/tests/command_executor_tests.cpp 3c5687f918deb8cdda8a97abb0fbd8d9b089926a 


Diff: https://reviews.apache.org/r/66260/diff/3/

Changes: https://reviews.apache.org/r/66260/diff/2-3/


Testing
---


Thanks,

Zhitao Li

Re: Review Request 66260: Tested `max_completion_time` support in command executor.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66260/#review201124
---


Fix it, then Ship it!





src/tests/command_executor_tests.cpp
Lines 287 (patched)


Can you do it like this:
```
EXPECT_CALL(sched, statusUpdate(_, _))
.WillOnce(FutureArg<1>())
.WillOnce(FutureArg<1>())
.WillOnce(FutureArg<1>());
```


- James Peach


On April 8, 2018, 12:52 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66260/
> ---
> 
> (Updated April 8, 2018, 12:52 a.m.)
> 
> 
> Review request for mesos, Jason Lai and James Peach.
> 
> 
> Bugs: MESOS-8725
> https://issues.apache.org/jira/browse/MESOS-8725
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Tested `max_completion_time` support in command executor.
> 
> 
> Diffs
> -
> 
>   src/tests/command_executor_tests.cpp 
> 3c5687f918deb8cdda8a97abb0fbd8d9b089926a 
> 
> 
> Diff: https://reviews.apache.org/r/66260/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 66260: Tested `max_completion_time` support in command executor.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66260/
---

(Updated April 7, 2018, 5:52 p.m.)


Review request for mesos, Jason Lai and James Peach.


Changes
---

Fix test accordingly.


Summary (updated)
-

Tested `max_completion_time` support in command executor.


Bugs: MESOS-8725
https://issues.apache.org/jira/browse/MESOS-8725


Repository: mesos


Description (updated)
---

Tested `max_completion_time` support in command executor.


Diffs (updated)
-

  src/tests/command_executor_tests.cpp 3c5687f918deb8cdda8a97abb0fbd8d9b089926a 


Diff: https://reviews.apache.org/r/66260/diff/2/

Changes: https://reviews.apache.org/r/66260/diff/1-2/


Testing
---


Thanks,

Zhitao Li