Re: Review Request 66310: Passed on registrar when constructing resource provider manager.

2018-04-26 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66310/#review202029 --- Ship it! Ship It! - Chun-Hung Hsiao On April 26, 2018,

Re: Review Request 66310: Passed on registrar when constructing resource provider manager.

2018-04-26 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66310/ --- (Updated April 26, 2018, 2:39 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 66310: Passed on registrar when constructing resource provider manager.

2018-04-23 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66310/#review201753 --- Ship it! Ship It! - Chun-Hung Hsiao On April 23, 2018,

Re: Review Request 66310: Passed on registrar when constructing resource provider manager.

2018-04-23 Thread Benjamin Bannier
> On April 23, 2018, 3:05 a.m., Chun-Hung Hsiao wrote: > > src/tests/resource_provider_manager_tests.cpp > > Line 132 (original), 132 (patched) > > > > > > Do you think it is reasonable to always require a

Re: Review Request 66310: Passed on registrar when constructing resource provider manager.

2018-04-23 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66310/ --- (Updated April 23, 2018, 1:18 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 66310: Passed on registrar when constructing resource provider manager.

2018-04-22 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66310/#review201711 --- src/tests/resource_provider_manager_tests.cpp Line 132

Re: Review Request 66310: Passed on registrar when constructing resource provider manager.

2018-04-19 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66310/#review201606 --- Ship it! Ship It! - Chun-Hung Hsiao On April 19, 2018,

Re: Review Request 66310: Passed on registrar when constructing resource provider manager.

2018-04-19 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66310/ --- (Updated April 19, 2018, 2:28 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 66310: Passed on registrar when constructing resource provider manager.

2018-04-19 Thread Benjamin Bannier
> On April 19, 2018, 12:25 a.m., Chun-Hung Hsiao wrote: > > src/resource_provider/manager.cpp > > Line 160 (original), 161 (patched) > > > > > > `Owned&& _registrar`?

Re: Review Request 66310: Passed on registrar when constructing resource provider manager.

2018-04-18 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66310/#review201475 --- src/resource_provider/manager.hpp Lines 42 (patched)

Re: Review Request 66310: Passed on registrar when constructing resource provider manager.

2018-04-10 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66310/ --- (Updated April 10, 2018, 2:07 p.m.) Review request for mesos, Jie Yu and Jan