Re: Review Request 66323: Added tests for failed task launch on agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66323/ --- (Updated April 5, 2018, 5:36 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 66323: Added tests for failed task launch on agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66323/#review200582 --- src/tests/slave_tests.cpp Lines 5407 (patched)

Re: Review Request 66323: Added tests for failed task launch on agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66323/#review200581 --- Ship it! Ship It! - Greg Mann On April 4, 2018, 3:32 a.m.,

Re: Review Request 66323: Added tests for failed task launch on agent.

> On April 3, 2018, 5:17 p.m., Greg Mann wrote: > > src/tests/slave_tests.cpp > > Lines 5251-5252 (patched) > > > > > > Is this needed? > > Meng Zhu wrote: > To avoid uninteresting mock calls. > > Greg Mann

Re: Review Request 66323: Added tests for failed task launch on agent.

> On April 4, 2018, 12:17 a.m., Greg Mann wrote: > > src/tests/slave_tests.cpp > > Lines 5251-5252 (patched) > > > > > > Is this needed? > > Meng Zhu wrote: > To avoid uninteresting mock calls. The real

Re: Review Request 66323: Added tests for failed task launch on agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66323/#review200419 --- Patch looks great! Reviews applied: [66118, 66119, 66120, 65679,

Re: Review Request 66323: Added tests for failed task launch on agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66323/#review200417 --- PASS: Mesos patch 66323 was successfully built and tested.

Re: Review Request 66323: Added tests for failed task launch on agent.

> On April 3, 2018, 5:17 p.m., Greg Mann wrote: > > src/tests/slave_tests.cpp > > Lines 5249 (patched) > > > > > > Is this necessary? To avoid uninteresting mock calls. > On April 3, 2018, 5:17 p.m., Greg Mann

Re: Review Request 66323: Added tests for failed task launch on agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66323/ --- (Updated April 3, 2018, 8:32 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 66323: Added tests for failed task launch on agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66323/#review200398 --- src/tests/slave_tests.cpp Lines 5208 (patched)

Re: Review Request 66323: Added tests for failed task launch on agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66323/ --- (Updated March 30, 2018, 11:10 a.m.) Review request for mesos and Greg Mann.

Re: Review Request 66323: Added tests for failed task launch on agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66323/#review200154 --- PASS: Mesos patch 66323 was successfully built and tested.