Re: Review Request 66404: Removed check for nested cgroup support in `cgroups::prepare()`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66404/#review200631 --- Ship it! Ship It! - Alexander Rukletsov On April 3, 2018, 4:19 p.m., Andrei Budnik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66404/ > --- > > (Updated April 3, 2018, 4:19 p.m.) > > > Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-8489 > https://issues.apache.org/jira/browse/MESOS-8489 > > > Repository: mesos > > > Description > --- > > Previously, we were checking for nested cgroup support while trying to > create a linux launcher. This was necessary to make sure that the > kernel supports creating nested cgroups. As we don't support old > kernel versions which don't support nested cgroups, this check can be > safely removed. > > > Diffs > - > > src/linux/cgroups.cpp 682b288da8d56a623ef32cf6f0beecd9fc327622 > > > Diff: https://reviews.apache.org/r/66404/diff/2/ > > > Testing > --- > > internal CI > > > Thanks, > > Andrei Budnik > >
Re: Review Request 66404: Removed check for nested cgroup support in `cgroups::prepare()`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66404/#review200546 --- FAIL: Some of the unit tests failed. Please check the relevant logs. Reviews applied: `['66404']` Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66404 Relevant logs: - [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66404/logs/mesos-tests-stdout.log): ``` [ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (108 ms) [--] 9 tests from Endpoint/SlaveEndpointTest (1079 ms total) [--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest [ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 [ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (37 ms) [ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 [ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (39 ms) [--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (77 ms total) [--] 1 test from IsolationFlag/CpuIsolatorTest [ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 [ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (786 ms) [--] 1 test from IsolationFlag/CpuIsolatorTest (811 ms total) [--] 1 test from IsolationFlag/MemoryIsolatorTest [ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 [ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (848 ms) [--] 1 test from IsolationFlag/MemoryIsolatorTest (874 ms total) [--] Global test environment tear-down [==] 949 tests from 94 test cases ran. (445682 ms total) [ PASSED ] 948 tests. [ FAILED ] 1 test, listed below: [ FAILED ] CommandExecutorCheckTest.CommandCheckTimeout 1 FAILED TEST YOU HAVE 214 DISABLED TESTS ``` - [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66404/logs/mesos-tests-stderr.log): ``` I0405 13:14:05.483306 7352 hierarchical.cpp:405] Deactivated framework 0c3a33ec-2edf-4a7c-9a01-fa211fca1ff5- I0405 13:14:05.484505 6584 slave.cpp:3877] Shutting down framework 0c3a33ec-2edf-4a7c-9a01-fa211fca1ff5- I0405 13:14:05.484505 6584 slave.cpp:6574] Shutting down executor 'eea80d2a-f6e6-487d-863c-848577cde28d' of framework 0c3a33ec-2edf-4a7c-9a01-fa211fca1ff5- at executor(1)@10.3.1.8:52503 I0405 13:14:05.485291 6584 slave.cpp:923] Agent terminating W0405 13:14:05.486330 6584 slave.cpp:3873] Ignoring shutdown framework 0c3a33ec-2edf-4a7c-9a01-fa211fca1ff5- because it is terminating I0405 13:14:05.487377 15824 master.cpp:10548] Removing task eea80d2a-f6e6-487d-863c-848577cde28d with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 0c3a33ec-2edf-4a7c-9a01-fa211fca1ff5- on agent 0c3a33ec-2I0405 13:14:05.285285 7260 exec.cpp:162] Version: 1.6.0 I0405 13:14:05.312283 15564 exec.cpp:236] Executor registered on agent 0c3a33ec-2edf-4a7c-9a01-fa211fca1ff5-S0 I0405 13:14:05.316283 15092 executor.cpp:176] Received SUBSCRIBED event I0405 13:14:05.322288 15092 executor.cpp:180] Subscribed executor on winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net I0405 13:14:05.322288 15092 executor.cpp:176] Received LAUNCH event I0405 13:14:05.328284 15092 executor.cpp:648] Starting task eea80d2a-f6e6-487d-863c-848577cde28d I0405 13:14:05.410300 15092 executor.cpp:483] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch ' I0405 13:14:05.452358 15092 executor.cpp:661] Forked command at 2320 I0405 13:14:05.486330 7304 exec.cpp:445] Executor asked to shutdown I0405 13:14:05.487377 15260 executor.cpp:176] Received SHUTDOWN event I0405 13:14:05.487377 15260 executor.cpp:758] Shutting down I0405 13:14:05.487377 15260 executor.cpp:868] Sending SIGTERM to process tree at pid 2edf-4a7c-9a01-fa211fca1ff5-S0 at slave(418)@10.3.1.8:52482 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) I0405 13:14:05.490291 6584 containerizer.cpp:2338] Destroying container 9e60e77a-2de4-473c-8fab-63890979662e in RUNNING state I0405 13:14:05.490291 6584 containerizer.cpp:2952] Transitioning the state of container 9e60e77a-2de4-473c-8fab-63890979662e from RUNNING to DESTROYING I0405 13:14:05.491295 15824 master.cpp:1295] Agent 0c3a33ec-2edf-4a7c-9a01-fa211fca1ff5-S0 at slave(418)@10.3.1.8:52482 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected I0405 13:14:05.491295 6584 launcher.cpp:156] Asked to destroy container 9e60e77a-2de4-473c-8fab-63890979662e I0405 13:14:05.491295 15824 master.cpp:3286] Disconnecting agent 0c3a33ec-2edf-4a7c-9a01-fa211fca1ff5-S0 at slave(418)@10.3.1.8:52482
Re: Review Request 66404: Removed check for nested cgroup support in `cgroups::prepare()`.
> On April 3, 2018, 7:13 p.m., Gilbert Song wrote: > > LGTM, before landing this patch, could we verify the nested cgroup is > > alwasy supportted after kernel 2.6.23? Nested freezer cgroup is supported since kernel **2.6.28** ``` freezer (since Linux 2.6.28; CONFIG_CGROUP_FREEZER) The freezer cgroup can suspend and restore (resume) all pro? cesses in a cgroup. Freezing a cgroup /A also causes its children, for example, processes in /A/B, to be frozen. ``` Note, that we are trying to create a directory using `/sys/fs/cgroup/freezer/mesos/test` path. - Andrei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66404/#review200392 --- On April 3, 2018, 4:19 p.m., Andrei Budnik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66404/ > --- > > (Updated April 3, 2018, 4:19 p.m.) > > > Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-8489 > https://issues.apache.org/jira/browse/MESOS-8489 > > > Repository: mesos > > > Description > --- > > Previously, we were checking for nested cgroup support while trying to > create a linux launcher. This was necessary to make sure that the > kernel supports creating nested cgroups. As we don't support old > kernel versions which don't support nested cgroups, this check can be > safely removed. > > > Diffs > - > > src/linux/cgroups.cpp 682b288da8d56a623ef32cf6f0beecd9fc327622 > > > Diff: https://reviews.apache.org/r/66404/diff/1/ > > > Testing > --- > > internal CI > > > Thanks, > > Andrei Budnik > >
Re: Review Request 66404: Removed check for nested cgroup support in `cgroups::prepare()`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66404/#review200392 --- Ship it! LGTM, before landing this patch, could we verify the nested cgroup is alwasy supportted after kernel 2.6.23? - Gilbert Song On April 3, 2018, 9:19 a.m., Andrei Budnik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66404/ > --- > > (Updated April 3, 2018, 9:19 a.m.) > > > Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-8489 > https://issues.apache.org/jira/browse/MESOS-8489 > > > Repository: mesos > > > Description > --- > > Previously, we were checking for nested cgroup support while trying to > create a linux launcher. This was necessary to make sure that the > kernel supports creating nested cgroups. As we don't support old > kernel versions which don't support nested cgroups, this check can be > safely removed. > > > Diffs > - > > src/linux/cgroups.cpp 682b288da8d56a623ef32cf6f0beecd9fc327622 > > > Diff: https://reviews.apache.org/r/66404/diff/1/ > > > Testing > --- > > internal CI > > > Thanks, > > Andrei Budnik > >
Re: Review Request 66404: Removed check for nested cgroup support in `cgroups::prepare()`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66404/#review200389 --- Patch looks great! Reviews applied: [66404] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On April 3, 2018, 4:19 p.m., Andrei Budnik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66404/ > --- > > (Updated April 3, 2018, 4:19 p.m.) > > > Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-8489 > https://issues.apache.org/jira/browse/MESOS-8489 > > > Repository: mesos > > > Description > --- > > Previously, we were checking for nested cgroup support while trying to > create a linux launcher. This was necessary to make sure that the > kernel supports creating nested cgroups. As we don't support old > kernel versions which don't support nested cgroups, this check can be > safely removed. > > > Diffs > - > > src/linux/cgroups.cpp 682b288da8d56a623ef32cf6f0beecd9fc327622 > > > Diff: https://reviews.apache.org/r/66404/diff/1/ > > > Testing > --- > > internal CI > > > Thanks, > > Andrei Budnik > >
Re: Review Request 66404: Removed check for nested cgroup support in `cgroups::prepare()`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66404/#review200378 --- PASS: Mesos patch 66404 was successfully built and tested. Reviews applied: `['66404']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66404 - Mesos Reviewbot Windows On April 3, 2018, 4:19 p.m., Andrei Budnik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66404/ > --- > > (Updated April 3, 2018, 4:19 p.m.) > > > Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-8489 > https://issues.apache.org/jira/browse/MESOS-8489 > > > Repository: mesos > > > Description > --- > > Previously, we were checking for nested cgroup support while trying to > create a linux launcher. This was necessary to make sure that the > kernel supports creating nested cgroups. As we don't support old > kernel versions which don't support nested cgroups, this check can be > safely removed. > > > Diffs > - > > src/linux/cgroups.cpp 682b288da8d56a623ef32cf6f0beecd9fc327622 > > > Diff: https://reviews.apache.org/r/66404/diff/1/ > > > Testing > --- > > internal CI > > > Thanks, > > Andrei Budnik > >
