Re: Review Request 66418: Handled failed publish and unpublish CSI calls properly.

2018-04-12 Thread Chun-Hung Hsiao

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66418/
---

(Updated April 13, 2018, 1:24 a.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Changes
---

Addressed Jie's comments.


Bugs: MESOS-8717
https://issues.apache.org/jira/browse/MESOS-8717


Repository: mesos


Description
---

Previously, when a `ControllerPublishVolume` or a `NodePublishVolume`
fails, SLRP assumes the volume states remain unchanged, which are not
suggested by the CSI spec. This patch handles such failures properly.


Diffs (updated)
-

  src/resource_provider/storage/provider.cpp 
40544e08ab512041640f0f9036f841dbc55e78ca 


Diff: https://reviews.apache.org/r/66418/diff/3/

Changes: https://reviews.apache.org/r/66418/diff/2-3/


Testing
---

sudo make check


Thanks,

Chun-Hung Hsiao



Re: Review Request 66418: Handled failed publish and unpublish CSI calls properly.

2018-04-12 Thread Jie Yu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66418/#review201054
---


Fix it, then Ship it!





src/resource_provider/storage/provider.cpp
Line 2076 (original), 2076-2083 (patched)


Discussed offline. Let's move this to the caller and make this function a 
pure helper doing controller publish.



src/resource_provider/storage/provider.cpp
Lines 2194-2196 (original), 2190-2197 (patched)


Ditto.


- Jie Yu


On April 11, 2018, 2:37 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66418/
> ---
> 
> (Updated April 11, 2018, 2:37 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8717
> https://issues.apache.org/jira/browse/MESOS-8717
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously, when a `ControllerPublishVolume` or a `NodePublishVolume`
> fails, SLRP assumes the volume states remain unchanged, which are not
> suggested by the CSI spec. This patch handles such failures properly.
> 
> 
> Diffs
> -
> 
>   src/resource_provider/storage/provider.cpp 
> a07620d1c4bf618f669575b3e183bf598da905a6 
> 
> 
> Diff: https://reviews.apache.org/r/66418/diff/2/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>



Re: Review Request 66418: Handled failed publish and unpublish CSI calls properly.

2018-04-10 Thread Chun-Hung Hsiao

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66418/
---

(Updated April 11, 2018, 2:37 a.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Bugs: MESOS-8717
https://issues.apache.org/jira/browse/MESOS-8717


Repository: mesos


Description
---

Previously, when a `ControllerPublishVolume` or a `NodePublishVolume`
fails, SLRP assumes the volume states remain unchanged, which are not
suggested by the CSI spec. This patch handles such failures properly.


Diffs (updated)
-

  src/resource_provider/storage/provider.cpp 
a07620d1c4bf618f669575b3e183bf598da905a6 


Diff: https://reviews.apache.org/r/66418/diff/2/

Changes: https://reviews.apache.org/r/66418/diff/1-2/


Testing
---

sudo make check


Thanks,

Chun-Hung Hsiao



Re: Review Request 66418: Handled failed publish and unpublish CSI calls properly.

2018-04-03 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66418/#review200418
---



FAIL: Failed to apply the dependent review: 66398.

Failed command: `python.exe .\support\apply-reviews.py -n -r 66398`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66418

Relevant logs:

- 
[apply-review-66398-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66418/logs/apply-review-66398-stdout.log):

```
error: missing binary patch data for '3rdparty/csi-0.2.0.tar.gz'
error: binary patch does not apply to '3rdparty/csi-0.2.0.tar.gz'
error: 3rdparty/csi-0.2.0.tar.gz: patch does not apply
```

- Mesos Reviewbot Windows


On April 4, 2018, 4:01 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66418/
> ---
> 
> (Updated April 4, 2018, 4:01 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8717
> https://issues.apache.org/jira/browse/MESOS-8717
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously, when a `ControllerPublishVolume` or a `NodePublishVolume`
> fails, SLRP assumes the volume states remain unchanged, which are not
> suggested by the CSI spec. This patch handles such failures properly.
> 
> 
> Diffs
> -
> 
>   src/resource_provider/storage/provider.cpp 
> a07620d1c4bf618f669575b3e183bf598da905a6 
> 
> 
> Diff: https://reviews.apache.org/r/66418/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>